Commit Graph

17 Commits (085975ebe99fa80e888593b59b97ea4a873d3261)

Author SHA1 Message Date
Matthew Chen 085975ebe9 Prepopulate caption field with URL. 7 years ago
Matthew Chen b9bd21e73f Improve presentation of text attachments in attachment approval view. 7 years ago
Matthew Chen 6a80db7844 Enable support for sharing urls in SAE. 7 years ago
Michael Kirk 94d58b88b8 Play video inline in approval view
Previously we launched the MPMoviePlayerController

// FREEBIE
7 years ago
Michael Kirk 0c6a42003f clang-format after RI
// FREEBIE
7 years ago
Michael Kirk a423fe8a0e WIP Merge tag '2.19.4.4'
- restore video playback in fullscreen

This was a large merge, so I'm opting to make some changes in separate
commits.
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 38d94952f7 Shadow for Send button, clean up color accessors
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 513e33b0fd Cleanup before code review
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 2c20cb9e7b make sure mediaview isn't too tall in detail view
// FREEBIE
7 years ago
Michael Kirk 73b215229f Fixup approval view for audio and generic attachments
// FREEBIE
7 years ago
Michael Kirk 90e9b4a4f2 WIP - send all video types 7 years ago
Michael Kirk d3e7c99a63 Attachment approval: cancel/confirm to top/bottom toolbars
- avoid double-submit by disabling after hitting send.
- Animate SAE dismissal as modal
  Requires hiding the load view
- attachment is centered in screen
- add gradient to ensure controls are visible
- Fix clamp constraints - I think this was a typo
  Otherwise we couldn't show an image which was 1" wide by 2" tall
- set max zoom, hide scroll indicators
- use media view
- slower panning feels right
- white send button
- can share GIF, static, and sort of video...
- Play button for attachment approval
  - move to image assets so we can use it in SAE
  - slightly larger button for full-screen approval view
  - don't launch redundant fullscreen UI for images when in approval view
- fix scrollOffset in AttachmentApproval
- consolidate view initialization logic in loadView and fix white background
- CR: more legible arithmetic

// FREEBIE
7 years ago
Michael Kirk 0429836ff9 CR: rename keyWindow -> keyReferenceView, split long line
// FREEBIE
7 years ago
Michael Kirk eca19e5874 Reconcile MediaMessageView zoom behavior with AppExtension
Previously it was predicated on UIApplication.shared

// FREEBIE
7 years ago
Michael Kirk e20072ff2b CR: remove bundle specific image assets
// FREEBIE
7 years ago
Michael Kirk 56fe9d057d Attachment Approval
// FREEBIE
7 years ago
Michael Kirk a58f1f385c Share a photo from photos app
Shows the conversation picker, and sends the attachment to that
conversation.

There's still a lot TODO

-[ ] resolve JSQ dependency
-[ ] properly wait for app to load
-[ ] dismiss share extension after send is complete
-[ ] support non jpeg file types
-[ ] Fix device sleep manager

// FREEBIE
7 years ago