From fda5d656744b63065579cf4edbd013947f992b0b Mon Sep 17 00:00:00 2001 From: Michael Kirk Date: Tue, 8 May 2018 13:45:39 -0400 Subject: [PATCH] Avoid crash - reply only works from ConversationVC // FREEBIE --- .../ConversationView/ConversationViewItem.h | 2 ++ Signal/src/ViewControllers/MediaDetailViewController.m | 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/Signal/src/ViewControllers/ConversationView/ConversationViewItem.h b/Signal/src/ViewControllers/ConversationView/ConversationViewItem.h index fc9fc1cf2..e1911eb5a 100644 --- a/Signal/src/ViewControllers/ConversationView/ConversationViewItem.h +++ b/Signal/src/ViewControllers/ConversationView/ConversationViewItem.h @@ -118,6 +118,8 @@ NSString *NSStringForOWSMessageCellType(OWSMessageCellType cellType); - (void)shareTextAction; - (void)saveMediaAction; - (void)deleteAction; + +- (SEL)replyActionSelector; - (SEL)metadataActionSelector; @end diff --git a/Signal/src/ViewControllers/MediaDetailViewController.m b/Signal/src/ViewControllers/MediaDetailViewController.m index 86897515e..84227eb15 100644 --- a/Signal/src/ViewControllers/MediaDetailViewController.m +++ b/Signal/src/ViewControllers/MediaDetailViewController.m @@ -432,6 +432,14 @@ NS_ASSUME_NONNULL_BEGIN if (action == self.viewItem.metadataActionSelector) { return NO; } + + // Reply is not supported from MediaDetailView. + // TODO implement a "scroll to message" action which would + // let users scroll back to the media message in their message history. + if (action == self.viewItem.replyActionSelector) { + return NO; + } + return [self.viewItem canPerformAction:action]; }