Merge branch 'charlesmchen/incompleteAsserts'

Signal/src/ViewControllers/ConversationView/Cells/OWSMessageBubbleView.m

@@ -1103,7 +1103,7 @@ NS_ASSUME_NONNULL_BEGIN
             if (self.message.quotedMessage) {
                 [self.delegate didTapQuotedMessage:self.viewItem quotedMessage:self.message.quotedMessage];
             } else {
-                OWSFail(@"%@ Missing quoted message.", self.logTag)
+                OWSFail(@"%@ Missing quoted message.", self.logTag);
             }
             break;
     }

Signal/src/ViewControllers/ConversationView/ConversationViewItem.m

@@ -769,7 +769,7 @@ NSString *NSStringForOWSMessageCellType(OWSMessageCellType cellType)
             break;
         }
         case OWSMessageCellType_Unknown: {
-            OWSFail(@"%@ No text to share", self.logTag)
+            OWSFail(@"%@ No text to share", self.logTag);
         }
     }
 }

Signal/src/ViewControllers/DebugUI/DebugUIMessages.m

@@ -3948,7 +3948,7 @@ NS_ASSUME_NONNULL_BEGIN
             [label appendString:@" (Sent)"];
         }
     } else {
-        OWSFail(@"%@ unknown message state.", self.logTag)
+        OWSFail(@"%@ unknown message state.", self.logTag);
     }
     return label;
 }

SignalMessaging/attachments/SharingThreadPickerViewController.m

@@ -79,10 +79,9 @@ typedef void (^SendMessageBlock)(SendCompletionBlock completion);
 
 - (nullable UIView *)createHeaderWithSearchBar:(UISearchBar *)searchBar
 {
-    OWSAssert(searchBar)
+    OWSAssert(searchBar);
 
-        const CGFloat contentVMargin
-        = 0;
+    const CGFloat contentVMargin = 0;
 
     UIView *header = [UIView new];
     header.backgroundColor = [UIColor whiteColor];

SignalServiceKit/src/Messages/Attachments/TSAttachmentStream.m

@@ -432,8 +432,8 @@ NS_ASSUME_NONNULL_BEGIN
 
     NSData *thumbnailData = UIImageJPEGRepresentation(result, 0.9);
 
-    OWSAssert(thumbnailData.length > 0)
-        DDLogDebug(@"%@ generated thumbnail with size: %lu", self.logTag, (unsigned long)thumbnailData.length);
+    OWSAssert(thumbnailData.length > 0);
+    DDLogDebug(@"%@ generated thumbnail with size: %lu", self.logTag, (unsigned long)thumbnailData.length);
     [thumbnailData writeToFile:thumbnailPath atomically:YES];
 }
 

SignalServiceKit/src/Messages/OWSOutgoingNullMessage.m

@@ -60,8 +60,8 @@ NS_ASSUME_NONNULL_BEGIN
     // verification sync which is ~1-512 bytes larger then that.
     contentLength += self.verificationStateSyncMessage.paddingBytesLength;
 
-    OWSAssert(contentLength > 0)
-    
+    OWSAssert(contentLength > 0);
+
     nullMessageBuilder.padding = [Cryptography generateRandomBytes:contentLength];
     
     contentBuilder.nullMessage = [nullMessageBuilder build];