Return immutable data from generateSecureRandomData:length and use OSStatus to check the status of SecRandomCopyBytes. (#1306)

9 years ago · f8a0be4c70
parent b29174a374
commit f8a0be4c70
1 changed files with 3 additions and 3 deletions
--- a/Signal/src/crypto/CryptoTools.m
+++ b/Signal/src/crypto/CryptoTools.m
@ -10,11 +10,11 @@

 + (NSData *)generateSecureRandomData:(NSUInteger)length {
    NSMutableData *d = [NSMutableData dataWithLength:length];
-    int err          = SecRandomCopyBytes(kSecRandomDefault, length, [d mutableBytes]);
-    if (err != 0) {
+    OSStatus status  = SecRandomCopyBytes(kSecRandomDefault, length, [d mutableBytes]);
+    if (status != noErr) {
        [SecurityFailure raise:@"SecRandomCopyBytes failed"];
    }
-    return d;
+    return [d copy];
 }

 + (uint16_t)generateSecureRandomUInt16 {