Fixed a couple more bugs

Fixed an issue with updating the users profile image
Fixed an annoying bug where the conversation screen would "bounce" when initial loading

Session/Conversations/ConversationVC.swift

@@ -1194,14 +1194,17 @@ final class ConversationVC: BaseVC, OWSConversationSettingsViewDelegate, Convers
             return
         }
         
+        let targetIndexPath: IndexPath = IndexPath(
+            row: (self.viewModel.interactionData[messagesSectionIndex].elements.count - 1),
+            section: messagesSectionIndex
+        )
         self.tableView.scrollToRow(
-            at: IndexPath(
-                row: (self.viewModel.interactionData[messagesSectionIndex].elements.count - 1),
-                section: messagesSectionIndex
-            ),
+            at: targetIndexPath,
             at: .bottom,
             animated: isAnimated
         )
+        
+        self.handleInitialOffsetBounceBug(targetIndexPath: targetIndexPath, at: .bottom)
     }
 
     func scrollViewWillBeginDragging(_ scrollView: UIScrollView) {
@@ -1398,6 +1401,7 @@ final class ConversationVC: BaseVC, OWSConversationSettingsViewDelegate, Convers
                 at: position,
                 animated: (self.didFinishInitialLayout && isAnimated)
             )
+            self.handleInitialOffsetBounceBug(targetIndexPath: targetIndexPath, at: position)
             
             // If we haven't finished the initial layout then we want to delay the highlight slightly
             // so it doesn't look buggy with the push transition
@@ -1424,6 +1428,7 @@ final class ConversationVC: BaseVC, OWSConversationSettingsViewDelegate, Convers
         }
         
         self.tableView.scrollToRow(at: targetIndexPath, at: position, animated: true)
+        self.handleInitialOffsetBounceBug(targetIndexPath: targetIndexPath, at: position)
     }
     
     func highlightCellIfNeeded(interactionId: Int64) {
@@ -1439,4 +1444,32 @@ final class ConversationVC: BaseVC, OWSConversationSettingsViewDelegate, Convers
                 .highlight()
         }
     }
+    
+    private func handleInitialOffsetBounceBug(targetIndexPath: IndexPath, at position: UITableView.ScrollPosition) {
+        /// Note: This code is a hack to prevent a weird 'bounce' behaviour that occurs when triggering the initial scroll due
+        /// to the UITableView properly calculating it's cell sizes (it seems to layout ~3 times each with slightly different sizes)
+        if !self.hasPerformedInitialScroll {
+            let initialUpdateTime: CFTimeInterval = CACurrentMediaTime()
+            var lastSize: CGSize = .zero
+            
+            self.tableView.afterNextLayoutSubviews(
+                when: { [weak self] a, b, updatedContentSize in
+                    guard (CACurrentMediaTime() - initialUpdateTime) < 2 && lastSize != updatedContentSize else {
+                        return true
+                    }
+                    
+                    lastSize = updatedContentSize
+                    
+                    self?.tableView.scrollToRow(
+                        at: targetIndexPath,
+                        at: position,
+                        animated: false
+                    )
+                        
+                    return false
+                },
+                then: {}
+            )
+        }
+    }
 }

Session/Conversations/Views & Modals/InsetLockableTableView.swift

@@ -29,7 +29,7 @@ public class InsetLockableTableView: UITableView {
         // Store the callback locally to prevent infinite loops
         var callback: (() -> ())?
         
-        if self.testCallbackCondition() {
+        if self.checkCallbackCondition() {
             callback = self.afterLayoutSubviewsCallback
             self.afterLayoutSubviewsCallback = nil
         }
@@ -61,7 +61,7 @@ public class InsetLockableTableView: UITableView {
         self.afterLayoutSubviewsCallback = callback
     }
     
-    private func testCallbackCondition() -> Bool {
+    private func checkCallbackCondition() -> Bool {
         guard self.callbackCondition != nil else { return false }
         
         let numSections: Int = self.numberOfSections

SessionMessagingKit/Sending & Receiving/MessageReceiver.swift

@@ -345,7 +345,7 @@ public enum MessageReceiver {
         
         // Download the profile picture if needed
         db.afterNextTransactionCommit { _ in
-            ProfileManager.downloadAvatar(for: profile)
+            ProfileManager.downloadAvatar(for: updatedProfile)
         }
     }
 }

SessionMessagingKit/Utilities/ProfileManager.swift

@@ -129,11 +129,12 @@ public struct ProfileManager {
             return
         }
         
+        let queue: DispatchQueue = DispatchQueue.global(qos: .default)
         let fileName: String = UUID().uuidString.appendingFileExtension("jpg")
         let filePath: String = ProfileManager.profileAvatarFilepath(filename: fileName)
         var backgroundTask: OWSBackgroundTask? = OWSBackgroundTask(label: funcName)
         
-        DispatchQueue.global(qos: .default).async {
+        queue.async {
             OWSLogger.verbose("downloading profile avatar: \(profile.id)")
             currentAvatarDownloads.mutate { $0.insert(profile.id) }
             
@@ -141,7 +142,7 @@ public struct ProfileManager {
             
             FileServerAPI
                 .download(fileId, useOldServer: useOldServer)
-                .done { data in
+                .done(on: queue) { data in
                     currentAvatarDownloads.mutate { $0.remove(profile.id) }
                     
                     GRDBStorage.shared.write { db in
@@ -189,6 +190,13 @@ public struct ProfileManager {
                     // isn't used
                     if backgroundTask != nil { backgroundTask = nil }
                 }
+                .catch(on: queue) { _ in
+                    currentAvatarDownloads.mutate { $0.remove(profile.id) }
+                    
+                    // Redundant but without reading 'backgroundTask' it will warn that the variable
+                    // isn't used
+                    if backgroundTask != nil { backgroundTask = nil }
+                }
                 .retainUntilComplete()
         }
     }