From ddeadafc3bed41ede62bc79842db88dbc10749a5 Mon Sep 17 00:00:00 2001 From: Michael Kirk Date: Fri, 11 Nov 2016 10:19:42 -0500 Subject: [PATCH] Don't show own addressbook info in settings Some folks get the wrong idea and think Signal Service knows their name, when really, we were just showing them the entry for the registered phone number in their address book. In any case, presumably the user already knows their name, so we don't need to remind them. // FREEBIE --- .../SettingsTableViewController.m | 8 +------- .../translations/en.lproj/Localizable.strings | Bin 63442 -> 63440 bytes 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/Signal/src/view controllers/SettingsTableViewController.m b/Signal/src/view controllers/SettingsTableViewController.m index b7191af73..d28477ab9 100644 --- a/Signal/src/view controllers/SettingsTableViewController.m +++ b/Signal/src/view controllers/SettingsTableViewController.m @@ -68,7 +68,7 @@ typedef enum { self.tableView.tableFooterView = [[UIView alloc] initWithFrame:CGRectZero]; self.registeredNumber.text = [PhoneNumber bestEffortFormatPartialUserSpecifiedTextToLookLikeAPhoneNumber:[TSAccountManager localNumber]]; - [self findAndSetRegisteredName]; + self.registeredName.text = NSLocalizedString(@"REGISTERED_NUMBER_TEXT", @""); [self initializeObserver]; [TSSocketManager sendNotification]; @@ -99,12 +99,6 @@ typedef enum { [[NSNotificationCenter defaultCenter] removeObserver:self name:SocketConnectingNotification object:nil]; } -- (void)findAndSetRegisteredName { - NSString *name = NSLocalizedString(@"REGISTERED_NUMBER_TEXT", @""); - PhoneNumber *myNumber = [PhoneNumber phoneNumberFromE164:[TSAccountManager localNumber]]; - Contact *me = [[Environment.getCurrent contactsManager] latestContactForPhoneNumber:myNumber]; - self.registeredName.text = [me fullName] ? [me fullName] : name; -} #pragma mark - Table view data source - (NSInteger)numberOfSectionsInTableView:(UITableView *)tableView { diff --git a/Signal/translations/en.lproj/Localizable.strings b/Signal/translations/en.lproj/Localizable.strings index ef63be482f67ee4667d6105b7c58f27d2802cfc7..07ba1c4bb1509cbde6e6e65a7889148467d37168 100644 GIT binary patch delta 18 acmccgp83Li<_*S+C)=-<+U&o$IRpS*hY276 delta 26 icmcccp83*y<_*S+Co|rVnLJ;fXL9aprOnlgLqh