From d6826b94e072fe56241cbb078c6493575350f392 Mon Sep 17 00:00:00 2001 From: Matthew Chen Date: Wed, 13 Feb 2019 16:35:12 -0500 Subject: [PATCH] Respond to CR. --- .../OnboardingPermissionsViewController.swift | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/Signal/src/ViewControllers/Registration/OnboardingPermissionsViewController.swift b/Signal/src/ViewControllers/Registration/OnboardingPermissionsViewController.swift index 0770e797f..495d4b6c3 100644 --- a/Signal/src/ViewControllers/Registration/OnboardingPermissionsViewController.swift +++ b/Signal/src/ViewControllers/Registration/OnboardingPermissionsViewController.swift @@ -7,8 +7,7 @@ import PromiseKit @objc public class OnboardingPermissionsViewController: OWSViewController { - // Unlike a delegate, the OnboardingController we should retain a strong - // reference to the onboardingController. + // Unlike a delegate, we can and should retain a strong reference to the OnboardingController. private var onboardingController: OnboardingController @objc @@ -47,8 +46,7 @@ public class OnboardingPermissionsViewController: OWSViewController { titleLabel.lineBreakMode = .byWordWrapping titleLabel.textAlignment = .center view.addSubview(titleLabel) - titleLabel.autoPinWidthToSuperviewMargins() - titleLabel.autoPinEdge(toSuperviewMargin: .top) + titleLabel.autoPinEdges(toSuperviewMarginsExcludingEdge: .bottom) let explainerLabel = UILabel() // TODO: Finalize copy. @@ -98,9 +96,9 @@ public class OnboardingPermissionsViewController: OWSViewController { stackView.spacing = 40 view.addSubview(stackView) stackView.autoPinWidthToSuperviewMargins() - stackView.autoVCenterInSuperview() + stackView.autoPinEdge(.top, to: .bottom, of: titleLabel, withOffset: 20, relation: .greaterThanOrEqual) NSLayoutConstraint.autoSetPriority(.defaultHigh) { - stackView.autoPinEdge(.top, to: .bottom, of: titleLabel, withOffset: 20, relation: .greaterThanOrEqual) + stackView.autoVCenterInSuperview() } }