From c4677c9d4f662e347b0e2e89bbaec444595ed6ab Mon Sep 17 00:00:00 2001 From: Michael Kirk Date: Thu, 25 Oct 2018 12:17:58 -0600 Subject: [PATCH] CR: add some reachability asserts --- SignalServiceKit/src/Util/JobQueue.swift | 1 + SignalServiceKit/src/Util/OWSOperation.m | 1 + 2 files changed, 2 insertions(+) diff --git a/SignalServiceKit/src/Util/JobQueue.swift b/SignalServiceKit/src/Util/JobQueue.swift index 95cd6655d..588688707 100644 --- a/SignalServiceKit/src/Util/JobQueue.swift +++ b/SignalServiceKit/src/Util/JobQueue.swift @@ -233,6 +233,7 @@ public extension JobQueue { func becameReachable() { guard requiresInternet else { + owsFailDebug("should only be called if `requiresInternet` is true") return } diff --git a/SignalServiceKit/src/Util/OWSOperation.m b/SignalServiceKit/src/Util/OWSOperation.m index b04da4498..e3455a5f7 100644 --- a/SignalServiceKit/src/Util/OWSOperation.m +++ b/SignalServiceKit/src/Util/OWSOperation.m @@ -191,6 +191,7 @@ NSString *const OWSOperationKeyIsFinished = @"isFinished"; self.remainingRetries--; dispatch_sync(self.retryTimerSerialQueue, ^{ + OWSAssertDebug(self.retryTimer == nil); [self.retryTimer invalidate]; self.retryTimer = [NSTimer weakScheduledTimerWithTimeInterval:self.retryInterval target:self