From c3d2ea7abdd846117da2cc846129f13598c59b44 Mon Sep 17 00:00:00 2001
From: Matthew Chen <charlesmchen@gmail.com>
Date: Thu, 23 Mar 2017 12:41:15 -0400
Subject: [PATCH] Use a separate sending queue for each conversation.

// FREEBIE
---
 src/Messages/OWSMessageSender.m | 34 ++++++++++++++++++++++++++++-----
 1 file changed, 29 insertions(+), 5 deletions(-)

diff --git a/src/Messages/OWSMessageSender.m b/src/Messages/OWSMessageSender.m
index 1cc820d3e..d7a98db89 100644
--- a/src/Messages/OWSMessageSender.m
+++ b/src/Messages/OWSMessageSender.m
@@ -257,7 +257,7 @@ NSString *const OWSMessageSenderRateLimitedException = @"RateLimitedException";
 @property (nonatomic, readonly) id<ContactsManagerProtocol> contactsManager;
 @property (nonatomic, readonly) ContactsUpdater *contactsUpdater;
 @property (nonatomic, readonly) OWSDisappearingMessagesJob *disappearingMessagesJob;
-@property (nonatomic, readonly) NSOperationQueue *sendingQueue;
+@property (atomic, readonly) NSMutableDictionary *sendingQueueMap;
 
 @end
 
@@ -277,9 +277,7 @@ NSString *const OWSMessageSenderRateLimitedException = @"RateLimitedException";
     _storageManager = storageManager;
     _contactsManager = contactsManager;
     _contactsUpdater = contactsUpdater;
-    _sendingQueue = [NSOperationQueue new];
-    _sendingQueue.qualityOfService = NSOperationQualityOfServiceUserInitiated;
-    _sendingQueue.maxConcurrentOperationCount = 1;
+    _sendingQueueMap = [NSMutableDictionary new];
 
     _uploadingService = [[OWSUploadingService alloc] initWithNetworkManager:networkManager];
     _dbConnection = storageManager.newDatabaseConnection;
@@ -288,6 +286,30 @@ NSString *const OWSMessageSenderRateLimitedException = @"RateLimitedException";
     return self;
 }
 
+- (NSOperationQueue *)sendingQueueForMessage:(TSOutgoingMessage *)message
+{
+    OWSAssert(message);
+
+    NSString *kDefaultQueueKey = @"kDefaultQueueKey";
+    NSString *queueKey = message.uniqueThreadId ?: kDefaultQueueKey;
+    OWSAssert(queueKey.length > 0);
+
+    @synchronized(self)
+    {
+        NSOperationQueue *sendingQueue = self.sendingQueueMap[queueKey];
+
+        if (!sendingQueue) {
+            sendingQueue = [NSOperationQueue new];
+            sendingQueue.qualityOfService = NSOperationQualityOfServiceUserInitiated;
+            sendingQueue.maxConcurrentOperationCount = 1;
+
+            self.sendingQueueMap[queueKey] = sendingQueue;
+        }
+
+        return sendingQueue;
+    }
+}
+
 - (void)sendMessage:(TSOutgoingMessage *)message
             success:(void (^)())successHandler
             failure:(void (^)(NSError *error))failureHandler
@@ -303,7 +325,9 @@ NSString *const OWSMessageSenderRateLimitedException = @"RateLimitedException";
     // We call `startBackgroundTask` here to prevent our app from suspending while being backgrounded
     // until the operation is completed - at which point the OWSSendMessageOperation ends it's background task.
     [sendMessageOperation startBackgroundTask];
-    [self.sendingQueue addOperation:sendMessageOperation];
+
+    NSOperationQueue *sendingQueue = [self sendingQueueForMessage:message];
+    [sendingQueue addOperation:sendMessageOperation];
 }
 
 - (void)attemptToSendMessage:(TSOutgoingMessage *)message