Merge pull request #236 from RyanRory/thumbnail-blurriness

Fix Photo Thumbnail Blurriness

Signal/src/ViewControllers/ConversationView/Cells/ConversationMediaView.swift

@@ -286,7 +286,7 @@ public class ConversationMediaView: UIView {
                     Logger.warn("Ignoring invalid attachment.")
                     return nil
                 }
-                return attachmentStream.thumbnailImageMedium(success: { (image) in
+                return attachmentStream.thumbnailImageLarge(success: { (image) in
                     AssertIsOnMainThread()
 
                     stillImageView.image = image

Signal/src/ViewControllers/Photos/PhotoCapture.swift

@@ -395,7 +395,7 @@ extension PhotoCapture: CaptureOutputDelegate {
 
         let dataSource = DataSourceValue.dataSource(with: photoData, utiType: kUTTypeJPEG as String)
 
-        let attachment = SignalAttachment.attachment(dataSource: dataSource, dataUTI: kUTTypeJPEG as String, imageQuality: .medium)
+        let attachment = SignalAttachment.attachment(dataSource: dataSource, dataUTI: kUTTypeJPEG as String, imageQuality: .original)
         delegate?.photoCapture(self, didFinishProcessingAttachment: attachment)
     }
 

Signal/src/ViewControllers/Photos/PhotoLibrary.swift

@@ -206,7 +206,7 @@ class PhotoCollectionContents {
         switch asset.mediaType {
         case .image:
             return requestImageDataSource(for: asset).map { (dataSource: DataSource, dataUTI: String) in
-                return SignalAttachment.attachment(dataSource: dataSource, dataUTI: dataUTI, imageQuality: .medium)
+                return SignalAttachment.attachment(dataSource: dataSource, dataUTI: dataUTI, imageQuality: .original)
             }
         case .video:
             return requestVideoDataSource(for: asset).map { (dataSource: DataSource, dataUTI: String) in

SignalMessaging/attachments/SignalAttachment.swift

@@ -551,7 +551,7 @@ public class SignalAttachment: NSObject {
                 }
                 let dataSource = DataSourceValue.dataSource(with: data, utiType: dataUTI)
                 // Pasted images _SHOULD _NOT_ be resized, if possible.
-                return attachment(dataSource: dataSource, dataUTI: dataUTI, imageQuality: .medium)
+                return attachment(dataSource: dataSource, dataUTI: dataUTI, imageQuality: .original)
             }
         }
         for dataUTI in videoUTISet {
@@ -670,7 +670,7 @@ public class SignalAttachment: NSObject {
             }
 
             if isValidOutput {
-                Logger.verbose("Rewriting attachment with metadata removed \(attachment.mimeType)")
+                Logger.verbose(" \(attachment.mimeType)")
                 return removeImageMetadata(attachment: attachment)
             } else {
                 Logger.verbose("Compressing attachment as image/jpeg, \(dataSource.dataLength()) bytes")

SignalShareExtension/ShareViewController.swift

@@ -954,7 +954,7 @@ public class ShareViewController: UIViewController, ShareViewDelegate, SAEFailed
             return promise
         }
 
-        let attachment = SignalAttachment.attachment(dataSource: dataSource, dataUTI: specificUTIType, imageQuality: .medium)
+        let attachment = SignalAttachment.attachment(dataSource: dataSource, dataUTI: specificUTIType, imageQuality: .original)
         if loadedItem.isConvertibleToContactShare {
             Logger.info("isConvertibleToContactShare")
             attachment.isConvertibleToContactShare = true