From b9458fffeff5adf3163ae3631fb55adbed739f32 Mon Sep 17 00:00:00 2001 From: Matthew Chen Date: Fri, 2 Mar 2018 10:53:22 -0500 Subject: [PATCH] Respond to CR. --- SignalServiceKit/src/Messages/OWSMessageSender.m | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/SignalServiceKit/src/Messages/OWSMessageSender.m b/SignalServiceKit/src/Messages/OWSMessageSender.m index aa5a36661..498f59549 100644 --- a/SignalServiceKit/src/Messages/OWSMessageSender.m +++ b/SignalServiceKit/src/Messages/OWSMessageSender.m @@ -984,6 +984,16 @@ NSString *const OWSMessageSenderRateLimitedException = @"RateLimitedException"; } if (deviceMessages.count == 0) { + // This might happen: + // + // * The first (after upgrading?) time we send a sync message to our linked devices. + // * After unlinking all linked devices. + // * After trying and failing to link a device. + // + // When we're not sure if we have linked devices, we need to try + // to send self-sync messages even if they have no device messages + // so that we can learn from the service whether or not there are + // linked devices that we don't know about. DDLogWarn(@"%@ Sending a message with no device messages.", self.logTag); }