From 74ccdfdf2ce07cd1d2d60cb0e7c054a90faedfcb Mon Sep 17 00:00:00 2001
From: Michael Kirk <michael.code@endoftheworl.de>
Date: Wed, 7 Mar 2018 15:29:13 -0500
Subject: [PATCH] Fix redundant profile downloads

// FREEBIE
---
 SignalMessaging/profiles/OWSUserProfile.m | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/SignalMessaging/profiles/OWSUserProfile.m b/SignalMessaging/profiles/OWSUserProfile.m
index f1942d087..8870d1705 100644
--- a/SignalMessaging/profiles/OWSUserProfile.m
+++ b/SignalMessaging/profiles/OWSUserProfile.m
@@ -106,18 +106,17 @@ NSString *const kLocalProfileUniqueId = @"kLocalProfileUniqueId";
 {
     @synchronized(self)
     {
-        BOOL didChange;
-        if (_avatarUrlPath == nil && avatarUrlPath == nil) {
-            didChange = NO;
-        } else if (_avatarUrlPath != nil || avatarUrlPath != nil) {
-            didChange = YES;
+        BOOL isEqual;
+        if (avatarUrlPath != nil) {
+            isEqual = [avatarUrlPath isEqual:_avatarUrlPath];
         } else {
-            didChange = [_avatarUrlPath isEqualToString:avatarUrlPath];
+            // are they both nil?
+            isEqual = _avatarUrlPath == nil;
         }
 
         _avatarUrlPath = avatarUrlPath;
 
-        if (didChange) {
+        if (!isEqual) {
             // If the avatarURL changed, the avatarFileName can't be valid.
             // Clear it.
             self.avatarFileName = nil;