improve attachment image quality

Session/Media Viewing & Editing/GIFs/GifPickerViewController.swift

@@ -388,7 +388,7 @@ class GifPickerViewController: OWSViewController, UISearchBarDelegate, UICollect
                 owsFailDebug("couldn't load asset.")
                 return
             }
-            let attachment = SignalAttachment.attachment(dataSource: dataSource, dataUTI: rendition.utiType, imageQuality: .medium)
+            let attachment = SignalAttachment.attachment(dataSource: dataSource, dataUTI: rendition.utiType, imageQuality: .high)
 
             strongSelf.dismiss(animated: true) {
                 // Delegate presents view controllers, so it's important that *this* controller be dismissed before that occurs.

Session/Media Viewing & Editing/PhotoCapture.swift

@@ -396,7 +396,7 @@ extension PhotoCapture: CaptureOutputDelegate {
 
         let dataSource = DataSourceValue.dataSource(with: photoData, utiType: kUTTypeJPEG as String)
 
-        let attachment = SignalAttachment.attachment(dataSource: dataSource, dataUTI: kUTTypeJPEG as String, imageQuality: .medium)
+        let attachment = SignalAttachment.attachment(dataSource: dataSource, dataUTI: kUTTypeJPEG as String, imageQuality: .high)
         delegate?.photoCapture(self, didFinishProcessingAttachment: attachment)
     }
 

Session/Media Viewing & Editing/PhotoLibrary.swift

@@ -207,7 +207,7 @@ class PhotoCollectionContents {
         switch asset.mediaType {
         case .image:
             return requestImageDataSource(for: asset).map { (dataSource: DataSource, dataUTI: String) in
-                return SignalAttachment.attachment(dataSource: dataSource, dataUTI: dataUTI, imageQuality: .medium)
+                return SignalAttachment.attachment(dataSource: dataSource, dataUTI: dataUTI, imageQuality: .high)
             }
         case .video:
             return requestVideoDataSource(for: asset).map { (dataSource: DataSource, dataUTI: String) in

SessionMessagingKit/Sending & Receiving/Attachments/SignalAttachment.swift

@@ -75,6 +75,7 @@ public enum TSImageQualityTier: UInt {
 @objc
 public enum TSImageQuality: UInt {
     case original
+    case high
     case medium
     case compact
 
@@ -82,6 +83,8 @@ public enum TSImageQuality: UInt {
         switch self {
         case .original:
             return .original
+        case .high:
+            return .high
         case .medium:
             return .mediumHigh
         case .compact:

SessionShareExtension/ShareVC.swift

@@ -552,7 +552,7 @@ final class ShareVC : UINavigationController, ShareViewDelegate, AppModeManagerD
             return promise
         }
 
-        let attachment = SignalAttachment.attachment(dataSource: dataSource, dataUTI: specificUTIType, imageQuality: .medium)
+        let attachment = SignalAttachment.attachment(dataSource: dataSource, dataUTI: specificUTIType, imageQuality: .high)
         if loadedItem.isConvertibleToContactShare {
             Logger.info("isConvertibleToContactShare")
             attachment.isConvertibleToContactShare = true

SignalUtilitiesKit/Media Viewing & Editing/Attachment Approval/AttachmentApprovalViewController.swift

@@ -623,7 +623,7 @@ public class AttachmentApprovalViewController: UIPageViewController, UIPageViewC
         }
         dataSource.sourceFilename = filename
 
-        let dstAttachment = SignalAttachment.attachment(dataSource: dataSource, dataUTI: dataUTI, imageQuality: .medium)
+        let dstAttachment = SignalAttachment.attachment(dataSource: dataSource, dataUTI: dataUTI, imageQuality: .high)
         if let attachmentError = dstAttachment.error {
             owsFailDebug("Could not prepare attachment for output: \(attachmentError).")
             return attachmentItem.attachment