diff --git a/SignalServiceKit/src/Loki/Messaging/LKAddressMessage.m b/SignalServiceKit/src/Loki/Messaging/LKAddressMessage.m index e59516213..89ddd8a58 100644 --- a/SignalServiceKit/src/Loki/Messaging/LKAddressMessage.m +++ b/SignalServiceKit/src/Loki/Messaging/LKAddressMessage.m @@ -34,7 +34,7 @@ [addressMessageBuilder setPtpPort:portAsUInt32]; NSError *error; SSKProtoLokiAddressMessage *addressMessage = [addressMessageBuilder buildAndReturnError:&error]; - if (error || !addressMessage) { + if (error || addressMessage == nil) { OWSFailDebug(@"Failed to build Loki address message for: %@ due to error: %@.", recipient.recipientId, error); return nil; } else { diff --git a/SignalServiceKit/src/Loki/Messaging/LKDeviceLinkMessage.m b/SignalServiceKit/src/Loki/Messaging/LKDeviceLinkMessage.m index 6b72f94ae..8610d3b5a 100644 --- a/SignalServiceKit/src/Loki/Messaging/LKDeviceLinkMessage.m +++ b/SignalServiceKit/src/Loki/Messaging/LKDeviceLinkMessage.m @@ -33,22 +33,18 @@ #pragma mark Building - (SSKProtoContentBuilder *)prepareCustomContentBuilder:(SignalRecipient *)recipient { SSKProtoContentBuilder *contentBuilder = SSKProtoContent.builder; - // If this is a request then we should attach a pre key bundle - if (self.kind == LKDeviceLinkMessageKindRequest) { - PreKeyBundle *bundle = [OWSPrimaryStorage.sharedManager generatePreKeyBundleForContact:recipient.recipientId]; - SSKProtoPrekeyBundleMessageBuilder *preKeyBuilder = [SSKProtoPrekeyBundleMessage builderFromPreKeyBundle:bundle]; - // Build the pre key bundle message - NSError *error; - SSKProtoPrekeyBundleMessage *message = [preKeyBuilder buildAndReturnError:&error]; - if (error || !message) { - OWSFailDebug(@"Failed to build pre key bundle for: %@ due to error: %@.", recipient.recipientId, error); - return nil; - } else { - [contentBuilder setPrekeyBundleMessage:message]; - } + NSError *error; + // Build the pre key bundle message + PreKeyBundle *preKeyBundle = [OWSPrimaryStorage.sharedManager generatePreKeyBundleForContact:recipient.recipientId]; + SSKProtoPrekeyBundleMessageBuilder *preKeyBundleMessageBuilder = [SSKProtoPrekeyBundleMessage builderFromPreKeyBundle:preKeyBundle]; + SSKProtoPrekeyBundleMessage *preKeyBundleMessage = [preKeyBundleMessageBuilder buildAndReturnError:&error]; + if (error || preKeyBundleMessage == nil) { + OWSFailDebug(@"Failed to build pre key bundle message for: %@ due to error: %@.", recipient.recipientId, error); + return nil; + } else { + [contentBuilder setPrekeyBundleMessage:preKeyBundleMessage]; } // Build the device link message - NSError *error; SSKProtoLokiDeviceLinkMessageBuilder *deviceLinkMessageBuilder = [SSKProtoLokiDeviceLinkMessage builder]; [deviceLinkMessageBuilder setMasterHexEncodedPublicKey:self.masterHexEncodedPublicKey]; [deviceLinkMessageBuilder setSlaveHexEncodedPublicKey:self.slaveHexEncodedPublicKey]; diff --git a/SignalServiceKit/src/Loki/Messaging/LKFriendRequestMessage.m b/SignalServiceKit/src/Loki/Messaging/LKFriendRequestMessage.m index aa24bac71..de9b7830b 100644 --- a/SignalServiceKit/src/Loki/Messaging/LKFriendRequestMessage.m +++ b/SignalServiceKit/src/Loki/Messaging/LKFriendRequestMessage.m @@ -9,15 +9,15 @@ #pragma mark Initialization - (SSKProtoContentBuilder *)prepareCustomContentBuilder:(SignalRecipient *)recipient { SSKProtoContentBuilder *contentBuilder = SSKProtoContent.builder; - PreKeyBundle *bundle = [OWSPrimaryStorage.sharedManager generatePreKeyBundleForContact:recipient.recipientId]; - SSKProtoPrekeyBundleMessageBuilder *preKeyBuilder = [SSKProtoPrekeyBundleMessage builderFromPreKeyBundle:bundle]; + PreKeyBundle *preKeyBundle = [OWSPrimaryStorage.sharedManager generatePreKeyBundleForContact:recipient.recipientId]; + SSKProtoPrekeyBundleMessageBuilder *preKeyBundleMessageBuilder = [SSKProtoPrekeyBundleMessage builderFromPreKeyBundle:preKeyBundle]; NSError *error; - SSKProtoPrekeyBundleMessage *_Nullable message = [preKeyBuilder buildAndReturnError:&error]; - if (error || !message) { - OWSFailDebug(@"Failed to build pre key bundle for: %@ due to error: %@.", recipient.recipientId, error); + SSKProtoPrekeyBundleMessage *preKeyBundleMessage = [preKeyBundleMessageBuilder buildAndReturnError:&error]; + if (error || preKeyBundleMessage == nil) { + OWSFailDebug(@"Failed to build pre key bundle message for: %@ due to error: %@.", recipient.recipientId, error); return nil; } else { - [contentBuilder setPrekeyBundleMessage:message]; + [contentBuilder setPrekeyBundleMessage:preKeyBundleMessage]; } return contentBuilder; }