Merge pull request #364 from mpretty-cyro/feature/tweak-notification-handling

Allow notifications from non-default namespaces, handle empty data
pull/1061/head
Morgan Pretty 3 months ago committed by GitHub
commit a13f5ae253
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -440,17 +440,11 @@ public enum PushNotificationAPI {
return (nil, notification.info, .successTooLong)
}
// Only show notifcations for messages from default namespace
// TODO: Add group messages namespace
guard notification.info.namespace == .default else {
SNLog("Ignoring notification due to namespace being \(notification.info.namespace) instead of default")
return (nil, notification.info, .failureNoContent)
}
// Check that the body we were given is valid
// Check that the body we were given is valid and not empty
guard
let notificationData: Data = notification.data,
notification.info.dataLength == notificationData.count
notification.info.dataLength == notificationData.count,
!notificationData.isEmpty
else {
SNLog("Get notification data failed")
return (nil, notification.info, .failureNoContent)

Loading…
Cancel
Save