From 6abc4bed9000496b42153db82e4317a1ab0b20b2 Mon Sep 17 00:00:00 2001
From: Matthew Chen <charlesmchen@gmail.com>
Date: Fri, 29 Sep 2017 14:23:09 -0400
Subject: [PATCH] Increase hot area of scroll down button.

// FREEBIE
---
 .../ConversationViewController.m              | 57 ++++++++++---------
 1 file changed, 31 insertions(+), 26 deletions(-)

diff --git a/Signal/src/ViewControllers/ConversationView/ConversationViewController.m b/Signal/src/ViewControllers/ConversationView/ConversationViewController.m
index 8233fb616..43e0ff6ee 100644
--- a/Signal/src/ViewControllers/ConversationView/ConversationViewController.m
+++ b/Signal/src/ViewControllers/ConversationView/ConversationViewController.m
@@ -3094,32 +3094,40 @@ typedef NS_ENUM(NSInteger, MessagesRangeSizeMode) {
 
 - (void)createScrollDownButton
 {
-    const CGFloat kScrollDownButtonSize = ScaleFromIPhone5To7Plus(35.f, 40.f);
+    const CGFloat kCircleSize = ScaleFromIPhone5To7Plus(35.f, 40.f);
+
+    UILabel *iconLabel = [UILabel new];
+    iconLabel.attributedText =
+        [[NSAttributedString alloc] initWithString:@"\uf103"
+                                        attributes:@{
+                                            NSFontAttributeName : [UIFont ows_fontAwesomeFont:kCircleSize * 0.8f],
+                                            NSForegroundColorAttributeName : [UIColor ows_materialBlueColor],
+                                            NSBaselineOffsetAttributeName : @(-0.5f),
+                                        }];
+
+    UIView *circleView = [UIView new];
+    circleView.backgroundColor = [UIColor colorWithWhite:0.95f alpha:1.f];
+    circleView.layer.cornerRadius = kCircleSize * 0.5f;
+    circleView.layer.shadowColor = [UIColor colorWithWhite:0.5f alpha:1.f].CGColor;
+    circleView.layer.shadowOffset = CGSizeMake(+1.f, +2.f);
+    circleView.layer.shadowRadius = 1.5f;
+    circleView.layer.shadowOpacity = 0.35f;
+    [circleView autoSetDimension:ALDimensionWidth toSize:kCircleSize];
+    [circleView autoSetDimension:ALDimensionHeight toSize:kCircleSize];
+
+    const CGFloat kButtonSize = kCircleSize + 15.f;
     UIButton *scrollDownButton = [UIButton buttonWithType:UIButtonTypeCustom];
     self.scrollDownButton = scrollDownButton;
-    scrollDownButton.backgroundColor = [UIColor colorWithWhite:0.95f alpha:1.f];
-    scrollDownButton.frame = CGRectMake(0, 0, kScrollDownButtonSize, kScrollDownButtonSize);
-    scrollDownButton.layer.cornerRadius = kScrollDownButtonSize * 0.5f;
-    scrollDownButton.layer.shadowColor = [UIColor colorWithWhite:0.5f alpha:1.f].CGColor;
-    scrollDownButton.layer.shadowOffset = CGSizeMake(+1.f, +2.f);
-    scrollDownButton.layer.shadowRadius = 1.5f;
-    scrollDownButton.layer.shadowOpacity = 0.35f;
     [scrollDownButton addTarget:self
                          action:@selector(scrollDownButtonTapped)
                forControlEvents:UIControlEventTouchUpInside];
+    scrollDownButton.frame = CGRectMake(0, 0, kButtonSize, kButtonSize);
     [self.view addSubview:self.scrollDownButton];
 
-    NSAttributedString *labelString = [[NSAttributedString alloc]
-        initWithString:@"\uf103"
-            attributes:@{
-                NSFontAttributeName : [UIFont ows_fontAwesomeFont:kScrollDownButtonSize * 0.8f],
-                NSForegroundColorAttributeName : [UIColor ows_materialBlueColor],
-                NSBaselineOffsetAttributeName : @(-0.5f),
-            }];
-    [scrollDownButton setAttributedTitle:labelString forState:UIControlStateNormal];
-    [scrollDownButton setTitleColor:[UIColor ows_materialBlueColor] forState:UIControlStateNormal];
-    scrollDownButton.contentHorizontalAlignment = UIControlContentHorizontalAlignmentCenter;
-    scrollDownButton.contentVerticalAlignment = UIControlContentVerticalAlignmentCenter;
+    [scrollDownButton addSubview:circleView];
+    [scrollDownButton addSubview:iconLabel];
+    [circleView autoCenterInSuperview];
+    [iconLabel autoCenterInSuperview];
 
     [self updateLastVisibleTimestamp];
 }
@@ -3158,13 +3166,10 @@ typedef NS_ENUM(NSInteger, MessagesRangeSizeMode) {
     if (shouldShowScrollDownButton) {
         self.scrollDownButton.hidden = NO;
 
-        const CGFloat kHMargin = 15.f;
-        const CGFloat kVMargin = 15.f;
-        self.scrollDownButton.frame
-            = CGRectMake(self.scrollDownButton.superview.width - (self.scrollDownButton.width + kHMargin),
-                self.inputToolbar.top - (self.scrollDownButton.height + kVMargin),
-                self.scrollDownButton.width,
-                self.scrollDownButton.height);
+        self.scrollDownButton.frame = CGRectMake(self.scrollDownButton.superview.width - self.scrollDownButton.width,
+            self.inputToolbar.top - self.scrollDownButton.height,
+            self.scrollDownButton.width,
+            self.scrollDownButton.height);
     } else {
         self.scrollDownButton.hidden = YES;
     }