Merge pull request #537 from RyanRory/open-group-spam-prevention

Do not show user details to prevent spam

Session/Conversations/Context Menu/ContextMenuVC+Action.swift

@@ -56,7 +56,9 @@ extension ContextMenuVC {
             if isReplyingAllowed() { result.append(Action.reply(viewItem, delegate)) }
             result.append(Action.copy(viewItem, delegate))
             let isGroup = viewItem.isGroupThread
-            if isGroup && viewItem.interaction is TSIncomingMessage { result.append(Action.copySessionID(viewItem, delegate)) }
+            if let message = viewItem.interaction as? TSIncomingMessage, isGroup, !message.isOpenGroupMessage {
+                result.append(Action.copySessionID(viewItem, delegate))
+            }
             if !isGroup || viewItem.userCanDeleteGroupMessage { result.append(Action.delete(viewItem, delegate)) }
             if isGroup && viewItem.interaction is TSIncomingMessage && viewItem.userHasModerationPermission {
                 result.append(Action.ban(viewItem, delegate))
@@ -69,7 +71,9 @@ extension ContextMenuVC {
             if viewItem.canCopyMedia() { result.append(Action.copy(viewItem, delegate)) }
             if viewItem.canSaveMedia() { result.append(Action.save(viewItem, delegate)) }
             let isGroup = viewItem.isGroupThread
-            if isGroup && viewItem.interaction is TSIncomingMessage { result.append(Action.copySessionID(viewItem, delegate)) }
+            if let message = viewItem.interaction as? TSIncomingMessage, isGroup, !message.isOpenGroupMessage {
+                result.append(Action.copySessionID(viewItem, delegate))
+            }
             if !isGroup || viewItem.userCanDeleteGroupMessage { result.append(Action.delete(viewItem, delegate)) }
             if isGroup && viewItem.interaction is TSIncomingMessage && viewItem.userHasModerationPermission {
                 result.append(Action.ban(viewItem, delegate))

Session/Conversations/Message Cells/VisibleMessageCell.swift

@@ -483,6 +483,7 @@ final class VisibleMessageCell : MessageCell, LinkPreviewViewDelegate {
         let location = gestureRecognizer.location(in: self)
         if profilePictureView.frame.contains(location) && VisibleMessageCell.shouldShowProfilePicture(for: viewItem) {
             guard let message = viewItem.interaction as? TSIncomingMessage else { return }
+            guard !message.isOpenGroupMessage else { return } // Do not show user details to prevent spam
             delegate?.showUserDetails(for: message.authorId)
         } else if replyButton.frame.contains(location) {
             UIImpactFeedbackGenerator(style: .heavy).impactOccurred()