From 74ca54d78e4af5a1bc0c156309bcb5577a0da7d9 Mon Sep 17 00:00:00 2001 From: Matthew Chen Date: Mon, 9 Jan 2017 14:50:37 -0500 Subject: [PATCH 1/2] Improve instructions on how to build WebRTC. // FREEBIE --- MAINTAINING.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/MAINTAINING.md b/MAINTAINING.md index b02478774..01590e398 100644 --- a/MAINTAINING.md +++ b/MAINTAINING.md @@ -25,6 +25,23 @@ Once you have your build environment set up and the WebRTC source downloaded: # Put it in our frameworks search path mv src/webrtc/ios_libs_out/WebRTC.framework ../Signal-iOS/Carthage/Builds + # The specific set of commands that worked for me were somewhat different. + # 1. Install depot tools + cd + export PATH=/depot_tools:"$PATH" + # 2. Fetch webrtc source + cd + mkdir webrtc + cd webrtc + fetch --nohooks webrtc_ios + gclient sync + # 3. Build webrtc + # NOTE: build_ios_libs.sh only worked for me from inside "src" + cd src + webrtc/build/ios/build_ios_libs.sh + # NOTE: It's Carthage/Build/iOS, not Carthage/Builds + mv out_ios_libs/WebRTC.framework ../../Signal-iOS/Carthage/Build/iOS/ + ## Translations Read more about translations in [TRANSLATIONS.md](signal/translations/TRANSLATIONS.md) From 692429480b40fdaae7b92d1ed8beb3be176cd866 Mon Sep 17 00:00:00 2001 From: Matthew Chen Date: Tue, 10 Jan 2017 16:20:15 -0500 Subject: [PATCH 2/2] Respond to CR. // FREEBIE --- MAINTAINING.md | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/MAINTAINING.md b/MAINTAINING.md index 01590e398..9a98e31c1 100644 --- a/MAINTAINING.md +++ b/MAINTAINING.md @@ -19,18 +19,14 @@ https://webrtc.org/native-code/ios/ Once you have your build environment set up and the WebRTC source downloaded: - cd webrtc - # build a fat framework - src/webrtc/build/ios/build_ios_libs.sh - # Put it in our frameworks search path - mv src/webrtc/ios_libs_out/WebRTC.framework ../Signal-iOS/Carthage/Builds - # The specific set of commands that worked for me were somewhat different. # 1. Install depot tools cd + git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git + cd depot_tools export PATH=/depot_tools:"$PATH" # 2. Fetch webrtc source - cd + cd mkdir webrtc cd webrtc fetch --nohooks webrtc_ios