From c37f425d5f2e31ba6acef46ff4c4e7628e480a92 Mon Sep 17 00:00:00 2001 From: Matthew Chen Date: Fri, 15 Mar 2019 16:27:08 -0400 Subject: [PATCH] Reduce logging. --- .../ConversationView/ConversationViewLayout.m | 3 --- .../DisappearingTimerConfigurationView.swift | 20 +------------------ .../src/Messages/UD/OWSUDManager.swift | 2 +- .../src/Network/API/TSNetworkManager.m | 2 -- SignalServiceKit/src/Util/DataSource.m | 3 +-- 5 files changed, 3 insertions(+), 27 deletions(-) diff --git a/Signal/src/ViewControllers/ConversationView/ConversationViewLayout.m b/Signal/src/ViewControllers/ConversationView/ConversationViewLayout.m index ddfb470e8..96e51af42 100644 --- a/Signal/src/ViewControllers/ConversationView/ConversationViewLayout.m +++ b/Signal/src/ViewControllers/ConversationView/ConversationViewLayout.m @@ -92,9 +92,6 @@ NS_ASSUME_NONNULL_BEGIN } self.hasLayout = YES; - // TODO: Remove this log statement after we've reduced the invalidation churn. - OWSLogVerbose(@"prepareLayout"); - [self prepareLayoutOfItems]; } diff --git a/SignalMessaging/Views/DisappearingTimerConfigurationView.swift b/SignalMessaging/Views/DisappearingTimerConfigurationView.swift index c74310fd8..ec5f9d86d 100644 --- a/SignalMessaging/Views/DisappearingTimerConfigurationView.swift +++ b/SignalMessaging/Views/DisappearingTimerConfigurationView.swift @@ -1,5 +1,5 @@ // -// Copyright (c) 2018 Open Whisper Systems. All rights reserved. +// Copyright (c) 2019 Open Whisper Systems. All rights reserved. // import Foundation @@ -26,24 +26,6 @@ public class DisappearingTimerConfigurationView: UIView { } } - override public var frame: CGRect { - didSet { - Logger.verbose("\(oldValue) -> \(frame)") - } - } - - override public var bounds: CGRect { - didSet { - Logger.verbose("\(oldValue) -> \(bounds)") - } - } - - override public func layoutSubviews() { - let oldFrame = self.frame - super.layoutSubviews() - Logger.verbose("Frame: \(oldFrame) -> \(self.frame)") - } - private let imageView: UIImageView private let label: UILabel private var pressGesture: UILongPressGestureRecognizer! diff --git a/SignalServiceKit/src/Messages/UD/OWSUDManager.swift b/SignalServiceKit/src/Messages/UD/OWSUDManager.swift index f0c4005de..3c1de038f 100644 --- a/SignalServiceKit/src/Messages/UD/OWSUDManager.swift +++ b/SignalServiceKit/src/Messages/UD/OWSUDManager.swift @@ -180,7 +180,7 @@ public class OWSUDManagerImpl: NSObject, OWSUDManager { @objc public func isUDVerboseLoggingEnabled() -> Bool { - return true + return false } // MARK: - Dependencies diff --git a/SignalServiceKit/src/Network/API/TSNetworkManager.m b/SignalServiceKit/src/Network/API/TSNetworkManager.m index bb0d4af62..eb69e8be0 100644 --- a/SignalServiceKit/src/Network/API/TSNetworkManager.m +++ b/SignalServiceKit/src/Network/API/TSNetworkManager.m @@ -182,10 +182,8 @@ dispatch_queue_t NetworkManagerQueue() OWSSessionManager *_Nullable sessionManager = [self.pool lastObject]; if (sessionManager) { - OWSLogVerbose(@"Cache hit."); [self.pool removeLastObject]; } else { - OWSLogVerbose(@"Cache miss."); sessionManager = [OWSSessionManager new]; } OWSAssertDebug(sessionManager); diff --git a/SignalServiceKit/src/Util/DataSource.m b/SignalServiceKit/src/Util/DataSource.m index 4c46e84ed..468a21b20 100755 --- a/SignalServiceKit/src/Util/DataSource.m +++ b/SignalServiceKit/src/Util/DataSource.m @@ -1,5 +1,5 @@ // -// Copyright (c) 2018 Open Whisper Systems. All rights reserved. +// Copyright (c) 2019 Open Whisper Systems. All rights reserved. // #import "DataSource.h" @@ -323,7 +323,6 @@ NS_ASSUME_NONNULL_BEGIN @synchronized(self) { if (!self.cachedData) { - OWSLogError(@"---- reading data"); self.cachedData = [NSData dataWithContentsOfFile:self.filePath]; } if (!self.cachedData) {