From b946badd97ab58e9df9adefc51faa9a80bdf9bf0 Mon Sep 17 00:00:00 2001 From: Matthew Chen Date: Thu, 22 Jun 2017 10:10:30 -0400 Subject: [PATCH 1/2] [SSK] Reduce chattiness of logs; increase log file sizes. // FREEBIE --- src/Messages/Interactions/TSErrorMessage.m | 2 +- src/Messages/Interactions/TSIncomingMessage.m | 2 +- src/Messages/Interactions/TSInfoMessage.m | 2 +- src/Messages/TSCall.m | 2 +- src/Network/WebSockets/TSSocketManager.m | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Messages/Interactions/TSErrorMessage.m b/src/Messages/Interactions/TSErrorMessage.m index 07e181b69..a50327e40 100644 --- a/src/Messages/Interactions/TSErrorMessage.m +++ b/src/Messages/Interactions/TSErrorMessage.m @@ -180,7 +180,7 @@ NSUInteger TSErrorMessageSchemaVersion = 1; return; } - DDLogInfo(@"%@ marking as read uniqueId: %@ which has timestamp: %llu", self.tag, self.uniqueId, self.timestamp); + DDLogDebug(@"%@ marking as read uniqueId: %@ which has timestamp: %llu", self.tag, self.uniqueId, self.timestamp); _read = YES; [self saveWithTransaction:transaction]; [self touchThreadWithTransaction:transaction]; diff --git a/src/Messages/Interactions/TSIncomingMessage.m b/src/Messages/Interactions/TSIncomingMessage.m index dddbacef9..eb3f2d2c4 100644 --- a/src/Messages/Interactions/TSIncomingMessage.m +++ b/src/Messages/Interactions/TSIncomingMessage.m @@ -127,7 +127,7 @@ NSString *const TSIncomingMessageWasReadOnThisDeviceNotification = @"TSIncomingM return; } - DDLogInfo(@"%@ marking as read uniqueId: %@ which has timestamp: %llu", self.tag, self.uniqueId, self.timestamp); + DDLogDebug(@"%@ marking as read uniqueId: %@ which has timestamp: %llu", self.tag, self.uniqueId, self.timestamp); _read = YES; [self saveWithTransaction:transaction]; [self touchThreadWithTransaction:transaction]; diff --git a/src/Messages/Interactions/TSInfoMessage.m b/src/Messages/Interactions/TSInfoMessage.m index 7ae9afa04..d8ae95306 100644 --- a/src/Messages/Interactions/TSInfoMessage.m +++ b/src/Messages/Interactions/TSInfoMessage.m @@ -119,7 +119,7 @@ NSUInteger TSInfoMessageSchemaVersion = 1; return; } - DDLogInfo(@"%@ marking as read uniqueId: %@ which has timestamp: %llu", self.tag, self.uniqueId, self.timestamp); + DDLogDebug(@"%@ marking as read uniqueId: %@ which has timestamp: %llu", self.tag, self.uniqueId, self.timestamp); _read = YES; [self saveWithTransaction:transaction]; [self touchThreadWithTransaction:transaction]; diff --git a/src/Messages/TSCall.m b/src/Messages/TSCall.m index 7f4e63eef..ff517fe69 100644 --- a/src/Messages/TSCall.m +++ b/src/Messages/TSCall.m @@ -96,7 +96,7 @@ NSUInteger TSCallCurrentSchemaVersion = 1; return; } - DDLogInfo(@"%@ marking as read uniqueId: %@ which has timestamp: %llu", self.tag, self.uniqueId, self.timestamp); + DDLogDebug(@"%@ marking as read uniqueId: %@ which has timestamp: %llu", self.tag, self.uniqueId, self.timestamp); _read = YES; [self saveWithTransaction:transaction]; [self touchThreadWithTransaction:transaction]; diff --git a/src/Network/WebSockets/TSSocketManager.m b/src/Network/WebSockets/TSSocketManager.m index 2c6c7a9e2..27ba199ff 100644 --- a/src/Network/WebSockets/TSSocketManager.m +++ b/src/Network/WebSockets/TSSocketManager.m @@ -234,7 +234,7 @@ NSString *const kNSNotification_SocketManagerStateDidChange = @"kNSNotification_ return; } - DDLogWarn(@"%@ Socket state change: %@ -> %@", + DDLogWarn(@"%@ Socket state: %@ -> %@", self.tag, [self stringFromSocketManagerState:_state], [self stringFromSocketManagerState:state]); From ed369436fbf7bbdda1b5c5a3c3a6d70b38486db0 Mon Sep 17 00:00:00 2001 From: Matthew Chen Date: Thu, 22 Jun 2017 13:24:53 -0400 Subject: [PATCH 2/2] Reduce chattiness of logs; increase log file sizes. // FREEBIE --- src/Contacts/TSThread.m | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/Contacts/TSThread.m b/src/Contacts/TSThread.m index 7adb7d197..8715f8f0a 100644 --- a/src/Contacts/TSThread.m +++ b/src/Contacts/TSThread.m @@ -289,7 +289,6 @@ NS_ASSUME_NONNULL_BEGIN OWSAssert(interaction); if (interaction.isDynamicInteraction) { - DDLogDebug(@"%@ not showing dynamic interaction in inbox: %@", self.tag, interaction.debugDescription); return NO; } @@ -298,15 +297,11 @@ NS_ASSUME_NONNULL_BEGIN if (errorMessage.errorType == TSErrorMessageNonBlockingIdentityChange) { // Otherwise all group threads with the recipient will percolate to the top of the inbox, even though // there was no meaningful interaction. - DDLogDebug( - @"%@ not showing nonblocking identity change in inbox: %@", self.tag, errorMessage.debugDescription); return NO; } } else if ([interaction isKindOfClass:[TSInfoMessage class]]) { TSInfoMessage *infoMessage = (TSInfoMessage *)interaction; if (infoMessage.messageType == TSInfoMessageVerificationStateChange) { - DDLogDebug( - @"%@ not showing verification state change in inbox: %@", self.tag, infoMessage.debugDescription); return NO; } }