Merge branch 'mkirk/update-ui-db-to-latest' into release/2.26.0

Signal/src/ViewControllers/ConversationView/ConversationViewController.m

@@ -435,12 +435,11 @@ typedef enum : NSUInteger {
     // Cache the cell media for ~24 cells.
     self.cellMediaCache.countLimit = 24;
 
-    [self.uiDatabaseConnection beginLongLivedReadTransaction];
-
     // We need to update the "unread indicator" _before_ we determine the initial range
     // size, since it depends on where the unread indicator is placed.
     self.lastRangeLength = 0;
     [self ensureDynamicInteractions];
+    [[OWSPrimaryStorage sharedManager] updateUIDatabaseConnectionToLatest];
 
     if (thread.uniqueId.length > 0) {
         self.messageMappings = [[YapDatabaseViewMappings alloc] initWithGroups:@[ thread.uniqueId ]

SignalServiceKit/src/Storage/OWSPrimaryStorage.h

@@ -22,6 +22,8 @@ extern NSString *const OWSUIDatabaseConnectionNotificationsKey;
 @property (nonatomic, readonly) YapDatabaseConnection *dbReadConnection;
 @property (nonatomic, readonly) YapDatabaseConnection *dbReadWriteConnection;
 
+- (void)updateUIDatabaseConnectionToLatest;
+
 + (YapDatabaseConnection *)dbReadConnection;
 + (YapDatabaseConnection *)dbReadWriteConnection;
 

SignalServiceKit/src/Storage/OWSPrimaryStorage.m

@@ -168,10 +168,15 @@ void VerifyRegistrationsForPrimaryStorage(OWSStorage *storage)
     OWSAssertIsOnMainThread();
     
     DDLogVerbose(@"%@ %s", self.logTag, __PRETTY_FUNCTION__);
-    
+    [self updateUIDatabaseConnectionToLatest];
+}
+
+- (void)updateUIDatabaseConnectionToLatest
+{
+
     // Notify observers we're about to update the database connection
     [[NSNotificationCenter defaultCenter] postNotificationName:OWSUIDatabaseConnectionWillUpdateNotification object:self.dbNotificationObject];
-        
+
     // Move uiDatabaseConnection to the latest commit.
     // Do so atomically, and fetch all the notifications for each commit we jump.
     NSArray *notifications = [self.uiDatabaseConnection beginLongLivedReadTransaction];
@@ -182,7 +187,7 @@ void VerifyRegistrationsForPrimaryStorage(OWSStorage *storage)
                                                         object:self.dbNotificationObject
                                                       userInfo:userInfo];
 }
-     
+
 - (YapDatabaseConnection *)uiDatabaseConnection
 {
     OWSAssertIsOnMainThread();