From 729769afa7bc2fb1611320c6ebed42e40ba003ac Mon Sep 17 00:00:00 2001 From: Matthew Chen Date: Mon, 21 May 2018 11:01:25 -0400 Subject: [PATCH] PeerConnectionClient thread safety. --- Signal/src/call/PeerConnectionClient.swift | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Signal/src/call/PeerConnectionClient.swift b/Signal/src/call/PeerConnectionClient.swift index 26cd26163..d424eb51a 100644 --- a/Signal/src/call/PeerConnectionClient.swift +++ b/Signal/src/call/PeerConnectionClient.swift @@ -346,7 +346,6 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD return RTCMediaConstraints(mandatoryConstraints: mandatoryConstraints, optionalConstraints: nil) } - // TODO: Review all self.peerConnection // TODO: Review all .async // TODO: Review all error == nil public func createOffer() -> Promise { @@ -416,7 +415,6 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD } } - // TODO: Review all self. public func setLocalSessionDescription(_ sessionDescription: HardenedRTCSessionDescription) -> Promise { SwiftAssertIsOnMainThread(#function) @@ -703,8 +701,6 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD Logger.debug("\(logTag) didChange signalingState:\(stateChanged.debugDescription)") } - // TODO: Review all peerConnection params - // TODO: There's work being done here on the wrong queue. /** Called when media is received on a new stream from remote peer. */ internal func peerConnection(_ peerConnectionParam: RTCPeerConnection, didAdd stream: RTCMediaStream) {