fix an issue there attachment error modal won't show up

Session/Conversations/ConversationVC+Interaction.swift

@@ -358,8 +358,8 @@ extension ConversationVC:
                 let modal: ConfirmationModal = ConfirmationModal(
                     targetView: self?.view,
                     info: ConfirmationModal.Info(
-                        title: "attachmentsErrorNotSupported".localized(),
-                        body: .text("attachmentsErrorSize".localized()),
+                        title: "attachmentsErrorLoad".localized(),
+                        body: .text("attachmentsErrorNotSupported".localized()),
                         cancelTitle: "okay".localized(),
                         cancelStyle: .alert_text
                     )
@@ -2564,16 +2564,18 @@ extension ConversationVC:
     // MARK: - Convenience
     
     func showErrorAlert(for attachment: SignalAttachment) {
-        let modal: ConfirmationModal = ConfirmationModal(
-            targetView: self.view,
-            info: ConfirmationModal.Info(
-                title: "attachmentsErrorSending".localized(),
-                body: .text(attachment.localizedErrorDescription ?? SignalAttachment.missingDataErrorMessage),
-                cancelTitle: "okay".localized(),
-                cancelStyle: .alert_text
+        DispatchQueue.main.async { [weak self] in
+            let modal: ConfirmationModal = ConfirmationModal(
+                targetView: self?.view,
+                info: ConfirmationModal.Info(
+                    title: "attachmentsErrorSending".localized(),
+                    body: .text(attachment.localizedErrorDescription ?? SignalAttachment.missingDataErrorMessage),
+                    cancelTitle: "okay".localized(),
+                    cancelStyle: .alert_text
+                )
             )
-        )
-        self.present(modal, animated: true)
+            self?.present(modal, animated: true)
+        }
     }
 }
 

Session/Media Viewing & Editing/SendMediaNavigationController.swift

@@ -293,8 +293,8 @@ extension SendMediaNavigationController: PhotoCaptureViewControllerDelegate {
             if !pushApprovalViewController() {
                 let modal: ConfirmationModal = ConfirmationModal(
                     info: ConfirmationModal.Info(
-                        title: "IMAGE_PICKER_FAILED_TO_PROCESS_ATTACHMENTS".localized(),
-                        cancelTitle: "BUTTON_OK".localized(),
+                        title: "attachmentsErrorMediaSelection".localized(),
+                        cancelTitle: "okay".localized(),
                         cancelStyle: .alert_text
                     )
                 )

SessionMessagingKit/Sending & Receiving/Attachments/SignalAttachment.swift

@@ -40,14 +40,14 @@ extension String {
 extension SignalAttachmentError: LocalizedError {
     public var errorDescription: String? {
         switch self {
-        case .fileSizeTooLarge:
-            return "attachmentsErrorSize".localized()
-        case .invalidData, .missingData, .invalidFileFormat:
-            return "attachmentsErrorNotSupported".localized()
-        case .couldNotConvertToJpeg, .couldNotParseImage, .couldNotConvertToMpeg4, .couldNotResizeImage:
-            return "attachmentsErrorOpen".localized()
-        case .couldNotRemoveMetadata:
-            return "attachmentsImageErrorMetadata".localized()
+            case .fileSizeTooLarge:
+                return "attachmentsErrorSize".localized()
+            case .invalidData, .missingData, .invalidFileFormat:
+                return "attachmentsErrorNotSupported".localized()
+            case .couldNotConvertToJpeg, .couldNotParseImage, .couldNotConvertToMpeg4, .couldNotResizeImage:
+                return "attachmentsErrorOpen".localized()
+            case .couldNotRemoveMetadata:
+                return "attachmentsImageErrorMetadata".localized()
         }
     }
 }