From f37c4f71ad6203bb30c5b1c56e3164f745f8b234 Mon Sep 17 00:00:00 2001 From: Matthew Chen Date: Thu, 8 Nov 2018 11:29:11 -0500 Subject: [PATCH] Add footer to 'typing indicators' setting. --- .../AppSettings/PrivacySettingsTableViewController.m | 3 ++- Signal/translations/en.lproj/Localizable.strings | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Signal/src/ViewControllers/AppSettings/PrivacySettingsTableViewController.m b/Signal/src/ViewControllers/AppSettings/PrivacySettingsTableViewController.m index ab31393cd..cfe95b22b 100644 --- a/Signal/src/ViewControllers/AppSettings/PrivacySettingsTableViewController.m +++ b/Signal/src/ViewControllers/AppSettings/PrivacySettingsTableViewController.m @@ -108,7 +108,8 @@ static NSString *const kSealedSenderInfoURL = @"https://signal.org/blog/sealed-s OWSTableSection *typingIndicatorsSection = [OWSTableSection new]; typingIndicatorsSection.headerTitle = NSLocalizedString(@"SETTINGS_TYPING_INDICATORS", @"Label for the 'typing indicators' setting."); - // TODO: Should we have a footer? + typingIndicatorsSection.footerTitle = NSLocalizedString( + @"SETTINGS_TYPING_INDICATORS_FOOTER", @"An explanation of the 'typing indicators' setting."); [typingIndicatorsSection addItem:[OWSTableItem switchItemWithText:NSLocalizedString(@"SETTINGS_TYPING_INDICATORS", @"Label for the 'typing indicators' setting.") isOn:[self.typingIndicators areTypingIndicatorsEnabled] diff --git a/Signal/translations/en.lproj/Localizable.strings b/Signal/translations/en.lproj/Localizable.strings index cce00c2e8..ad3d5bd83 100644 --- a/Signal/translations/en.lproj/Localizable.strings +++ b/Signal/translations/en.lproj/Localizable.strings @@ -2099,6 +2099,9 @@ /* Label for the 'typing indicators' setting. */ "SETTINGS_TYPING_INDICATORS" = "Typing Indicators"; +/* An explanation of the 'typing indicators' setting. */ +"SETTINGS_TYPING_INDICATORS_FOOTER" = "See and share when messages are being typed. This setting is optional and applies to all conversations."; + /* Label for a link to more info about unidentified delivery. */ "SETTINGS_UNIDENTIFIED_DELIVERY_LEARN_MORE" = "Learn More";