Change to make the 'getUser(using:)' method more consistent

SessionMessagingKit/Database/Storage+Shared.swift

@@ -36,21 +36,17 @@ extension Storage {
     }
 
     @objc public func getUser() -> Contact? {
-        return getUser(using: nil)
-    }
-    
-    public func getUser(using transaction: Any?) -> Contact? {
-        guard let userPublicKey = getUserPublicKey() else { return nil }
         var result: Contact?
         
-        if let transaction = transaction {
-            result = Storage.shared.getContact(with: userPublicKey, using: transaction)
-        }
-        else {
-            Storage.read { transaction in
-                result = Storage.shared.getContact(with: userPublicKey, using: transaction)
-            }
+        Storage.read { transaction in
+            result = self.getUser(using: transaction)
         }
+        
         return result
     }
+    
+    public func getUser(using transaction: Any) -> Contact? {
+        guard let userPublicKey = getUserPublicKey() else { return nil }
+        return Storage.shared.getContact(with: userPublicKey, using: transaction)
+    }
 }

SessionMessagingKit/Storage.swift

@@ -17,7 +17,7 @@ public protocol SessionMessagingKitStorageProtocol {
     func getUserKeyPair() -> ECKeyPair?
     func getUserED25519KeyPair() -> Box.KeyPair?
     func getUser() -> Contact?
-    func getUser(using transaction: Any?) -> Contact?
+    func getUser(using transaction: Any) -> Contact?
     func getAllContacts() -> Set<Contact>
     func getAllContacts(with transaction: YapDatabaseReadTransaction) -> Set<Contact>