From 4d1c38cc457694d73098501bb310593b8513f2b9 Mon Sep 17 00:00:00 2001
From: Matthew Chen <matthew@signal.org>
Date: Thu, 29 Nov 2018 13:10:40 -0500
Subject: [PATCH] Never failover message sends.

---
 SignalServiceKit/src/Messages/OWSMessageSender.m | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/SignalServiceKit/src/Messages/OWSMessageSender.m b/SignalServiceKit/src/Messages/OWSMessageSender.m
index 6c7205249..7c5b6655b 100644
--- a/SignalServiceKit/src/Messages/OWSMessageSender.m
+++ b/SignalServiceKit/src/Messages/OWSMessageSender.m
@@ -1070,15 +1070,6 @@ NSString *const OWSMessageSenderRateLimitedException = @"RateLimitedException";
         OWSLogWarn(@"Sending a message with no device messages.");
     }
 
-    // NOTE: canFailoverUDAuth depends on whether or not we're sending a
-    // sync message because sync messages use different device lists
-    // for UD-auth and Non-UD-auth requests.
-    //
-    // Therefore, for sync messages, we can't use OWSRequestMaker's
-    // retry/failover logic; we need to use the message sender's retry
-    // logic that will build a new set of device messages.
-    BOOL isSyncMessageSend = messageSend.isLocalNumber;
-    BOOL canFailoverUDAuth = !isSyncMessageSend;
     OWSRequestMaker *requestMaker = [[OWSRequestMaker alloc] initWithLabel:@"Message Send"
         requestFactoryBlock:^(SMKUDAccessKey *_Nullable udAccessKey) {
             return [OWSRequestFactory submitMessageRequestWithRecipient:recipient.recipientId
@@ -1098,7 +1089,7 @@ NSString *const OWSMessageSenderRateLimitedException = @"RateLimitedException";
         }
         recipientId:recipient.recipientId
         udAccess:messageSend.udAccess
-        canFailoverUDAuth:canFailoverUDAuth];
+        canFailoverUDAuth:NO];
     [[requestMaker makeRequestObjc]
             .then(^(OWSRequestMakerResult *result) {
                 dispatch_async([OWSDispatch sendingQueue], ^{