From 41aa825e5d7fea52a6ed83fca8158f85f6487709 Mon Sep 17 00:00:00 2001 From: nielsandriesse Date: Fri, 3 Jul 2020 15:15:29 +1000 Subject: [PATCH] Add TODOs --- .../Protocol/Closed Groups/ClosedGroupsProtocol.swift | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/SignalServiceKit/src/Loki/Protocol/Closed Groups/ClosedGroupsProtocol.swift b/SignalServiceKit/src/Loki/Protocol/Closed Groups/ClosedGroupsProtocol.swift index c53ec503a..f37b901d0 100644 --- a/SignalServiceKit/src/Loki/Protocol/Closed Groups/ClosedGroupsProtocol.swift +++ b/SignalServiceKit/src/Loki/Protocol/Closed Groups/ClosedGroupsProtocol.swift @@ -13,6 +13,15 @@ import PromiseKit @objc(LKClosedGroupsProtocol) public final class ClosedGroupsProtocol : NSObject { + // TODO: + // • Always reset all ratchets if someone leaves or is kicked? + // • Validate that update messages come from admins + // • Closed group update message deserialization + // • Include key indexes + // • Multi device + // • ClosedGroupsProtocol + // • SyncMessagesProtocol + /// - Note: It's recommended to batch fetch the device links for the given set of members before invoking this, to avoid /// the message sending pipeline making a request for each member. public static func createClosedGroup(name: String, members membersAsSet: Set, transaction: YapDatabaseReadWriteTransaction) -> TSGroupThread {