From 3ddfd9159756b337a0489830b9697f0af44c6695 Mon Sep 17 00:00:00 2001 From: Gil Azaria Date: Thu, 6 Nov 2014 12:24:33 +1100 Subject: [PATCH] phone/ related bug fixes - Fixed typo with an isKindOfClass comparison - Fixed a bug in PhoneNumberDirectoryFilterManager where if an update failed it didnt save the retry date --- Signal/src/phone/signaling/CallConnectUtil_Responder.m | 2 +- .../number directory/PhoneNumberDirectoryFilterManager.m | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Signal/src/phone/signaling/CallConnectUtil_Responder.m b/Signal/src/phone/signaling/CallConnectUtil_Responder.m index abadc2c37..35571698c 100644 --- a/Signal/src/phone/signaling/CallConnectUtil_Responder.m +++ b/Signal/src/phone/signaling/CallConnectUtil_Responder.m @@ -40,7 +40,7 @@ untilCancelled:[callController untilCancelledToken]]; return [futureSignalConnection thenTry:^id(HttpManager* httpManager) { - require([httpManager isKindOfClass:httpManager.class]); + require([httpManager isKindOfClass:HttpManager.class]); HttpResponse*(^serverRequestHandler)(HttpRequest*) = ^(HttpRequest* remoteRequest) { return [self respondToServerRequest:remoteRequest diff --git a/Signal/src/phone/signaling/number directory/PhoneNumberDirectoryFilterManager.m b/Signal/src/phone/signaling/number directory/PhoneNumberDirectoryFilterManager.m index 30acdaeb3..3bc2fa96a 100644 --- a/Signal/src/phone/signaling/number directory/PhoneNumberDirectoryFilterManager.m +++ b/Signal/src/phone/signaling/number directory/PhoneNumberDirectoryFilterManager.m @@ -81,8 +81,11 @@ BloomFilter* filter = [phoneNumberDirectoryFilter bloomFilter]; NSDate* retryDate = [NSDate dateWithTimeInterval:DIRECTORY_UPDATE_RETRY_PERIOD sinceDate:[NSDate date]]; - [PhoneNumberDirectoryFilter phoneNumberDirectoryFilterWithBloomFilter:filter - andExpirationDate:retryDate]; + @synchronized(self) { + phoneNumberDirectoryFilter = [PhoneNumberDirectoryFilter phoneNumberDirectoryFilterWithBloomFilter:filter + andExpirationDate:retryDate]; + } + [[NSNotificationCenter defaultCenter] postNotificationName:NOTIFICATION_DIRECTORY_FAILED object:nil]; }]; }