From 3d3af2179282d3c9efd2198425c980e90582a787 Mon Sep 17 00:00:00 2001 From: Michael Kirk Date: Thu, 5 Oct 2017 09:21:22 -0400 Subject: [PATCH] CR: clarify comment, proper linewrap // FREEBIE --- Signal/src/call/CallAudioService.swift | 8 +++++--- Signal/src/views/RemoteVideoView.m | 1 + 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Signal/src/call/CallAudioService.swift b/Signal/src/call/CallAudioService.swift index 9a446dbd0..8f38afc40 100644 --- a/Signal/src/call/CallAudioService.swift +++ b/Signal/src/call/CallAudioService.swift @@ -417,10 +417,12 @@ struct AudioSource: Hashable { let session = AVAudioSession.sharedInstance() guard let availableInputs = session.availableInputs else { - // I'm not sure when this would happen. + // I'm not sure why this would happen, but it may indicate an error. + // In practice, I haven't seen it on iOS9+. + // + // I *have* seen it on iOS8, but it doesn't seem to cause any problems, + // so we do *not* trigger the assert on that platform. if #available(iOS 9.0, *) { - // Fails on iOS8. We *could* remove this assert, but it might - // still be helfpul in catching a bug in a more used platform. owsFail("No available inputs or inputs not ready") } return [AudioSource.builtInSpeaker] diff --git a/Signal/src/views/RemoteVideoView.m b/Signal/src/views/RemoteVideoView.m index d6b175651..63a47067b 100644 --- a/Signal/src/views/RemoteVideoView.m +++ b/Signal/src/views/RemoteVideoView.m @@ -41,6 +41,7 @@ NS_ASSUME_NONNULL_BEGIN label.textAlignment = NSTextAlignmentCenter; label.font = [UIFont ows_boldFontWithSize:ScaleFromIPhone5(20)]; label.textColor = UIColor.whiteColor; + label.lineBreakMode = NSLineBreakByWordWrapping; [self addSubview:label]; [label autoVCenterInSuperview];