From 37fdd407d47d19caa15cd4fb7f93a79e07d074f6 Mon Sep 17 00:00:00 2001 From: Michael Kirk Date: Tue, 27 Feb 2018 15:18:40 -0500 Subject: [PATCH] CR: Add translation comment // FREEBIE --- .../ViewControllers/NotificationSettingsViewController.m | 6 +++++- Signal/translations/en.lproj/Localizable.strings | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Signal/src/ViewControllers/NotificationSettingsViewController.m b/Signal/src/ViewControllers/NotificationSettingsViewController.m index b0620f4eb..f299fce92 100644 --- a/Signal/src/ViewControllers/NotificationSettingsViewController.m +++ b/Signal/src/ViewControllers/NotificationSettingsViewController.m @@ -53,7 +53,11 @@ OWSSoundSettingsViewController *vc = [OWSSoundSettingsViewController new]; [weakSelf.navigationController pushViewController:vc animated:YES]; }]]; - [soundsSection addItem:[OWSTableItem switchItemWithText:NSLocalizedString(@"NOTIFICATIONS_SECTION_INAPP", nil) + + NSString *inAppSoundsLabelText = NSLocalizedString(@"NOTIFICATIONS_SECTION_INAPP", + @"Table cell switch label. When disabled, Signal will not play notification sounds while the app is in the " + @"foreground."); + [soundsSection addItem:[OWSTableItem switchItemWithText:inAppSoundsLabelText isOn:[prefs soundInForeground] target:weakSelf selector:@selector(didToggleSoundNotificationsSwitch:)]]; diff --git a/Signal/translations/en.lproj/Localizable.strings b/Signal/translations/en.lproj/Localizable.strings index 0982cbf93..84ba8fe98 100644 --- a/Signal/translations/en.lproj/Localizable.strings +++ b/Signal/translations/en.lproj/Localizable.strings @@ -1149,7 +1149,7 @@ /* No comment provided by engineer. */ "NOTIFICATIONS_NONE" = "No Name or Content"; -/* No comment provided by engineer. */ +/* Table cell switch label. When disabled, Signal will not play notification sounds while the app is in the foreground. */ "NOTIFICATIONS_SECTION_INAPP" = "Play While App is Open"; /* Label for settings UI that allows user to change the notification sound. */