diff --git a/Signal/src/call/CallService.swift b/Signal/src/call/CallService.swift index d26d3e35d..81bb41dc5 100644 --- a/Signal/src/call/CallService.swift +++ b/Signal/src/call/CallService.swift @@ -78,7 +78,7 @@ enum CallError: Error { } // Should be roughly synced with Android client for consistency -fileprivate let timeoutSeconds = 120 +fileprivate let connectingTimeoutSeconds = 120 // All Observer methods will be invoked from the main thread. protocol CallServiceObserver: class { @@ -298,7 +298,7 @@ protocol CallServiceObserver: class { return getIceServers().then { iceServers -> Promise in Logger.debug("\(self.TAG) got ice servers:\(iceServers)") - let peerConnectionClient = PeerConnectionClient(iceServers: iceServers, delegate: self, callType: .outgoing) + let peerConnectionClient = PeerConnectionClient(iceServers: iceServers, delegate: self, callDirection: .outgoing) assert(self.peerConnectionClient == nil, "Unexpected PeerConnectionClient instance") Logger.debug("\(self.TAG) setting peerConnectionClient in \(#function)") @@ -316,7 +316,7 @@ protocol CallServiceObserver: class { self.fulfillCallConnectedPromise = fulfill // Don't let the outgoing call ring forever. We don't support inbound ringing forever anyway. - let timeout: Promise = after(interval: TimeInterval(timeoutSeconds)).then { () -> Void in + let timeout: Promise = after(interval: TimeInterval(connectingTimeoutSeconds)).then { () -> Void in // rejecting a promise by throwing is safely a no-op if the promise has already been fulfilled throw CallError.timeout(description: "timed out waiting to receive call answer") } @@ -467,7 +467,7 @@ protocol CallServiceObserver: class { } assert(self.peerConnectionClient == nil, "Unexpected PeerConnectionClient instance") Logger.debug("\(self.self.TAG) setting peerConnectionClient in \(#function)") - self.peerConnectionClient = PeerConnectionClient(iceServers: iceServers, delegate: self, callType: .incoming) + self.peerConnectionClient = PeerConnectionClient(iceServers: iceServers, delegate: self, callDirection: .incoming) let offerSessionDescription = RTCSessionDescription(type: .offer, sdp: callerSessionDescription) let constraints = RTCMediaConstraints(mandatoryConstraints: nil, optionalConstraints: nil) @@ -492,7 +492,7 @@ protocol CallServiceObserver: class { let (promise, fulfill, _) = Promise.pending() - let timeout: Promise = after(interval: TimeInterval(timeoutSeconds)).then { () -> Void in + let timeout: Promise = after(interval: TimeInterval(connectingTimeoutSeconds)).then { () -> Void in // rejecting a promise by throwing is safely a no-op if the promise has already been fulfilled throw CallError.timeout(description: "timed out waiting for call to connect") } diff --git a/Signal/src/call/PeerConnectionClient.swift b/Signal/src/call/PeerConnectionClient.swift index ba1ed865c..676f23c01 100644 --- a/Signal/src/call/PeerConnectionClient.swift +++ b/Signal/src/call/PeerConnectionClient.swift @@ -64,11 +64,6 @@ protocol PeerConnectionClientDelegate: class { */ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelDelegate { - enum CallType { - case incoming - case outgoing - } - let TAG = "[PeerConnectionClient]" enum Identifiers: String { case mediaStream = "ARDAMS", @@ -125,7 +120,7 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD private var remoteVideoTrack: RTCVideoTrack? private var cameraConstraints: RTCMediaConstraints - init(iceServers: [RTCIceServer], delegate: PeerConnectionClientDelegate, callType: CallType) { + init(iceServers: [RTCIceServer], delegate: PeerConnectionClientDelegate, callDirection: CallDirection) { AssertIsOnMainThread() self.iceServers = iceServers @@ -152,7 +147,7 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD createAudioSender() createVideoSender() - if callType == .outgoing { + if callDirection == .outgoing { // When placing an outgoing call, it's our responsibility to create the DataChannel. // Recipient will not have to do this explicitly. createSignalingDataChannel()