From 2e75e9df55294dfdb02c939dd8b4960b14442a67 Mon Sep 17 00:00:00 2001 From: Michael Kirk Date: Fri, 17 Nov 2017 17:41:38 -0500 Subject: [PATCH] Don't ignore critical errors // FREEBIE --- Signal/src/call/PeerConnectionClient.swift | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/Signal/src/call/PeerConnectionClient.swift b/Signal/src/call/PeerConnectionClient.swift index 1a1b6d516..7275993af 100644 --- a/Signal/src/call/PeerConnectionClient.swift +++ b/Signal/src/call/PeerConnectionClient.swift @@ -359,7 +359,11 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD } Logger.verbose("\(self.TAG) setting local session description: \(sessionDescription)") self.peerConnection.setLocalDescription(sessionDescription.rtcSessionDescription, - completionHandler: { _ in + completionHandler: { error in + guard error == nil else { + reject(error!) + return + } fulfill() }) } @@ -387,7 +391,11 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD } Logger.verbose("\(self.TAG) setting remote description: \(sessionDescription)") self.peerConnection.setRemoteDescription(sessionDescription, - completionHandler: { _ in + completionHandler: { error in + guard error == nil else { + reject(error!) + return + } fulfill() }) } @@ -512,6 +520,9 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD guard let dataChannel = self.dataChannel else { Logger.error("\(self.TAG) in \(#function) ignoring sending \(data) for nil dataChannel: \(description)") + if isCritical { + owsFail("\(self.TAG) in \(#function) ignoring sending \(data) for nil dataChannel: \(description)") + } return }