From 6f1ae778b8e5bdf3d96f52be25e84ed69448b438 Mon Sep 17 00:00:00 2001 From: 2-4601 Date: Sat, 20 Feb 2016 14:28:28 +0200 Subject: [PATCH 1/5] Update README.md - remove references to the mailing list (as suggested by Riya) - add links to the community forum - update copyright year //FREEBIE Closes #1087 --- README.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 607336a49..d641d8367 100644 --- a/README.md +++ b/README.md @@ -13,12 +13,15 @@ Instructions on how to setup your development environment and build Signal-iOS c If you're new to the Signal-iOS codebase, we recommend going through our issues and picking out a simple bug to fix (check the "easy" label in our issues) in order to get yourself familiar. -For larger changes and feature ideas, we ask that you propose it on the mailing list for a high-level discussion before implementation. +For larger changes and feature ideas, we ask that you propose it on the [unofficial Community Forum](https://whispersystems.discoursehosting.net) for a high-level discussion with the wider community before implementation. This repository is set up with [BitHub](https://whispersystems.org/blog/bithub/), so you can make money for committing to Signal-iOS. The current BitHub price for an accepted pull request is: [![Current BitHub Price](https://bithub.herokuapp.com/v1/status/payment/commit/)](https://whispersystems.org/blog/bithub/) +## Contributing Ideas +Have something you want to say about Open Whisper Systems projects or want to be part of the conversation? Get involved in the [community forum](https://whispersystems.discoursehosting.net). + ## Cryptography Notice This distribution includes cryptographic software. The country in which you currently reside may have restrictions on the import, possession, use, and/or re-export to another country, of encryption software. @@ -30,6 +33,6 @@ The form and manner of this distribution makes it eligible for export under the ## License -Copyright 2014 Open Whisper Systems +Copyright 2014-2016 Open Whisper Systems Licensed under the GPLv3: http://www.gnu.org/licenses/gpl-3.0.html From 72e1180e163f5e0d15e1a4ddd72aca27acfad6f3 Mon Sep 17 00:00:00 2001 From: Arek Banas Date: Fri, 12 Feb 2016 16:53:08 +0100 Subject: [PATCH 2/5] Removing unused didReceiveMemoryWarning methods from view controllers. Closes #1078 --- Signal/src/view controllers/APNavigationController.m | 5 ----- .../view controllers/AdvancedSettingsTableViewController.m | 4 ---- .../src/view controllers/CodeVerificationViewController.m | 5 ----- Signal/src/view controllers/FingerprintViewController.m | 4 ---- Signal/src/view controllers/FullImageViewController.m | 6 ------ .../view controllers/MessageComposeTableViewController.m | 5 ----- Signal/src/view controllers/MessagesViewController.m | 4 ---- Signal/src/view controllers/NewGroupViewController.m | 4 ---- .../view controllers/PresentIdentityQRCodeViewController.m | 6 ------ Signal/src/view controllers/RegistrationViewController.m | 6 ------ .../src/view controllers/ShowGroupMembersViewController.m | 4 ---- Signal/src/view controllers/SignalsNavigationController.m | 5 ----- 12 files changed, 58 deletions(-) diff --git a/Signal/src/view controllers/APNavigationController.m b/Signal/src/view controllers/APNavigationController.m index 4da58622e..50098158d 100644 --- a/Signal/src/view controllers/APNavigationController.m +++ b/Signal/src/view controllers/APNavigationController.m @@ -35,11 +35,6 @@ self.originalNavigationBarTitle = self.navigationBar.topItem.title; } -- (void)didReceiveMemoryWarning { - [super didReceiveMemoryWarning]; - // Dispose of any resources that can be recreated. -} - - (void)toggleDropDown:(id)sender { if (self.isDropDownVisible) { [self hideDropDown:sender]; diff --git a/Signal/src/view controllers/AdvancedSettingsTableViewController.m b/Signal/src/view controllers/AdvancedSettingsTableViewController.m index 26b800ae9..7a988e728 100644 --- a/Signal/src/view controllers/AdvancedSettingsTableViewController.m +++ b/Signal/src/view controllers/AdvancedSettingsTableViewController.m @@ -41,10 +41,6 @@ return [super initWithStyle:UITableViewStyleGrouped]; } -- (void)didReceiveMemoryWarning { - [super didReceiveMemoryWarning]; -} - - (void)loadView { [super loadView]; diff --git a/Signal/src/view controllers/CodeVerificationViewController.m b/Signal/src/view controllers/CodeVerificationViewController.m index 9e2cb82d5..2564c694f 100644 --- a/Signal/src/view controllers/CodeVerificationViewController.m +++ b/Signal/src/view controllers/CodeVerificationViewController.m @@ -49,11 +49,6 @@ [self adjustScreenSizes]; } -- (void)didReceiveMemoryWarning { - [super didReceiveMemoryWarning]; -} - - - (IBAction)verifyChallengeAction:(id)sender { [self enableServerActions:NO]; [_challengeTextField resignFirstResponder]; diff --git a/Signal/src/view controllers/FingerprintViewController.m b/Signal/src/view controllers/FingerprintViewController.m index 70104fffb..4bc4f51d0 100644 --- a/Signal/src/view controllers/FingerprintViewController.m +++ b/Signal/src/view controllers/FingerprintViewController.m @@ -67,10 +67,6 @@ static NSString *const kScanIdentityBarcodeViewSegue = @"ScanIdentityBarcodeVi completion:nil]; } -- (void)didReceiveMemoryWarning { - [super didReceiveMemoryWarning]; -} - - (void)setTheirKeyInformation { self.contactFingerprintTitleLabel.text = self.thread.name; NSData *identityKey = [[TSStorageManager sharedManager] identityKeyForRecipientId:self.thread.contactIdentifier]; diff --git a/Signal/src/view controllers/FullImageViewController.m b/Signal/src/view controllers/FullImageViewController.m index 66c0fe825..0bf9c2c8e 100644 --- a/Signal/src/view controllers/FullImageViewController.m +++ b/Signal/src/view controllers/FullImageViewController.m @@ -79,12 +79,6 @@ [self populateImageView:self.image]; } - -- (void)didReceiveMemoryWarning { - [super didReceiveMemoryWarning]; -} - - #pragma mark - Initializers - (void)initializeBackground { diff --git a/Signal/src/view controllers/MessageComposeTableViewController.m b/Signal/src/view controllers/MessageComposeTableViewController.m index 2adebcc64..d566632f2 100644 --- a/Signal/src/view controllers/MessageComposeTableViewController.m +++ b/Signal/src/view controllers/MessageComposeTableViewController.m @@ -51,11 +51,6 @@ self.title = NSLocalizedString(@"MESSAGE_COMPOSEVIEW_TITLE", @""); } -- (void)didReceiveMemoryWarning { - [super didReceiveMemoryWarning]; -} - - - (void)viewDidAppear:(BOOL)animated { [super viewDidAppear:animated]; diff --git a/Signal/src/view controllers/MessagesViewController.m b/Signal/src/view controllers/MessagesViewController.m index 98a4e4e63..9bfd086a9 100644 --- a/Signal/src/view controllers/MessagesViewController.m +++ b/Signal/src/view controllers/MessagesViewController.m @@ -304,10 +304,6 @@ typedef enum : NSUInteger { self.inputToolbar.contentView.textView.editable = NO; } -- (void)didReceiveMemoryWarning { - [super didReceiveMemoryWarning]; -} - #pragma mark - Initiliazers diff --git a/Signal/src/view controllers/NewGroupViewController.m b/Signal/src/view controllers/NewGroupViewController.m index fcc178c9d..20fcef2ff 100644 --- a/Signal/src/view controllers/NewGroupViewController.m +++ b/Signal/src/view controllers/NewGroupViewController.m @@ -90,10 +90,6 @@ static NSString *const kUnwindToMessagesViewSegue = @"UnwindToMessagesViewSegue" _addPeopleLabel.text = NSLocalizedString(@"NEW_GROUP_REQUEST_ADDPEOPLE", @""); } -- (void)didReceiveMemoryWarning { - [super didReceiveMemoryWarning]; -} - #pragma mark - Initializers - (void)initializeDelegates { diff --git a/Signal/src/view controllers/PresentIdentityQRCodeViewController.m b/Signal/src/view controllers/PresentIdentityQRCodeViewController.m index 7b6259dcc..beddfc7bd 100644 --- a/Signal/src/view controllers/PresentIdentityQRCodeViewController.m +++ b/Signal/src/view controllers/PresentIdentityQRCodeViewController.m @@ -13,12 +13,6 @@ @implementation PresentIdentityQRCodeViewController - -- (void)didReceiveMemoryWarning { - [super didReceiveMemoryWarning]; -} - - - (void)viewDidLoad { [super viewDidLoad]; diff --git a/Signal/src/view controllers/RegistrationViewController.m b/Signal/src/view controllers/RegistrationViewController.m index e3a4b2c81..02b14894f 100644 --- a/Signal/src/view controllers/RegistrationViewController.m +++ b/Signal/src/view controllers/RegistrationViewController.m @@ -58,12 +58,6 @@ static NSString *const kCodeSentSegue = @"codeSent"; [_phoneNumberTextField becomeFirstResponder]; } -- (void)didReceiveMemoryWarning { - [super didReceiveMemoryWarning]; - // Dispose of any resources that can be recreated. -} - - #pragma mark - Locale - (void)populateDefaultCountryNameAndCode { diff --git a/Signal/src/view controllers/ShowGroupMembersViewController.m b/Signal/src/view controllers/ShowGroupMembersViewController.m index 3b2ac25ee..b0da559fb 100644 --- a/Signal/src/view controllers/ShowGroupMembersViewController.m +++ b/Signal/src/view controllers/ShowGroupMembersViewController.m @@ -55,10 +55,6 @@ static NSString *const kUnwindToMessagesViewSegue = @"UnwindToMessagesViewSegue" untilCancelled:nil]; } -- (void)didReceiveMemoryWarning { - [super didReceiveMemoryWarning]; -} - #pragma mark - Initializers diff --git a/Signal/src/view controllers/SignalsNavigationController.m b/Signal/src/view controllers/SignalsNavigationController.m index b4bede9a5..17003817a 100644 --- a/Signal/src/view controllers/SignalsNavigationController.m +++ b/Signal/src/view controllers/SignalsNavigationController.m @@ -25,11 +25,6 @@ static double const STALLED_PROGRESS = 0.9; [TSSocketManager sendNotification]; } -- (void)didReceiveMemoryWarning { - [super didReceiveMemoryWarning]; - // Dispose of any resources that can be recreated. -} - - (void)initializeSocketStatusBar { if (!_socketStatusView) { _socketStatusView = [[UIProgressView alloc] initWithProgressViewStyle:UIProgressViewStyleDefault]; From 4f38e70a06168bf11a8829f87573333d560b743c Mon Sep 17 00:00:00 2001 From: 2-4601 Date: Sat, 20 Feb 2016 14:39:25 +0200 Subject: [PATCH 3/5] Add templates for issues and pull requests GitHub recently introduced templates for issues and PRs. These will hopefully improve both. Fixes #1088 //FREEBIE --- .github/ISSUE_TEMPLATE.md | 39 ++++++++++++++++++++++++++++++++ .github/PULL_REQUEST_TEMPLATE.md | 24 ++++++++++++++++++++ 2 files changed, 63 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE.md create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md new file mode 100644 index 000000000..9770da67b --- /dev/null +++ b/.github/ISSUE_TEMPLATE.md @@ -0,0 +1,39 @@ + + +- [ ] I have searched open and closed issues for duplicates + +---------------------------------------- + +### Bug description +Describe here the issue that you are experiencing. + +### Steps to reproduce +- using hyphens as bullet points +- list the steps +- that reproduce the bug + +**Actual result:** Describe here what happens after you run the steps above (i.e. the buggy behaviour) +**Expected result:** Describe here what should happen after you run the steps above (i.e. what would be the correct behaviour) + +### Screenshots + + + +### Device info + +**Device**: iDevice X +**iOS version**: X.Y.Z +**Signal version:** Z.Y + +### Link to debug log + + diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 000000000..118de5c7e --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,24 @@ + +### First time contributor checklist + +- [ ] I have read the [README](https://github.com/WhisperSystems/Signal-iOS/blob/master/README.md) and [CONTRIBUTING](https://github.com/WhisperSystems/Signal-iOS/blob/master/CONTRIBUTING.md) documents +- [ ] I have signed the [Contributor Licence Agreement](https://whispersystems.org/cla/) + +### Contributor checklist + +- [ ] I'm following the [code, UI and style conventions](https://github.com/WhisperSystems/Signal-iOS/blob/master/CONTRIBUTING.md#code-conventions) +- [ ] My commits are rebased on the latest master branch +- [ ] My commits are in nice logical chunks +- [ ] My contribution is fully baked and is ready to be merged as is +- [ ] I have tested my contribution on these devices: + * iDevice A, iOS X.Y.Z + * iDevice B, iOS Z.Y +- [ ] I have made the choice whether I want the [BitHub reward](https://github.com/WhisperSystems/Signal-Android/wiki/BitHub-Rewards) or not by omitting or adding the word `FREEBIE` in my commit message + +- - - - - - - - - - + +### Description + From 721ed066f21bdfa9d89d1635f9e2d2483a636e8c Mon Sep 17 00:00:00 2001 From: Michael Kirk Date: Fri, 1 Apr 2016 08:34:47 -0700 Subject: [PATCH 4/5] Fixes This class is not key value coding-compliant for the key "keyPath" Since "Key Path" is the header for run time attributes, my guess is that this was a click misfire so long ago. I'm not clear if this was ever causing a crash or just a warning, but we don't want the noise. Fix "Unbalanced calls to begin/end appearance transitions" You should not segue while animations are in progress. I'm not sure if this was causing intermittent crashes or just the warning. //FREEBIE Closes #1130 --- Signal/src/Storyboard/Storyboard.storyboard | 3 --- .../view controllers/UITests/SignalsViewController.m | 10 ++++++---- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/Signal/src/Storyboard/Storyboard.storyboard b/Signal/src/Storyboard/Storyboard.storyboard index 91474bc98..3a7d9c2d7 100755 --- a/Signal/src/Storyboard/Storyboard.storyboard +++ b/Signal/src/Storyboard/Storyboard.storyboard @@ -606,9 +606,6 @@ A0 09 9A FF A8 8A 09 99 - - -