Tweaks to CI scripts

.drone.jsonnet

@@ -232,7 +232,8 @@ local unit_test_summary = {
         name: 'Install Codecov CLI',
         commands: [
           'mkdir -p build/artifacts',
-          'pip3 install codecov-cli 2>&1 | grep "The script codecovcli is installed in" | sed -n -e "s/^.*The script codecovcli is installed in //p" | sed -n -e "s/ which is not on PATH.$//p" > ./build/artifacts/codecov_install_path',
+          'pip3 install codecov-cli',
+          'find $HOME/Library/Python -name codecovcli -print -quit > ./build/artifacts/codecov_install_path',
           |||
             if [[ ! -s ./build/artifacts/codecov_install_path ]]; then
               which codecovcli > ./build/artifacts/codecov_install_path

Scripts/clean-up-old-test-simulators.sh

@@ -31,9 +31,9 @@ uuids_to_ignore=()
 uuids_to_remove=()
 
 # Find directories older than an hour
-while read -r dir; do
+while read -r child_dir; do
   # Get the last component of the directory path
-  dir_name=$(basename "$dir")
+  dir_name=$(basename "$child_dir")
 
   # If the folder is not in the uuids array then add it to the uuids_to_remove
   # array, otherwise add it to uuids_to_ignore
@@ -45,9 +45,9 @@ while read -r dir; do
 done < <(find "$dir" -maxdepth 1 -type d -not -path "$dir" -mmin +60)
 
 # Find directories newer than an hour
-while read -r dir; do
+while read -r child_dir; do
   # Get the last component of the directory path
-  dir_name=$(basename "$dir")
+  dir_name=$(basename "$child_dir")
 
   # If the folder is not in the uuids array then add it to the uuids_to_keep array
   if ! echo "$uuids" | grep -q "$dir_name"; then
@@ -62,7 +62,7 @@ else
   echo -e "\e[31mDeleting ${#uuids_to_remove[@]} old test simulators:\e[0m"
   for uuid in "${uuids_to_remove[@]}"; do
     echo -e "\e[31m    $uuid\e[0m"
-    xcrun simctl delete "$uuid"
+    # xcrun simctl delete "$uuid"
   done
 fi