Remove some usage of throwswrapped_ in udmanager since we don't need to

propogate the wrapped exception anyway.

SignalServiceKit/src/Messages/OWSMessageSender.m

@@ -479,7 +479,7 @@ NSString *const OWSMessageSenderRateLimitedException = @"RateLimitedException";
                      failure:(RetryableFailureHandler)failure
 {
     [self.udManager
-        throwswrapped_ensureSenderCertificateWithSuccess:^(SMKSenderCertificate *senderCertificate) {
+        ensureSenderCertificateWithSuccess:^(SMKSenderCertificate *senderCertificate) {
             dispatch_async([OWSDispatch sendingQueue], ^{
                 [self sendMessageToService:message senderCertificate:senderCertificate success:success failure:failure];
             });

SignalServiceKit/src/Messages/UD/OWSUDManager.swift

@@ -65,8 +65,8 @@ private func string(forUnidentifiedAccessMode mode: UnidentifiedAccessMode) -> S
     // We use completion handlers instead of a promise so that message sending
     // logic can access the strongly typed certificate data.
     @objc
-    func throwswrapped_ensureSenderCertificate(success:@escaping (SMKSenderCertificate) -> Void,
-                                            failure:@escaping (Error) -> Void)
+    func ensureSenderCertificate(success:@escaping (SMKSenderCertificate) -> Void,
+                                 failure:@escaping (Error) -> Void)
 
     // MARK: Unrestricted Access
 
@@ -111,7 +111,7 @@ public class OWSUDManagerImpl: NSObject, OWSUDManager {
             }
 
             // Any error is silently ignored on startup.
-            self.throwswrapped_ensureSenderCertificate().retainUntilComplete()
+            self.ensureSenderCertificate().retainUntilComplete()
         }
         NotificationCenter.default.addObserver(self,
                                                selector: #selector(registrationStateDidChange),
@@ -124,7 +124,7 @@ public class OWSUDManagerImpl: NSObject, OWSUDManager {
         AssertIsOnMainThread()
 
         // Any error is silently ignored
-        throwswrapped_ensureSenderCertificate().retainUntilComplete()
+        ensureSenderCertificate().retainUntilComplete()
     }
 
     // MARK: -
@@ -266,12 +266,12 @@ public class OWSUDManagerImpl: NSObject, OWSUDManager {
 
     #if DEBUG
     @objc
-    public func throwswrapped_hasSenderCertificate() -> Bool {
-        return throwswrapped_senderCertificate() != nil
+    public func hasSenderCertificate() -> Bool {
+        return senderCertificate() != nil
     }
     #endif
 
-    private func throwswrapped_senderCertificate() -> SMKSenderCertificate? {
+    private func senderCertificate() -> SMKSenderCertificate? {
         guard let certificateData = dbConnection.object(forKey: senderCertificateKey(), inCollection: kUDCollection) as? Data else {
             return nil
         }
@@ -279,7 +279,7 @@ public class OWSUDManagerImpl: NSObject, OWSUDManager {
         do {
             let certificate = try SMKSenderCertificate.parse(data: certificateData)
 
-            guard throwswrapped_isValidCertificate(certificate) else {
+            guard isValidCertificate(certificate) else {
                 Logger.warn("Current sender certificate is not valid.")
                 return nil
             }
@@ -300,10 +300,10 @@ public class OWSUDManagerImpl: NSObject, OWSUDManager {
     }
 
     @objc
-    public func throwswrapped_ensureSenderCertificate(success:@escaping (SMKSenderCertificate) -> Void,
-                                                   failure:@escaping (Error) -> Void) {
+    public func ensureSenderCertificate(success:@escaping (SMKSenderCertificate) -> Void,
+                                        failure:@escaping (Error) -> Void) {
         firstly {
-            throwswrapped_ensureSenderCertificate()
+            ensureSenderCertificate()
         }.map { certificate in
             success(certificate)
         }.catch { error in
@@ -311,15 +311,15 @@ public class OWSUDManagerImpl: NSObject, OWSUDManager {
         }.retainUntilComplete()
     }
 
-    public func throwswrapped_ensureSenderCertificate() -> Promise<SMKSenderCertificate> {
+    public func ensureSenderCertificate() -> Promise<SMKSenderCertificate> {
         // If there is a valid cached sender certificate, use that.
-        if let certificate = throwswrapped_senderCertificate() {
+        if let certificate = senderCertificate() {
             return Promise.value(certificate)
         }
 
         // Try to obtain a new sender certificate.
         return firstly {
-            throwswrapped_requestSenderCertificate()
+            requestSenderCertificate()
         }.map { (certificateData: Data, certificate: SMKSenderCertificate) in
 
             // Cache the current sender certificate.
@@ -329,13 +329,13 @@ public class OWSUDManagerImpl: NSObject, OWSUDManager {
         }
     }
 
-    private func throwswrapped_requestSenderCertificate() -> Promise<(certificateData: Data, certificate: SMKSenderCertificate)> {
+    private func requestSenderCertificate() -> Promise<(certificateData: Data, certificate: SMKSenderCertificate)> {
         return firstly {
             SignalServiceRestClient().requestUDSenderCertificate()
         }.map { certificateData -> (certificateData: Data, certificate: SMKSenderCertificate) in
             let certificate = try SMKSenderCertificate.parse(data: certificateData)
 
-            guard self.throwswrapped_isValidCertificate(certificate) else {
+            guard self.isValidCertificate(certificate) else {
                 throw OWSUDError.invalidData(description: "Invalid sender certificate returned by server")
             }
 
@@ -343,7 +343,7 @@ public class OWSUDManagerImpl: NSObject, OWSUDManager {
         }
     }
 
-    private func throwswrapped_isValidCertificate(_ certificate: SMKSenderCertificate) -> Bool {
+    private func isValidCertificate(_ certificate: SMKSenderCertificate) -> Bool {
         // Ensure that the certificate will not expire in the next hour.
         // We want a threshold long enough to ensure that any outgoing message
         // sends will complete before the expiration.