From 1b0a12d7c0d3a2258495a39eb862b693be762724 Mon Sep 17 00:00:00 2001 From: Niels Andriesse Date: Tue, 3 Aug 2021 16:21:30 +1000 Subject: [PATCH] Don't unnecessarily unsubscribe from closed group PNs We don't need to do this anymore as we now have the ability to ignore PNs in the notification service extension --- .../Settings/OWSConversationSettingsViewController.m | 11 ----------- .../Notifications/PushNotificationAPI.swift | 8 +------- 2 files changed, 1 insertion(+), 18 deletions(-) diff --git a/Session/Conversations/Settings/OWSConversationSettingsViewController.m b/Session/Conversations/Settings/OWSConversationSettingsViewController.m index 7d3135714..b703a58ff 100644 --- a/Session/Conversations/Settings/OWSConversationSettingsViewController.m +++ b/Session/Conversations/Settings/OWSConversationSettingsViewController.m @@ -861,17 +861,6 @@ CGFloat kIconViewLength = 24; [self.thread updateWithMutedUntilDate:nil transaction:transaction]; }]; } - if (self.isClosedGroup) { - NSString *groupPublicKey = [LKGroupUtilities getDecodedGroupID:((TSGroupThread *)self.thread).groupModel.groupId]; - NSString *userPublicKey = [SNGeneralUtilities getUserPublicKey]; - if (uiSwitch.isOn) { - [[LKPushNotificationAPI performOperation:ClosedGroupOperationUnsubscribe - forClosedGroupWithPublicKey:groupPublicKey userPublicKey:userPublicKey] retainUntilComplete]; - } else { - [[LKPushNotificationAPI performOperation:ClosedGroupOperationSubscribe - forClosedGroupWithPublicKey:groupPublicKey userPublicKey:userPublicKey] retainUntilComplete]; - } - } } - (void)blockConversationSwitchDidChange:(id)sender diff --git a/SessionMessagingKit/Sending & Receiving/Notifications/PushNotificationAPI.swift b/SessionMessagingKit/Sending & Receiving/Notifications/PushNotificationAPI.swift index b725e1527..8fccb96ec 100644 --- a/SessionMessagingKit/Sending & Receiving/Notifications/PushNotificationAPI.swift +++ b/SessionMessagingKit/Sending & Receiving/Notifications/PushNotificationAPI.swift @@ -88,13 +88,7 @@ public final class PushNotificationAPI : NSObject { } // Subscribe to all closed groups Storage.shared.getUserClosedGroupPublicKeys().forEach { closedGroupPublicKey in - let groupID = LKGroupUtilities.getEncodedClosedGroupIDAsData(closedGroupPublicKey) - let threadOrNil = TSGroupThread.fetch(uniqueId: TSGroupThread.threadId(fromGroupId: groupID)) - if threadOrNil?.isMuted == true { - // Do nothing - } else { - performOperation(.subscribe, for: closedGroupPublicKey, publicKey: publicKey) - } + performOperation(.subscribe, for: closedGroupPublicKey, publicKey: publicKey) } return promise }