diff --git a/SignalMessaging/ViewControllers/OWSNavigationController.m b/SignalMessaging/ViewControllers/OWSNavigationController.m index 6958c4c22..c8d36fc79 100644 --- a/SignalMessaging/ViewControllers/OWSNavigationController.m +++ b/SignalMessaging/ViewControllers/OWSNavigationController.m @@ -150,9 +150,7 @@ NS_ASSUME_NONNULL_BEGIN - (UIStatusBarStyle)preferredStatusBarStyle { - if (!CurrentAppContext().isMainApp) { - return super.preferredStatusBarStyle; - } else if (OWSWindowManager.sharedManager.hasCall) { + if (OWSWindowManager.sharedManager.hasCall) { // Status bar is overlaying the green "call banner" return UIStatusBarStyleLightContent; } else { @@ -172,9 +170,7 @@ NS_ASSUME_NONNULL_BEGIN [UIView setAnimationsEnabled:NO]; if (@available(iOS 11.0, *)) { - if (!CurrentAppContext().isMainApp) { - self.additionalSafeAreaInsets = UIEdgeInsetsZero; - } else if (OWSWindowManager.sharedManager.hasCall) { + if (OWSWindowManager.sharedManager.hasCall) { self.additionalSafeAreaInsets = UIEdgeInsetsMake(20, 0, 0, 0); } else { self.additionalSafeAreaInsets = UIEdgeInsetsZero; diff --git a/SignalMessaging/Views/OWSNavigationBar.swift b/SignalMessaging/Views/OWSNavigationBar.swift index 39bb01238..a65ebd1de 100644 --- a/SignalMessaging/Views/OWSNavigationBar.swift +++ b/SignalMessaging/Views/OWSNavigationBar.swift @@ -157,11 +157,9 @@ public class OWSNavigationBar: UINavigationBar { } public override func layoutSubviews() { - if CurrentAppContext().isMainApp { - guard OWSWindowManager.shared().hasCall() else { - super.layoutSubviews() - return - } + guard OWSWindowManager.shared().hasCall() else { + super.layoutSubviews() + return } guard #available(iOS 11, *) else { diff --git a/SignalShareExtension/ShareViewController.swift b/SignalShareExtension/ShareViewController.swift index 199a8a583..05658281a 100644 --- a/SignalShareExtension/ShareViewController.swift +++ b/SignalShareExtension/ShareViewController.swift @@ -70,6 +70,21 @@ public class ShareViewController: UIViewController, ShareViewDelegate, SAEFailed return } + // We shouldn't set up our environment until after we've consulted isReadyForAppExtensions. + AppSetup.setupEnvironment(appSpecificSingletonBlock: { + SSKEnvironment.shared.callMessageHandler = NoopCallMessageHandler() + SSKEnvironment.shared.notificationsManager = NoopNotificationsManager() + }, + migrationCompletion: { [weak self] in + AssertIsOnMainThread() + + guard let strongSelf = self else { return } + + // performUpdateCheck must be invoked after Environment has been initialized because + // upgrade process may depend on Environment. + strongSelf.versionMigrationsDidComplete() + }) + let shareViewNavigationController = OWSNavigationController() self.shareViewNavigationController = shareViewNavigationController @@ -88,22 +103,7 @@ public class ShareViewController: UIViewController, ShareViewDelegate, SAEFailed Logger.debug("setup is slow - showing loading screen") strongSelf.showPrimaryViewController(loadViewController) - }.retainUntilComplete() - - // We shouldn't set up our environment until after we've consulted isReadyForAppExtensions. - AppSetup.setupEnvironment(appSpecificSingletonBlock: { - SSKEnvironment.shared.callMessageHandler = NoopCallMessageHandler() - SSKEnvironment.shared.notificationsManager = NoopNotificationsManager() - }, - migrationCompletion: { [weak self] in - AssertIsOnMainThread() - - guard let strongSelf = self else { return } - - // performUpdateCheck must be invoked after Environment has been initialized because - // upgrade process may depend on Environment. - strongSelf.versionMigrationsDidComplete() - }) + }.retainUntilComplete() // We don't need to use "screen protection" in the SAE.