From 0316a98eb868957cd8bbd9750f386f2409e7de00 Mon Sep 17 00:00:00 2001 From: Matthew Chen <matthew@signal.org> Date: Tue, 1 May 2018 11:26:01 -0400 Subject: [PATCH] Undo renaming of contactShare property of TSMessage. --- .../ViewControllers/DebugUI/DebugUIMessages.m | 42 +++++++++---------- SignalMessaging/utils/ThreadUtil.h | 2 +- SignalMessaging/utils/ThreadUtil.m | 6 +-- .../Devices/OWSReadReceiptsForSenderMessage.m | 2 +- .../src/Devices/OWSRecordTranscriptJob.m | 2 +- .../DeviceSyncing/OWSOutgoingSyncMessage.m | 2 +- .../DeviceSyncing/OWSSyncContactsMessage.m | 2 +- .../DeviceSyncing/OWSSyncGroupsMessage.m | 2 +- .../OWSSyncGroupsRequestMessage.m | 2 +- ...DisappearingMessagesConfigurationMessage.m | 2 +- .../Interactions/OWSDynamicOutgoingMessage.m | 2 +- .../Interactions/OWSEndSessionMessage.m | 2 +- .../Messages/Interactions/TSErrorMessage.h | 2 +- .../Messages/Interactions/TSErrorMessage.m | 2 +- .../Messages/Interactions/TSIncomingMessage.h | 4 +- .../Messages/Interactions/TSIncomingMessage.m | 4 +- .../src/Messages/Interactions/TSInfoMessage.h | 2 +- .../src/Messages/Interactions/TSInfoMessage.m | 2 +- .../src/Messages/Interactions/TSMessage.h | 4 +- .../src/Messages/Interactions/TSMessage.m | 6 +-- .../Messages/Interactions/TSOutgoingMessage.h | 4 +- .../Messages/Interactions/TSOutgoingMessage.m | 13 +++--- .../src/Messages/OWSMessageManager.m | 4 +- .../src/Messages/OWSMessageSender.m | 2 +- .../src/Messages/OWSOutgoingCallMessage.m | 2 +- .../src/Messages/OWSOutgoingNullMessage.m | 2 +- .../src/Messages/OWSProfileKeyMessage.m | 2 +- 27 files changed, 62 insertions(+), 61 deletions(-) diff --git a/Signal/src/ViewControllers/DebugUI/DebugUIMessages.m b/Signal/src/ViewControllers/DebugUI/DebugUIMessages.m index 1bb14e8cf..e308dbbad 100644 --- a/Signal/src/ViewControllers/DebugUI/DebugUIMessages.m +++ b/Signal/src/ViewControllers/DebugUI/DebugUIMessages.m @@ -820,7 +820,7 @@ NS_ASSUME_NONNULL_BEGIN isDelivered:YES isRead:NO quotedMessage:nil - contact:nil + contactShare:nil transaction:transaction]; // This is a hack to "back-date" the message. @@ -1753,7 +1753,7 @@ NS_ASSUME_NONNULL_BEGIN isDelivered:NO isRead:NO quotedMessage:nil - contact:nil + contactShare:nil transaction:transaction]; }]; } @@ -1801,7 +1801,7 @@ NS_ASSUME_NONNULL_BEGIN isDelivered:isDelivered isRead:isRead quotedMessage:nil - contact:nil + contactShare:nil transaction:transaction]; }]; } @@ -1975,7 +1975,7 @@ NS_ASSUME_NONNULL_BEGIN isDelivered:quotedMessageIsDelivered isRead:quotedMessageIsRead quotedMessage:nil - contact:nil + contactShare:nil transaction:transaction]; OWSAssert(messageToQuote); quotedMessage = [[OWSQuotedReplyModel quotedReplyForMessage:messageToQuote transaction:transaction] @@ -2000,7 +2000,7 @@ NS_ASSUME_NONNULL_BEGIN isDelivered:replyIsDelivered isRead:replyIsRead quotedMessage:quotedMessage - contact:nil + contactShare:nil transaction:transaction]; } } @@ -2849,7 +2849,7 @@ NS_ASSUME_NONNULL_BEGIN isDelivered:NO isRead:NO quotedMessage:nil - contact:nil + contactShare:nil transaction:transaction]; [message setReceivedAtTimestamp:(uint64_t)((int64_t)[NSDate ows_millisecondTimeStamp] + dateOffset)]; [message saveWithTransaction:transaction]; @@ -2919,7 +2919,7 @@ typedef OWSContact * (^OWSContactBlock)(void); isDelivered:NO isRead:NO quotedMessage:nil - contact:contact + contactShare:contact transaction:transaction]; [message saveWithTransaction:transaction]; }]; @@ -3104,7 +3104,7 @@ typedef OWSContact * (^OWSContactBlock)(void); [ThreadUtil sendMessageWithAttachment:attachment inThread:thread quotedReplyModel:nil - contact:nil + contactShare:nil messageSender:messageSender ignoreErrors:YES completion:nil]; @@ -3414,7 +3414,7 @@ typedef OWSContact * (^OWSContactBlock)(void); attachmentIds:@[] expiresInSeconds:0 quotedMessage:nil - contact:nil]; + contactShare:nil]; [message markAsReadNowWithSendReadReceipt:NO transaction:transaction]; break; } @@ -3426,7 +3426,7 @@ typedef OWSContact * (^OWSContactBlock)(void); isDelivered:NO isRead:NO quotedMessage:nil - contact:nil + contactShare:nil transaction:transaction]; break; } @@ -3454,7 +3454,7 @@ typedef OWSContact * (^OWSContactBlock)(void); ] expiresInSeconds:0 quotedMessage:nil - contact:nil]; + contactShare:nil]; [message markAsReadNowWithSendReadReceipt:NO transaction:transaction]; break; } @@ -3480,7 +3480,7 @@ typedef OWSContact * (^OWSContactBlock)(void); isRead:NO isVoiceMessage:NO quotedMessage:nil - contact:nil + contactShare:nil transaction:transaction]; break; } @@ -3842,7 +3842,7 @@ typedef OWSContact * (^OWSContactBlock)(void); isVoiceMessage:NO groupMetaMessage:TSGroupMessageUnspecified quotedMessage:nil - contact:nil]; + contactShare:nil]; DDLogError(@"%@ resurrectNewOutgoingMessages2 timestamp: %llu.", self.logTag, message.timestamp); [messages addObject:message]; } @@ -3908,7 +3908,7 @@ typedef OWSContact * (^OWSContactBlock)(void); attachmentIds:[NSMutableArray new] expiresInSeconds:0 quotedMessage:nil - contact:nil]; + contactShare:nil]; [message markAsReadNowWithSendReadReceipt:NO transaction:transaction]; } { @@ -3922,7 +3922,7 @@ typedef OWSContact * (^OWSContactBlock)(void); isVoiceMessage:NO groupMetaMessage:TSGroupMessageUnspecified quotedMessage:nil - contact:nil]; + contactShare:nil]; [message saveWithTransaction:transaction]; [message updateWithFakeMessageState:TSOutgoingMessageStateSent transaction:transaction]; [message updateWithSentRecipient:recipientId transaction:transaction]; @@ -4101,7 +4101,7 @@ typedef OWSContact * (^OWSContactBlock)(void); isDelivered:(BOOL)isDelivered isRead:(BOOL)isRead quotedMessage:(nullable TSQuotedMessage *)quotedMessage - contact:(nullable OWSContact *)contact + contactShare:(nullable OWSContact *)contactShare transaction:(YapDatabaseReadWriteTransaction *)transaction { OWSAssert(thread); @@ -4127,7 +4127,7 @@ typedef OWSContact * (^OWSContactBlock)(void); isRead:isRead isVoiceMessage:attachment.isVoiceMessage quotedMessage:quotedMessage - contact:contact + contactShare:contactShare transaction:transaction]; } @@ -4140,12 +4140,12 @@ typedef OWSContact * (^OWSContactBlock)(void); isRead:(BOOL)isRead isVoiceMessage:(BOOL)isVoiceMessage quotedMessage:(nullable TSQuotedMessage *)quotedMessage - contact:(nullable OWSContact *)contact + contactShare:(nullable OWSContact *)contactShare transaction:(YapDatabaseReadWriteTransaction *)transaction { OWSAssert(thread); OWSAssert(transaction); - OWSAssert(messageBody.length > 0 || attachmentId.length > 0 || contact); + OWSAssert(messageBody.length > 0 || attachmentId.length > 0 || contactShare); NSMutableArray<NSString *> *attachmentIds = [NSMutableArray new]; if (attachmentId) { @@ -4162,7 +4162,7 @@ typedef OWSContact * (^OWSContactBlock)(void); isVoiceMessage:isVoiceMessage groupMetaMessage:TSGroupMessageUnspecified quotedMessage:quotedMessage - contact:contact]; + contactShare:contactShare]; if (attachmentId.length > 0 && filename.length > 0) { message.attachmentFilenameMap[attachmentId] = filename; @@ -4250,7 +4250,7 @@ typedef OWSContact * (^OWSContactBlock)(void); attachmentIds:attachmentIds expiresInSeconds:0 quotedMessage:quotedMessage - contact:nil]; + contactShare:nil]; [message markAsReadNowWithSendReadReceipt:NO transaction:transaction]; return message; } diff --git a/SignalMessaging/utils/ThreadUtil.h b/SignalMessaging/utils/ThreadUtil.h index a11f5a56c..8a93ab51b 100644 --- a/SignalMessaging/utils/ThreadUtil.h +++ b/SignalMessaging/utils/ThreadUtil.h @@ -72,7 +72,7 @@ NS_ASSUME_NONNULL_BEGIN + (TSOutgoingMessage *)sendMessageWithAttachment:(SignalAttachment *)attachment inThread:(TSThread *)thread quotedReplyModel:(nullable OWSQuotedReplyModel *)quotedReplyModel - contact:(nullable OWSContact *)contact + contactShare:(nullable OWSContact *)contactShare messageSender:(OWSMessageSender *)messageSender ignoreErrors:(BOOL)ignoreErrors completion:(void (^_Nullable)(NSError *_Nullable error))completion; diff --git a/SignalMessaging/utils/ThreadUtil.m b/SignalMessaging/utils/ThreadUtil.m index d35b19a2c..60d6b5e40 100644 --- a/SignalMessaging/utils/ThreadUtil.m +++ b/SignalMessaging/utils/ThreadUtil.m @@ -107,7 +107,7 @@ NS_ASSUME_NONNULL_BEGIN return [self sendMessageWithAttachment:attachment inThread:thread quotedReplyModel:quotedReplyModel - contact:nil + contactShare:nil messageSender:messageSender ignoreErrors:NO completion:completion]; @@ -116,7 +116,7 @@ NS_ASSUME_NONNULL_BEGIN + (TSOutgoingMessage *)sendMessageWithAttachment:(SignalAttachment *)attachment inThread:(TSThread *)thread quotedReplyModel:(nullable OWSQuotedReplyModel *)quotedReplyModel - contact:(nullable OWSContact *)contact + contactShare:(nullable OWSContact *)contactShare messageSender:(OWSMessageSender *)messageSender ignoreErrors:(BOOL)ignoreErrors completion:(void (^_Nullable)(NSError *_Nullable error))completion @@ -142,7 +142,7 @@ NS_ASSUME_NONNULL_BEGIN isVoiceMessage:[attachment isVoiceMessage] groupMetaMessage:TSGroupMessageUnspecified quotedMessage:[quotedReplyModel buildQuotedMessage] - contact:contact]; + contactShare:contactShare]; [messageSender enqueueAttachment:attachment.dataSource contentType:attachment.mimeType diff --git a/SignalServiceKit/src/Devices/OWSReadReceiptsForSenderMessage.m b/SignalServiceKit/src/Devices/OWSReadReceiptsForSenderMessage.m index c06788e60..ae7a29a48 100644 --- a/SignalServiceKit/src/Devices/OWSReadReceiptsForSenderMessage.m +++ b/SignalServiceKit/src/Devices/OWSReadReceiptsForSenderMessage.m @@ -30,7 +30,7 @@ NS_ASSUME_NONNULL_BEGIN isVoiceMessage:NO groupMetaMessage:TSGroupMessageUnspecified quotedMessage:nil - contact:nil]; + contactShare:nil]; if (!self) { return self; } diff --git a/SignalServiceKit/src/Devices/OWSRecordTranscriptJob.m b/SignalServiceKit/src/Devices/OWSRecordTranscriptJob.m index 1bb98374c..c9144a752 100644 --- a/SignalServiceKit/src/Devices/OWSRecordTranscriptJob.m +++ b/SignalServiceKit/src/Devices/OWSRecordTranscriptJob.m @@ -96,7 +96,7 @@ NS_ASSUME_NONNULL_BEGIN isVoiceMessage:NO groupMetaMessage:TSGroupMessageUnspecified quotedMessage:transcript.quotedMessage - contact:transcript.contact]; + contactShare:transcript.contact]; // TODO: When written, desktop didn't yet support sending quotedMessages, so we didn't have a // good way to test the handling of transcripts with a quotedMessage. This assertion can be delete diff --git a/SignalServiceKit/src/Messages/DeviceSyncing/OWSOutgoingSyncMessage.m b/SignalServiceKit/src/Messages/DeviceSyncing/OWSOutgoingSyncMessage.m index 8b4539da7..af1e6efea 100644 --- a/SignalServiceKit/src/Messages/DeviceSyncing/OWSOutgoingSyncMessage.m +++ b/SignalServiceKit/src/Messages/DeviceSyncing/OWSOutgoingSyncMessage.m @@ -23,7 +23,7 @@ NS_ASSUME_NONNULL_BEGIN isVoiceMessage:NO groupMetaMessage:TSGroupMessageUnspecified quotedMessage:nil - contact:nil]; + contactShare:nil]; if (!self) { return self; diff --git a/SignalServiceKit/src/Messages/DeviceSyncing/OWSSyncContactsMessage.m b/SignalServiceKit/src/Messages/DeviceSyncing/OWSSyncContactsMessage.m index b34e58008..217acbb69 100644 --- a/SignalServiceKit/src/Messages/DeviceSyncing/OWSSyncContactsMessage.m +++ b/SignalServiceKit/src/Messages/DeviceSyncing/OWSSyncContactsMessage.m @@ -39,7 +39,7 @@ NS_ASSUME_NONNULL_BEGIN isVoiceMessage:NO groupMetaMessage:TSGroupMessageUnspecified quotedMessage:nil - contact:nil]; + contactShare:nil]; if (!self) { return self; } diff --git a/SignalServiceKit/src/Messages/DeviceSyncing/OWSSyncGroupsMessage.m b/SignalServiceKit/src/Messages/DeviceSyncing/OWSSyncGroupsMessage.m index 647c4bacc..21a9f9a0f 100644 --- a/SignalServiceKit/src/Messages/DeviceSyncing/OWSSyncGroupsMessage.m +++ b/SignalServiceKit/src/Messages/DeviceSyncing/OWSSyncGroupsMessage.m @@ -25,7 +25,7 @@ NS_ASSUME_NONNULL_BEGIN isVoiceMessage:NO groupMetaMessage:TSGroupMessageUnspecified quotedMessage:nil - contact:nil]; + contactShare:nil]; } - (OWSSignalServiceProtosSyncMessageBuilder *)syncMessageBuilder diff --git a/SignalServiceKit/src/Messages/DeviceSyncing/OWSSyncGroupsRequestMessage.m b/SignalServiceKit/src/Messages/DeviceSyncing/OWSSyncGroupsRequestMessage.m index d8440c41c..2c35a02e2 100644 --- a/SignalServiceKit/src/Messages/DeviceSyncing/OWSSyncGroupsRequestMessage.m +++ b/SignalServiceKit/src/Messages/DeviceSyncing/OWSSyncGroupsRequestMessage.m @@ -29,7 +29,7 @@ NS_ASSUME_NONNULL_BEGIN isVoiceMessage:NO groupMetaMessage:TSGroupMessageUnspecified quotedMessage:nil - contact:nil]; + contactShare:nil]; if (!self) { return self; } diff --git a/SignalServiceKit/src/Messages/Interactions/OWSDisappearingMessagesConfigurationMessage.m b/SignalServiceKit/src/Messages/Interactions/OWSDisappearingMessagesConfigurationMessage.m index 5638310ed..998cef14b 100644 --- a/SignalServiceKit/src/Messages/Interactions/OWSDisappearingMessagesConfigurationMessage.m +++ b/SignalServiceKit/src/Messages/Interactions/OWSDisappearingMessagesConfigurationMessage.m @@ -35,7 +35,7 @@ NS_ASSUME_NONNULL_BEGIN isVoiceMessage:NO groupMetaMessage:TSGroupMessageUnspecified quotedMessage:nil - contact:nil]; + contactShare:nil]; if (!self) { return self; } diff --git a/SignalServiceKit/src/Messages/Interactions/OWSDynamicOutgoingMessage.m b/SignalServiceKit/src/Messages/Interactions/OWSDynamicOutgoingMessage.m index 6bd8ec2c7..a2e727738 100644 --- a/SignalServiceKit/src/Messages/Interactions/OWSDynamicOutgoingMessage.m +++ b/SignalServiceKit/src/Messages/Interactions/OWSDynamicOutgoingMessage.m @@ -36,7 +36,7 @@ NS_ASSUME_NONNULL_BEGIN isVoiceMessage:NO groupMetaMessage:TSGroupMessageUnspecified quotedMessage:nil - contact:nil]; + contactShare:nil]; if (self) { _block = block; diff --git a/SignalServiceKit/src/Messages/Interactions/OWSEndSessionMessage.m b/SignalServiceKit/src/Messages/Interactions/OWSEndSessionMessage.m index 0c47e1704..1b76988ee 100644 --- a/SignalServiceKit/src/Messages/Interactions/OWSEndSessionMessage.m +++ b/SignalServiceKit/src/Messages/Interactions/OWSEndSessionMessage.m @@ -20,7 +20,7 @@ NS_ASSUME_NONNULL_BEGIN isVoiceMessage:NO groupMetaMessage:TSGroupMessageUnspecified quotedMessage:nil - contact:nil]; + contactShare:nil]; } - (BOOL)shouldBeSaved diff --git a/SignalServiceKit/src/Messages/Interactions/TSErrorMessage.h b/SignalServiceKit/src/Messages/Interactions/TSErrorMessage.h index a06afa53c..aa3ef7494 100644 --- a/SignalServiceKit/src/Messages/Interactions/TSErrorMessage.h +++ b/SignalServiceKit/src/Messages/Interactions/TSErrorMessage.h @@ -34,7 +34,7 @@ typedef NS_ENUM(int32_t, TSErrorMessageType) { expiresInSeconds:(uint32_t)expiresInSeconds expireStartedAt:(uint64_t)expireStartedAt quotedMessage:(nullable TSQuotedMessage *)quotedMessage - contact:(nullable OWSContact *)contact NS_UNAVAILABLE; + contactShare:(nullable OWSContact *)contact NS_UNAVAILABLE; - (instancetype)initWithCoder:(NSCoder *)coder NS_DESIGNATED_INITIALIZER; diff --git a/SignalServiceKit/src/Messages/Interactions/TSErrorMessage.m b/SignalServiceKit/src/Messages/Interactions/TSErrorMessage.m index c77da22f8..0a1dccd6c 100644 --- a/SignalServiceKit/src/Messages/Interactions/TSErrorMessage.m +++ b/SignalServiceKit/src/Messages/Interactions/TSErrorMessage.m @@ -66,7 +66,7 @@ NSUInteger TSErrorMessageSchemaVersion = 1; expiresInSeconds:0 expireStartedAt:0 quotedMessage:nil - contact:nil]; + contactShare:nil]; if (!self) { return self; diff --git a/SignalServiceKit/src/Messages/Interactions/TSIncomingMessage.h b/SignalServiceKit/src/Messages/Interactions/TSIncomingMessage.h index a23762ab9..7d6529270 100644 --- a/SignalServiceKit/src/Messages/Interactions/TSIncomingMessage.h +++ b/SignalServiceKit/src/Messages/Interactions/TSIncomingMessage.h @@ -19,7 +19,7 @@ NS_ASSUME_NONNULL_BEGIN expiresInSeconds:(uint32_t)expiresInSeconds expireStartedAt:(uint64_t)expireStartedAt quotedMessage:(nullable TSQuotedMessage *)quotedMessage - contact:(nullable OWSContact *)contact NS_UNAVAILABLE; + contactShare:(nullable OWSContact *)contactShare NS_UNAVAILABLE; /** * Inits an incoming group message that expires. @@ -51,7 +51,7 @@ NS_ASSUME_NONNULL_BEGIN attachmentIds:(NSArray<NSString *> *)attachmentIds expiresInSeconds:(uint32_t)expiresInSeconds quotedMessage:(nullable TSQuotedMessage *)quotedMessage - contact:(nullable OWSContact *)contact NS_DESIGNATED_INITIALIZER; + contactShare:(nullable OWSContact *)contactShare NS_DESIGNATED_INITIALIZER; - (instancetype)initWithCoder:(NSCoder *)coder NS_DESIGNATED_INITIALIZER; diff --git a/SignalServiceKit/src/Messages/Interactions/TSIncomingMessage.m b/SignalServiceKit/src/Messages/Interactions/TSIncomingMessage.m index dd66a9b68..1cc2cc94a 100644 --- a/SignalServiceKit/src/Messages/Interactions/TSIncomingMessage.m +++ b/SignalServiceKit/src/Messages/Interactions/TSIncomingMessage.m @@ -44,7 +44,7 @@ NS_ASSUME_NONNULL_BEGIN attachmentIds:(NSArray<NSString *> *)attachmentIds expiresInSeconds:(uint32_t)expiresInSeconds quotedMessage:(nullable TSQuotedMessage *)quotedMessage - contact:(nullable OWSContact *)contact + contactShare:(nullable OWSContact *)contactShare { self = [super initMessageWithTimestamp:timestamp inThread:thread @@ -53,7 +53,7 @@ NS_ASSUME_NONNULL_BEGIN expiresInSeconds:expiresInSeconds expireStartedAt:0 quotedMessage:quotedMessage - contact:contact]; + contactShare:contactShare]; if (!self) { return self; diff --git a/SignalServiceKit/src/Messages/Interactions/TSInfoMessage.h b/SignalServiceKit/src/Messages/Interactions/TSInfoMessage.h index a6285718f..c870431ea 100644 --- a/SignalServiceKit/src/Messages/Interactions/TSInfoMessage.h +++ b/SignalServiceKit/src/Messages/Interactions/TSInfoMessage.h @@ -35,7 +35,7 @@ typedef NS_ENUM(NSInteger, TSInfoMessageType) { expiresInSeconds:(uint32_t)expiresInSeconds expireStartedAt:(uint64_t)expireStartedAt quotedMessage:(nullable TSQuotedMessage *)quotedMessage - contact:(nullable OWSContact *)contact NS_UNAVAILABLE; + contactShare:(nullable OWSContact *)contact NS_UNAVAILABLE; - (instancetype)initWithCoder:(NSCoder *)coder NS_DESIGNATED_INITIALIZER; diff --git a/SignalServiceKit/src/Messages/Interactions/TSInfoMessage.m b/SignalServiceKit/src/Messages/Interactions/TSInfoMessage.m index 2e5664f4f..4ee76bb4d 100644 --- a/SignalServiceKit/src/Messages/Interactions/TSInfoMessage.m +++ b/SignalServiceKit/src/Messages/Interactions/TSInfoMessage.m @@ -53,7 +53,7 @@ NSUInteger TSInfoMessageSchemaVersion = 1; expiresInSeconds:0 expireStartedAt:0 quotedMessage:nil - contact:nil]; + contactShare:nil]; if (!self) { return self; diff --git a/SignalServiceKit/src/Messages/Interactions/TSMessage.h b/SignalServiceKit/src/Messages/Interactions/TSMessage.h index fa4c6afda..23a4eff4a 100644 --- a/SignalServiceKit/src/Messages/Interactions/TSMessage.h +++ b/SignalServiceKit/src/Messages/Interactions/TSMessage.h @@ -25,7 +25,7 @@ NS_ASSUME_NONNULL_BEGIN @property (nonatomic, readonly) uint64_t expiresAt; @property (nonatomic, readonly) BOOL isExpiringMessage; @property (nonatomic, readonly, nullable) TSQuotedMessage *quotedMessage; -@property (nonatomic, readonly, nullable) OWSContact *contact; +@property (nonatomic, readonly, nullable) OWSContact *contactShare; - (instancetype)initInteractionWithTimestamp:(uint64_t)timestamp inThread:(TSThread *)thread NS_UNAVAILABLE; @@ -36,7 +36,7 @@ NS_ASSUME_NONNULL_BEGIN expiresInSeconds:(uint32_t)expiresInSeconds expireStartedAt:(uint64_t)expireStartedAt quotedMessage:(nullable TSQuotedMessage *)quotedMessage - contact:(nullable OWSContact *)contact NS_DESIGNATED_INITIALIZER; + contactShare:(nullable OWSContact *)contactShare NS_DESIGNATED_INITIALIZER; - (nullable instancetype)initWithCoder:(NSCoder *)coder NS_DESIGNATED_INITIALIZER; diff --git a/SignalServiceKit/src/Messages/Interactions/TSMessage.m b/SignalServiceKit/src/Messages/Interactions/TSMessage.m index 806330ca2..1ce7fc29c 100644 --- a/SignalServiceKit/src/Messages/Interactions/TSMessage.m +++ b/SignalServiceKit/src/Messages/Interactions/TSMessage.m @@ -66,7 +66,7 @@ static const NSUInteger OWSMessageSchemaVersion = 4; expiresInSeconds:(uint32_t)expiresInSeconds expireStartedAt:(uint64_t)expireStartedAt quotedMessage:(nullable TSQuotedMessage *)quotedMessage - contact:(nullable OWSContact *)contact + contactShare:(nullable OWSContact *)contactShare { self = [super initInteractionWithTimestamp:timestamp inThread:thread]; @@ -83,7 +83,7 @@ static const NSUInteger OWSMessageSchemaVersion = 4; [self updateExpiresAt]; _receivedAtTimestamp = [NSDate ows_millisecondTimeStamp]; _quotedMessage = quotedMessage; - _contact = contact; + _contactShare = contactShare; return self; } @@ -261,7 +261,7 @@ static const NSUInteger OWSMessageSchemaVersion = 4; return bodyDescription; } else if (attachmentDescription.length > 0) { return attachmentDescription; - } else if (self.contact) { + } else if (self.contactShare) { // TODO: Include properly formatted name. return @"👤"; } else { diff --git a/SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.h b/SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.h index 84b8585b8..2c466c898 100644 --- a/SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.h +++ b/SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.h @@ -75,7 +75,7 @@ typedef NS_ENUM(NSInteger, TSGroupMetaMessage) { expiresInSeconds:(uint32_t)expiresInSeconds expireStartedAt:(uint64_t)expireStartedAt quotedMessage:(nullable TSQuotedMessage *)quotedMessage - contact:(nullable OWSContact *)contact NS_UNAVAILABLE; + contactShare:(nullable OWSContact *)contactShare NS_UNAVAILABLE; - (instancetype)initOutgoingMessageWithTimestamp:(uint64_t)timestamp inThread:(nullable TSThread *)thread @@ -86,7 +86,7 @@ typedef NS_ENUM(NSInteger, TSGroupMetaMessage) { isVoiceMessage:(BOOL)isVoiceMessage groupMetaMessage:(TSGroupMetaMessage)groupMetaMessage quotedMessage:(nullable TSQuotedMessage *)quotedMessage - contact:(nullable OWSContact *)contact NS_DESIGNATED_INITIALIZER; + contactShare:(nullable OWSContact *)contactShare NS_DESIGNATED_INITIALIZER; - (instancetype)initWithCoder:(NSCoder *)coder NS_DESIGNATED_INITIALIZER; diff --git a/SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.m b/SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.m index dd01766d0..396d0d9f2 100644 --- a/SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.m +++ b/SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.m @@ -245,7 +245,7 @@ NSString *NSStringForOutgoingMessageRecipientState(OWSOutgoingMessageRecipientSt isVoiceMessage:NO groupMetaMessage:TSGroupMessageUnspecified quotedMessage:quotedMessage - contact:nil]; + contactShare:nil]; } + (instancetype)outgoingMessageInThread:(nullable TSThread *)thread @@ -260,7 +260,7 @@ NSString *NSStringForOutgoingMessageRecipientState(OWSOutgoingMessageRecipientSt isVoiceMessage:NO groupMetaMessage:groupMetaMessage quotedMessage:nil - contact:nil]; + contactShare:nil]; } - (instancetype)initOutgoingMessageWithTimestamp:(uint64_t)timestamp @@ -272,7 +272,7 @@ NSString *NSStringForOutgoingMessageRecipientState(OWSOutgoingMessageRecipientSt isVoiceMessage:(BOOL)isVoiceMessage groupMetaMessage:(TSGroupMetaMessage)groupMetaMessage quotedMessage:(nullable TSQuotedMessage *)quotedMessage - contact:(nullable OWSContact *)contact + contactShare:(nullable OWSContact *)contactShare { self = [super initMessageWithTimestamp:timestamp inThread:thread @@ -281,7 +281,7 @@ NSString *NSStringForOutgoingMessageRecipientState(OWSOutgoingMessageRecipientSt expiresInSeconds:expiresInSeconds expireStartedAt:expireStartedAt quotedMessage:quotedMessage - contact:contact]; + contactShare:contactShare]; if (!self) { return self; } @@ -794,8 +794,9 @@ NSString *NSStringForOutgoingMessageRecipientState(OWSOutgoingMessageRecipientSt } // Contact Share - if (self.contact) { - OWSSignalServiceProtosDataMessageContact *_Nullable contactProto = [OWSContacts protoForContact:self.contact]; + if (self.contactShare) { + OWSSignalServiceProtosDataMessageContact *_Nullable contactProto = + [OWSContacts protoForContact:self.contactShare]; if (contactProto) { [builder addContact:contactProto]; } diff --git a/SignalServiceKit/src/Messages/OWSMessageManager.m b/SignalServiceKit/src/Messages/OWSMessageManager.m index 23a6d3438..b437549cf 100644 --- a/SignalServiceKit/src/Messages/OWSMessageManager.m +++ b/SignalServiceKit/src/Messages/OWSMessageManager.m @@ -1014,7 +1014,7 @@ NS_ASSUME_NONNULL_BEGIN attachmentIds:attachmentIds expiresInSeconds:dataMessage.expireTimer quotedMessage:quotedMessage - contact:contact]; + contactShare:contact]; [self finalizeIncomingMessage:incomingMessage thread:oldGroupThread @@ -1059,7 +1059,7 @@ NS_ASSUME_NONNULL_BEGIN attachmentIds:attachmentIds expiresInSeconds:dataMessage.expireTimer quotedMessage:quotedMessage - contact:contact]; + contactShare:contact]; [self finalizeIncomingMessage:incomingMessage thread:thread diff --git a/SignalServiceKit/src/Messages/OWSMessageSender.m b/SignalServiceKit/src/Messages/OWSMessageSender.m index 70f6a2c14..5d57b862b 100644 --- a/SignalServiceKit/src/Messages/OWSMessageSender.m +++ b/SignalServiceKit/src/Messages/OWSMessageSender.m @@ -1166,7 +1166,7 @@ NSString *const OWSMessageSenderRateLimitedException = @"RateLimitedException"; attachmentIds:attachmentIds expiresInSeconds:outgoingMessage.expiresInSeconds quotedMessage:outgoingMessage.quotedMessage - contact:outgoingMessage.contact]; + contactShare:outgoingMessage.contactShare]; [incomingMessage saveWithTransaction:transaction]; }]; } diff --git a/SignalServiceKit/src/Messages/OWSOutgoingCallMessage.m b/SignalServiceKit/src/Messages/OWSOutgoingCallMessage.m index e85f3dd77..9867be0df 100644 --- a/SignalServiceKit/src/Messages/OWSOutgoingCallMessage.m +++ b/SignalServiceKit/src/Messages/OWSOutgoingCallMessage.m @@ -31,7 +31,7 @@ NS_ASSUME_NONNULL_BEGIN isVoiceMessage:NO groupMetaMessage:TSGroupMessageUnspecified quotedMessage:nil - contact:nil]; + contactShare:nil]; if (!self) { return self; } diff --git a/SignalServiceKit/src/Messages/OWSOutgoingNullMessage.m b/SignalServiceKit/src/Messages/OWSOutgoingNullMessage.m index f5321b735..05807fb69 100644 --- a/SignalServiceKit/src/Messages/OWSOutgoingNullMessage.m +++ b/SignalServiceKit/src/Messages/OWSOutgoingNullMessage.m @@ -33,7 +33,7 @@ NS_ASSUME_NONNULL_BEGIN isVoiceMessage:NO groupMetaMessage:TSGroupMessageUnspecified quotedMessage:nil - contact:nil]; + contactShare:nil]; if (!self) { return self; } diff --git a/SignalServiceKit/src/Messages/OWSProfileKeyMessage.m b/SignalServiceKit/src/Messages/OWSProfileKeyMessage.m index 8a0d3eae6..43e619666 100644 --- a/SignalServiceKit/src/Messages/OWSProfileKeyMessage.m +++ b/SignalServiceKit/src/Messages/OWSProfileKeyMessage.m @@ -23,7 +23,7 @@ NS_ASSUME_NONNULL_BEGIN isVoiceMessage:NO groupMetaMessage:TSGroupMessageUnspecified quotedMessage:nil - contact:nil]; + contactShare:nil]; } - (BOOL)shouldBeSaved