session-ios/SignalServiceKit/src/Util/OWSDispatch.h

//
//  Copyright (c) 2017 Open Whisper Systems. All rights reserved.
//

NS_ASSUME_NONNULL_BEGIN

@interface OWSDispatch : NSObject

/**
 * Attachment downloading
 */
+ (dispatch_queue_t)attachmentsQueue;

/**
 * Signal protocol session state must be coordinated on a serial queue. This is sometimes used synchronously,
 * so never dispatching sync *from* this queue to avoid deadlock.
 */
+ (dispatch_queue_t)sessionStoreQueue;

/**
 * Serial message sending queue
 */
+ (dispatch_queue_t)sendingQueue;

@end

// This macro is intended for use in Objective-C.
#define OWSAssertIsOnMainThread() OWSCAssert([NSThread isMainThread])

// This function is intended for use in Swift.
void AssertIsOnMainThread(void);

NS_ASSUME_NONNULL_END
Prevent session corruption by using same queue for encrypt vs. decrypt // FREEBIE 9 years ago			`//`
			`// Copyright (c) 2017 Open Whisper Systems. All rights reserved.`
			`//`
Explain send failures for text and media messages Motivation ---------- We were often swallowing errors or yielding generic errors when it would be better to provide specific errors. We also didn't create an attachment when attachments failed to send, making it impossible to show the user what was happening with an in-progress or failed attachment. Primary Changes --------------- - Funnel all message sending through MessageSender, and remove message sending from MessagesManager. - Record most recent sending error so we can expose it in the UI - Can resend attachments. - Update message status for attachments, just like text messages - Extracted UploadingService from MessagesManager - Saving attachment stream before uploading gives uniform API for send vs. resend - update status for downloading transcript attachments - TSAttachments have a local id, separate from the server allocated id This allows us to save the attachment before the allocation request. Which is is good because: 1. can show feedback to user faster. 2. allows us to show an error when allocation fails. Code Cleanup ------------ - Replaced a lot of global singleton access with injected dependencies to make for easier testing. - Never save group meta messages. Rather than checking before (hopefully) every save, do it in the save method. - Don't use callbacks for sync code. - Handle errors on writing attachment data - Fix old long broken tests that weren't even running. =( - Removed dead code - Use constants vs define - Port flaky travis fixes from Signal-iOS // FREEBIE 9 years ago
			`NS_ASSUME_NONNULL_BEGIN`

			`@interface OWSDispatch : NSObject`

Prevent session corruption by using same queue for encrypt vs. decrypt // FREEBIE 9 years ago			`/**`
			`* Attachment downloading`
			`*/`
Explain send failures for text and media messages Motivation ---------- We were often swallowing errors or yielding generic errors when it would be better to provide specific errors. We also didn't create an attachment when attachments failed to send, making it impossible to show the user what was happening with an in-progress or failed attachment. Primary Changes --------------- - Funnel all message sending through MessageSender, and remove message sending from MessagesManager. - Record most recent sending error so we can expose it in the UI - Can resend attachments. - Update message status for attachments, just like text messages - Extracted UploadingService from MessagesManager - Saving attachment stream before uploading gives uniform API for send vs. resend - update status for downloading transcript attachments - TSAttachments have a local id, separate from the server allocated id This allows us to save the attachment before the allocation request. Which is is good because: 1. can show feedback to user faster. 2. allows us to show an error when allocation fails. Code Cleanup ------------ - Replaced a lot of global singleton access with injected dependencies to make for easier testing. - Never save group meta messages. Rather than checking before (hopefully) every save, do it in the save method. - Don't use callbacks for sync code. - Handle errors on writing attachment data - Fix old long broken tests that weren't even running. =( - Removed dead code - Use constants vs define - Port flaky travis fixes from Signal-iOS // FREEBIE 9 years ago			`+ (dispatch_queue_t)attachmentsQueue;`

Prevent session corruption by using same queue for encrypt vs. decrypt // FREEBIE 9 years ago			`/**`
			`* Signal protocol session state must be coordinated on a serial queue. This is sometimes used synchronously,`
Narrow the scope of code run on SessionCipher queue And run all non-cipher code on the main thread. Note: Running encryption on the sessionCipher queue is more about serializing access to session mutations than it is about any performance gains. // FREEBIE 9 years ago			`* so never dispatching sync from this queue to avoid deadlock.`
Prevent session corruption by using same queue for encrypt vs. decrypt // FREEBIE 9 years ago			`*/`
rename sessionCipher to sessionStoreQueue // FREEBIE 9 years ago			`+ (dispatch_queue_t)sessionStoreQueue;`
Prevent session corruption by using same queue for encrypt vs. decrypt // FREEBIE 9 years ago
			`/**`
			`* Serial message sending queue`
			`*/`
Explain send failures for text and media messages Motivation ---------- We were often swallowing errors or yielding generic errors when it would be better to provide specific errors. We also didn't create an attachment when attachments failed to send, making it impossible to show the user what was happening with an in-progress or failed attachment. Primary Changes --------------- - Funnel all message sending through MessageSender, and remove message sending from MessagesManager. - Record most recent sending error so we can expose it in the UI - Can resend attachments. - Update message status for attachments, just like text messages - Extracted UploadingService from MessagesManager - Saving attachment stream before uploading gives uniform API for send vs. resend - update status for downloading transcript attachments - TSAttachments have a local id, separate from the server allocated id This allows us to save the attachment before the allocation request. Which is is good because: 1. can show feedback to user faster. 2. allows us to show an error when allocation fails. Code Cleanup ------------ - Replaced a lot of global singleton access with injected dependencies to make for easier testing. - Never save group meta messages. Rather than checking before (hopefully) every save, do it in the save method. - Don't use callbacks for sync code. - Handle errors on writing attachment data - Fix old long broken tests that weren't even running. =( - Removed dead code - Use constants vs define - Port flaky travis fixes from Signal-iOS // FREEBIE 9 years ago			`+ (dispatch_queue_t)sendingQueue;`

			`@end`

Respond to CR. 8 years ago			`// This macro is intended for use in Objective-C.`
			`#define OWSAssertIsOnMainThread() OWSCAssert([NSThread isMainThread])`

			`// This function is intended for use in Swift.`
Proper function prototypes // FREEBIE 8 years ago			`void AssertIsOnMainThread(void);`
Add assert macro that can be used in free functions. // FREEBIE 9 years ago
Explain send failures for text and media messages Motivation ---------- We were often swallowing errors or yielding generic errors when it would be better to provide specific errors. We also didn't create an attachment when attachments failed to send, making it impossible to show the user what was happening with an in-progress or failed attachment. Primary Changes --------------- - Funnel all message sending through MessageSender, and remove message sending from MessagesManager. - Record most recent sending error so we can expose it in the UI - Can resend attachments. - Update message status for attachments, just like text messages - Extracted UploadingService from MessagesManager - Saving attachment stream before uploading gives uniform API for send vs. resend - update status for downloading transcript attachments - TSAttachments have a local id, separate from the server allocated id This allows us to save the attachment before the allocation request. Which is is good because: 1. can show feedback to user faster. 2. allows us to show an error when allocation fails. Code Cleanup ------------ - Replaced a lot of global singleton access with injected dependencies to make for easier testing. - Never save group meta messages. Rather than checking before (hopefully) every save, do it in the save method. - Don't use callbacks for sync code. - Handle errors on writing attachment data - Fix old long broken tests that weren't even running. =( - Removed dead code - Use constants vs define - Port flaky travis fixes from Signal-iOS // FREEBIE 9 years ago			`NS_ASSUME_NONNULL_END`