session-ios/SignalServiceKit/src/Util/OWSDispatch.m

//
//  Copyright (c) 2017 Open Whisper Systems. All rights reserved.
//

#import "OWSDispatch.h"

NS_ASSUME_NONNULL_BEGIN

@implementation OWSDispatch

+ (dispatch_queue_t)attachmentsQueue
{
    static dispatch_once_t onceToken;
    static dispatch_queue_t queue;
    dispatch_once(&onceToken, ^{
        queue = dispatch_queue_create("org.whispersystems.signal.attachments", NULL);
    });
    return queue;
}

+ (dispatch_queue_t)sessionStoreQueue
{
    static dispatch_once_t onceToken;
    static dispatch_queue_t queue;
    dispatch_once(&onceToken, ^{
        queue = dispatch_queue_create("org.whispersystems.signal.sessionStoreQueue", NULL);
    });
    return queue;
}

+ (dispatch_queue_t)sendingQueue
{
    static dispatch_once_t onceToken;
    static dispatch_queue_t queue;
    dispatch_once(&onceToken, ^{
        queue = dispatch_queue_create("org.whispersystems.signal.sendQueue", NULL);
    });
    return queue;
}

@end

void AssertIsOnMainThread() {
    OWSCAssert([NSThread isMainThread]);
}

NS_ASSUME_NONNULL_END
Prevent session corruption by using same queue for encrypt vs. decrypt // FREEBIE 9 years ago			`//`
			`// Copyright (c) 2017 Open Whisper Systems. All rights reserved.`
			`//`
Explain send failures for text and media messages Motivation ---------- We were often swallowing errors or yielding generic errors when it would be better to provide specific errors. We also didn't create an attachment when attachments failed to send, making it impossible to show the user what was happening with an in-progress or failed attachment. Primary Changes --------------- - Funnel all message sending through MessageSender, and remove message sending from MessagesManager. - Record most recent sending error so we can expose it in the UI - Can resend attachments. - Update message status for attachments, just like text messages - Extracted UploadingService from MessagesManager - Saving attachment stream before uploading gives uniform API for send vs. resend - update status for downloading transcript attachments - TSAttachments have a local id, separate from the server allocated id This allows us to save the attachment before the allocation request. Which is is good because: 1. can show feedback to user faster. 2. allows us to show an error when allocation fails. Code Cleanup ------------ - Replaced a lot of global singleton access with injected dependencies to make for easier testing. - Never save group meta messages. Rather than checking before (hopefully) every save, do it in the save method. - Don't use callbacks for sync code. - Handle errors on writing attachment data - Fix old long broken tests that weren't even running. =( - Removed dead code - Use constants vs define - Port flaky travis fixes from Signal-iOS // FREEBIE 9 years ago
			`#import "OWSDispatch.h"`

			`NS_ASSUME_NONNULL_BEGIN`

			`@implementation OWSDispatch`

			`+ (dispatch_queue_t)attachmentsQueue`
			`{`
			`static dispatch_once_t onceToken;`
			`static dispatch_queue_t queue;`
			`dispatch_once(&onceToken, ^{`
			`queue = dispatch_queue_create("org.whispersystems.signal.attachments", NULL);`
			`});`
			`return queue;`
			`}`

rename sessionCipher to sessionStoreQueue // FREEBIE 9 years ago			`+ (dispatch_queue_t)sessionStoreQueue`
Prevent session corruption by using same queue for encrypt vs. decrypt // FREEBIE 9 years ago			`{`
			`static dispatch_once_t onceToken;`
			`static dispatch_queue_t queue;`
			`dispatch_once(&onceToken, ^{`
rename sessionCipher to sessionStoreQueue // FREEBIE 9 years ago			`queue = dispatch_queue_create("org.whispersystems.signal.sessionStoreQueue", NULL);`
Prevent session corruption by using same queue for encrypt vs. decrypt // FREEBIE 9 years ago			`});`
			`return queue;`
			`}`

Explain send failures for text and media messages Motivation ---------- We were often swallowing errors or yielding generic errors when it would be better to provide specific errors. We also didn't create an attachment when attachments failed to send, making it impossible to show the user what was happening with an in-progress or failed attachment. Primary Changes --------------- - Funnel all message sending through MessageSender, and remove message sending from MessagesManager. - Record most recent sending error so we can expose it in the UI - Can resend attachments. - Update message status for attachments, just like text messages - Extracted UploadingService from MessagesManager - Saving attachment stream before uploading gives uniform API for send vs. resend - update status for downloading transcript attachments - TSAttachments have a local id, separate from the server allocated id This allows us to save the attachment before the allocation request. Which is is good because: 1. can show feedback to user faster. 2. allows us to show an error when allocation fails. Code Cleanup ------------ - Replaced a lot of global singleton access with injected dependencies to make for easier testing. - Never save group meta messages. Rather than checking before (hopefully) every save, do it in the save method. - Don't use callbacks for sync code. - Handle errors on writing attachment data - Fix old long broken tests that weren't even running. =( - Removed dead code - Use constants vs define - Port flaky travis fixes from Signal-iOS // FREEBIE 9 years ago			`+ (dispatch_queue_t)sendingQueue`
			`{`
			`static dispatch_once_t onceToken;`
			`static dispatch_queue_t queue;`
			`dispatch_once(&onceToken, ^{`
			`queue = dispatch_queue_create("org.whispersystems.signal.sendQueue", NULL);`
			`});`
			`return queue;`
			`}`

			`@end`

Add assert macro that can be used in free functions. // FREEBIE 9 years ago			`void AssertIsOnMainThread() {`
			`OWSCAssert([NSThread isMainThread]);`
			`}`

Explain send failures for text and media messages Motivation ---------- We were often swallowing errors or yielding generic errors when it would be better to provide specific errors. We also didn't create an attachment when attachments failed to send, making it impossible to show the user what was happening with an in-progress or failed attachment. Primary Changes --------------- - Funnel all message sending through MessageSender, and remove message sending from MessagesManager. - Record most recent sending error so we can expose it in the UI - Can resend attachments. - Update message status for attachments, just like text messages - Extracted UploadingService from MessagesManager - Saving attachment stream before uploading gives uniform API for send vs. resend - update status for downloading transcript attachments - TSAttachments have a local id, separate from the server allocated id This allows us to save the attachment before the allocation request. Which is is good because: 1. can show feedback to user faster. 2. allows us to show an error when allocation fails. Code Cleanup ------------ - Replaced a lot of global singleton access with injected dependencies to make for easier testing. - Never save group meta messages. Rather than checking before (hopefully) every save, do it in the save method. - Don't use callbacks for sync code. - Handle errors on writing attachment data - Fix old long broken tests that weren't even running. =( - Removed dead code - Use constants vs define - Port flaky travis fixes from Signal-iOS // FREEBIE 9 years ago			`NS_ASSUME_NONNULL_END`