session-ios/src/Util/OWSError.h

//  Copyright © 2016 Open Whisper Systems. All rights reserved.

NS_ASSUME_NONNULL_BEGIN

extern NSString *const OWSSignalServiceKitErrorDomain;

typedef NS_ENUM(NSInteger, OWSErrorCode) {
    OWSErrorCodeInvalidMethodParameters = 11,
    OWSErrorCodeUnableToProcessServerResponse = 12,
    OWSErrorCodeFailedToDecodeJson = 13,
    OWSErrorCodeFailedToEncodeJson = 14,
    OWSErrorCodeFailedToDecodeQR = 15,
    OWSErrorCodePrivacyVerificationFailure = 20,
    OWSErrorCodeUntrustedIdentityKey = 25,
    OWSErrorCodeFailedToSendOutgoingMessage = 30,
    OWSErrorCodeFailedToDecryptMessage = 100
};

extern NSError *OWSErrorWithCodeDescription(OWSErrorCode code, NSString *description);
extern NSError *OWSErrorMakeUnableToProcessServerResponseError();
extern NSError *OWSErrorMakeFailedToSendOutgoingMessageError();
extern NSError *OWSErrorMakeNoSuchSignalRecipientError();

NS_ASSUME_NONNULL_END
Don't crash when contact lookup is given nil contact // FREEBIE 9 years ago			`// Copyright © 2016 Open Whisper Systems. All rights reserved.`

			`NS_ASSUME_NONNULL_BEGIN`

			`extern NSString *const OWSSignalServiceKitErrorDomain;`

Device manager // FREEBIE 9 years ago			`typedef NS_ENUM(NSInteger, OWSErrorCode) {`
			`OWSErrorCodeInvalidMethodParameters = 11,`
			`OWSErrorCodeUnableToProcessServerResponse = 12,`
			`OWSErrorCodeFailedToDecodeJson = 13,`
New fingerprint format In coordination with Desktop and Android, iOS will be using all-numeric fingerprints, aka "Safety Numbers". Furthermore, the concept of verifying one identity and then the other has been removed. Instead we ask users to exchange a single number, or scan a single QR code. These credentials are built by combining the users identities. // FREEBIE 9 years ago			`OWSErrorCodeFailedToEncodeJson = 14,`
			`OWSErrorCodeFailedToDecodeQR = 15,`
Don't start expiration timer until message is sent. Started extracting a MessageSender class from TSMessagesManager+send for easier testability and in hopes of further slimming down that son of a gun. // FREEBIE 9 years ago			`OWSErrorCodePrivacyVerificationFailure = 20,`
Handle group keychange error (#50) // FREEBIE 9 years ago			`OWSErrorCodeUntrustedIdentityKey = 25,`
Explain send failures for text and media messages Motivation ---------- We were often swallowing errors or yielding generic errors when it would be better to provide specific errors. We also didn't create an attachment when attachments failed to send, making it impossible to show the user what was happening with an in-progress or failed attachment. Primary Changes --------------- - Funnel all message sending through MessageSender, and remove message sending from MessagesManager. - Record most recent sending error so we can expose it in the UI - Can resend attachments. - Update message status for attachments, just like text messages - Extracted UploadingService from MessagesManager - Saving attachment stream before uploading gives uniform API for send vs. resend - update status for downloading transcript attachments - TSAttachments have a local id, separate from the server allocated id This allows us to save the attachment before the allocation request. Which is is good because: 1. can show feedback to user faster. 2. allows us to show an error when allocation fails. Code Cleanup ------------ - Replaced a lot of global singleton access with injected dependencies to make for easier testing. - Never save group meta messages. Rather than checking before (hopefully) every save, do it in the save method. - Don't use callbacks for sync code. - Handle errors on writing attachment data - Fix old long broken tests that weren't even running. =( - Removed dead code - Use constants vs define - Port flaky travis fixes from Signal-iOS // FREEBIE 9 years ago			`OWSErrorCodeFailedToSendOutgoingMessage = 30,`
			`OWSErrorCodeFailedToDecryptMessage = 100`
Device manager // FREEBIE 9 years ago			`};`

			`extern NSError OWSErrorWithCodeDescription(OWSErrorCode code, NSString description);`
Explain send failures for text and media messages Motivation ---------- We were often swallowing errors or yielding generic errors when it would be better to provide specific errors. We also didn't create an attachment when attachments failed to send, making it impossible to show the user what was happening with an in-progress or failed attachment. Primary Changes --------------- - Funnel all message sending through MessageSender, and remove message sending from MessagesManager. - Record most recent sending error so we can expose it in the UI - Can resend attachments. - Update message status for attachments, just like text messages - Extracted UploadingService from MessagesManager - Saving attachment stream before uploading gives uniform API for send vs. resend - update status for downloading transcript attachments - TSAttachments have a local id, separate from the server allocated id This allows us to save the attachment before the allocation request. Which is is good because: 1. can show feedback to user faster. 2. allows us to show an error when allocation fails. Code Cleanup ------------ - Replaced a lot of global singleton access with injected dependencies to make for easier testing. - Never save group meta messages. Rather than checking before (hopefully) every save, do it in the save method. - Don't use callbacks for sync code. - Handle errors on writing attachment data - Fix old long broken tests that weren't even running. =( - Removed dead code - Use constants vs define - Port flaky travis fixes from Signal-iOS // FREEBIE 9 years ago			`extern NSError *OWSErrorMakeUnableToProcessServerResponseError();`
			`extern NSError *OWSErrorMakeFailedToSendOutgoingMessageError();`
Better error messages when failure to send due to: - no internet - unregistered recipient // FREEBIE 9 years ago			`extern NSError *OWSErrorMakeNoSuchSignalRecipientError();`
Don't crash when contact lookup is given nil contact // FREEBIE 9 years ago
			`NS_ASSUME_NONNULL_END`