* Update spectron to fix linux CI runs
* Point test-release grunt task at release folder
* Ensure that build folders of socks/smart-buffer are in build
* AppVeyor: windows build output folder is now release
* Travis: Force build output to release directory
* 'master' of https://github.com/signalapp/Signal-Desktop: (38 commits)
v1.17.0
v1.17.0-beta.4
Ensure that blue group avatars are preserved in dark theme
Android theme: Incoming quotes take color from containing message
Conversations have blue avatar backgrounds if no image provided
Fix lint errors
Add ca language
inboxView: Ensure Conversation exists for our own number
Ensure that file is not attached if we've filtered it
v1.17.0-beta.3
Localization updates
v1.16.3
Lint fixes
Lint fixes
Better handle large numbers of messages in cache on startup
Keep object stores after conversations migrate to SQLCipher
Longer timeout for orphaned file cleanup
Tests and increase consistency for isFileDangerous calls
Longer timeout for orphaned file cleanup
v1.17.0-beta.2
...
# Conflicts:
# background.html
# package.json
Skeleton calcPoW function that prepares payload for hashingFunction to increment Uint8Array nonce
Util function for converting a number to its Uint8Array representation
Actually perform calculate PoW nonce for every message
Adding bytebuffer as dependency and updated package-lock
Move PoW to new file and execute it in child process
TODO: Move send message logic to callback after child process has finished calculating the PoW
Refactored nonce calculation to function to be awaited
More readable timestamp grab plus converted to seconds
Nonce is now returned as a base64 string and included in request header
Also converted timestamp and ttl to string when including them in the header
Added a couple comments and tidied up some nonce logic
Quite a few other fixes, including:
- Sending to contact with no avatar yet (not synced from mobile)
- Left pane doesn't update quickly or at all on new message
- Left pane doesn't show sent or error status
Also:
- Contributing.md: Ensure set of linux dev dependencies is complete
Also:
- New schema version 8 with video/image thumbnails, screenshots, sizes
- Upgrade messages not at current schema version when loading messages
to show in conversation
- New MessageDetail react component
- New ConversationHeader react component
UI now in separate renderer:
- the permissions popup
- settings dialog
- debug log dialog
- about window
Couple bug fixes:
- About Window: Fix 'escape' to close window
- Remove outdated dist/copy tasks from Gruntfile
Eslintified settings_view.js
Biggest changes forced by this: alt tags for all images, resulting in
new strings added to messages.json, and a new i18n paramter/prop added
in a plot of places.
Another change of note is that there are two new tslint.json files under
ts/test and ts/styleguide to relax our rules a bit there. This required
a change to our package.json script, as manually specifying the config
file there made it ignore our tslint.json files in subdirectories
* Remove extra parenthesis causing warnings on latest chromium
* Update to electron 2.0.1
* Move all @types dependencies to devDependencies
* Update electron-builder/electron-updater
* Update to Node.js 8.9.3 to match Electron 2.0.1
Notification Improvements (#2364)
- Fixed: The change for production didn't full make it into v1.11.0-beta.1 - this change restores the code which removes the old notification when we add a new one
- Fixed: Notifications could be orphaned in notification center if they were added/removed quickly
- Fixed: Notifications weren't removed properly when read on a linked device
Dev: Better logging when we receive a read sync from a linked device (#2364)
Feature: Receive contact (#2349, #2359)
Fixed: Sometimes clicks on quoted message wouldn't work (#2350)
Fixed: In dark theme, it was hard to see a message's triple-dot menu on hover - thanks @PunkChameleon (#2334)
Fixed: Unsupported image and video types were missing from media pane (#2351)
Fixed: On small screens, the media lightbox view would show media off-screen (#2351)
Notification improvements
- Remove all on remote read, on focus, on exit
- Show multi-message notifications like '5 new messages'
Media Gallery: A number of small visual fixes (#2351)
Emoji pane: Can now dismiss it by pressing escape key - thanks @tommypacker (#2354, #2357)
Update translations (#2328, #2352)
Dev:
- Windows 7: Use Electron-native notifications (#2338, #2330)
- Improve Logging For Disappearing Messages (#2332)
- Prettier: Continue expanding its coverage of app (#2339, #2324)
- Document Translations Setup + Remove Unused Strings (#2329)
- Make Protocol Buffers available to commonjs code (#2347)
This does not work with `ArrayBuffer` out of the box and will need to be
investigated and tested more before switching.
Some APIs also seemed to have changed:
- Before (OOP): `new textsecure.protobuf.WebSocketMessage(…).encode();`
- After (functional):
```
textsecure.protobuf.WebSocketMessage.encode(
new textsecure.protobuf.WebSocketMessage(…)
);
```
This reverts commit d758119d9de4f99742ea941e86180b1d600c2f22.
We missed a couple directories with previous attempts to turn this on
globally: app/ and libtextsecure/
Not to mention files in places we didn't expect: ts files that weren't
in the ts directory!
This turns prettier on for every file we care about (js, ts, tsx, md)
everywhere in the project but for a few key parts.
Linux: deb (dropped zip)
Mac: zip (dropped dmg)
Windows: exe (dropped zip)
We can always re-add if people are relying on these things. But our
download links all point to these assets, so we'll generate and upload
only these for now.
Media Gallery showing all attachments in a given conversation (#2291, previous: #2236)
Quotes:
- Show 'You' in Android theme instead of your own contact name (#2312)
- Show thumbnails for quotes of messages with video attachments (#2293)
Video attachments: show first frame preview in composition area (#2293)
Increase speed of migration to move attachments to disk from database (#2314)
Dev:
- Add comments clarifying our mechanisms for stripping EXIF info (#2313)
- Move to prettierjs to format our code (#2303)
- Fix break in styleguide; make filesize/Signal.Util.GoogleChrome available (#2302)
- Remove duplicate entry from .gitignore (#2271)
Send quoted replies via hover menu on message (#2284, #2292)
Fixed: Linking a new iOS device would not initially show iOS theme (#2284)
Fixed: In iOS theme, narrow images would result in a broken chat bubble (#2273, #2282)
Dev:
- Fix beta install instructions in readme for debian-based linux (#2262)
- Media Gallery: Phase 1 - currently disabled (#2236)
Receive quoted replies (#2244)
iOS theme: one bubble for both attachment and message contents (#2244)
Improve URL Auto-Linking In Messages (#2240)
Redact More Variants Of Paths In Stack Traces (#2229)
Fixed: Conversation message preview would sometimes continue to show after message disappeared (1206b3c448)
Dev: Introduce React, TypeScript, TSLint and React-StyleGuidist (#2219 and #2232)
Separate linting from testing as follows:
- `yarn jscs`: Run JSCS.
- `yarn jshint`: Run JSHint.
- `yarn lint`: Run all linters, i.e. ESLint, TSLint, JSHint, and JSHint.
- `yarn test-node`: Run Mocha tests in Node.js environment.
- `yarn test-electron`: Run tests in Electron environment via Grunt.
- `yarn test`: Run all tests.
CI
- Align Travis and AppVeyor scripts as much as possible.
- Run linting before tests to fail fast.
- Run Node.js (headless and fast) tests first.
- Run Electron tests last (Travis seems to require custom setup in `travis.sh`).
It only has the minimum required dependencies:
- `linkify-it`: Best-in-class link detection library with support for
Unicode/IDN.
- `escape-html`: Standalone dependency for escaping HTML.
- `uc.micro`: Standalone dependency of Unicode data files.
Quite a bit of change here.
First, the basics:
- New dependencies were added: react, typescript, tslint, and react-styleguidist
- A new npm script: transpile. It uses typescript to process .tsx files in js/react, putting .js files next to the original file. It's part of the watch functionality of grunt dev as well as the default task run with just grunt (used to build the app prior to release). A lighter-weight to get watch behavior when just working on React components is to run yarn transpile --watch.
- yarn run clean-transpile will remove generated .js files
Style guide via react-styleguidist. Example site: https://react-styleguidist.js.org/examples/basic/
- Start with yarn styleguide
- Component.md files right next to the .tsx file
- jsdoc-style comments are picked up and added to the generated part of the styleguide - the overall summary and a table listing methods and properties of the component
- It has hot-reloading!
- It uses webpack, which means that our app now pulls in webpack though we don't use it to generate anything for the production app.
- I did a bunch of work to enable the use of Backbone views in this context, which will allow us to move smoothly from the old world to the new. First, add all the permutations in the old way, and then slowly start to re-render those same views with React.
A bit of dependency cleanup to enable use in React components:
- moment was moved from our Bower dependencies to our npm dependencies, so it can be used in React components not running in a browser window.
- i18n was moved into the new commonjs format, so it can be used in React components even if window is not available.
Lastly, a bit of Gruntfile cleanup:
- Removal of Chrome App-era modifications of background.js
- Make jshint/jscs watch more targeted, since more and more we'll be using other tools
Split out test-specific and general utility react components too.
And moved our test/legacy* files for the Style Guide into a styleguide/
subdirectory of test/.
I think we'll be able to live in this directory structure for a while.
Update to electron 1.8.4 (#2186)
Migrate all attachments from IndexedDB to file system in the background (#2208, #2193, #2165, #2162, #2129)
Save attachments to disk when importing Chrome app export (#2212)
Fixed: Read receipts setting would not be synchronized along with re-link (#2218)
Fixed: Clicking conversation in left pane when already selected would remove focus on message composition field - thanks
@colefranz! (#2032)
Fixed: Searching for the phone number of an existing contact, then selecting 'start conversation' would erase contact details (#2191)
Fixed: Selecting Settings menu option multiple times would open multiple instances of settings view - thanks @navdeepsinghkhalsa (#2167)
Dev:
- Relax Node.js version requirements (#2203)
- Fix a few typos in documentation - thanks @Vinnl (#2171)
- Update issue template to mention that translation should be via Transifex (#2157)
Due to a number of hacks, the style guide can be used to show Backbone
views. This will allow a smooth path from the old way of doing things to
the new.
npm run transpile
Works on files under js/react/
Outputs files right next to the .tsx file
This is part of our `grunt dev` task, as well as the default grunt task,
which does everything else necessary to get a raw git checkout ready to
run.
Fixed: White block at bottom of conversation panel in iOS theme
(#2144 and #2153)
Fixed: Would attempt to rotate signed prekey every five seconds,
forever, after app discovers it is unlinked
(1c6d91b59c)
Dev:
- Introduce IndexedDB index on `messages` store tracking
`schemaVersion` (#2128)
- Preparation for encrypted backups
(cea42bde7d)
- Updates to structure of exported data - messages.zip, flat list of
attachments (6d8f4b7b6e)
Backup creates, in a target directory:
- An attachments folder, with all attachments, each named for their
parent message's id - a GUID. If there is more than one attachment
in a given message, each attachment beyond the first will end with
'-N', zero-indexed.
- A file named messages.zip. It contains exactly what went to disk in
the original export code, but zipped up.
Export is now only 'light,' and in this new messages.zip format.
Import supports both the new format and the old format. If the target
directory has a messages.zip file, we'll treat it as the new format.
Next up: Encrypting attachments and the messages.zip!
New option in settings: delete all application data
(383e02edc4)
Remove all configuration in database when we discover we are unlinked
(9acb189650)
Delete everything in database when we link with a different phone number
from previous link (9acb189650)
Windows: Delete all data on uninstall
(c8555974e4)
Dev:
- Switch to a new service for debug logs, since GitHub is retiring
anonymous gists (#2111)
- Redact file paths in anything that goes to the log on disk (#2110)
- When top-level process errors happen, don't show dialog with stack
trace (#2110)
- Add `nsp` to CI runs
(fd056e1b4c)
- Add eslint-plugin-mocha to disallow exclusive tests using *.only
(#2110)
The plan is to use this for our future HTTP needs as it is:
- modern
- promise based
- popular
- likely to support custom certificate authorities (CAs)
Chosen over the following alternatives:
- superagent (older, promises added later, potential lack of custom CA support)
- axios (no team experience with it; less popular than `got`)
- request (older, heavy-weight, promises not native)
- jQuery (old, trying to move away from jQuery altogether and move towards
declarative UIs)
- `fetch` (too low-level, no native timeout support)
Upgrade to the latest version of Electron, 1.8.2 (#2066)
Replace custom notification sound with system sound (#2108)
Update menus (#2078 and #2099)
- A few copy changes to make things clearer
- Settings now available via the File (Windows/Linux) or Signal
Desktop (macOS) OS menu
- Eliminate the triple-dot menu in the top-center of the screen
Fix: Hitting enter after entering device name on install would not move
to next screen (#2085)
Dev:
- Ensure consistent builds using `yarn --frozen-lockfile` (#2098)
- Update code to match eslint-enforced formatting (#2077)
- Upgrade to latest version of electron-builder and associated
packages (#2066 and #2097)
- [x] Removed ‘Restart Signal’ global menu item
- [x] Change _Click to create contact…_ to _Start conversation…_
- [x] Move global menu (top-left kebab) into OS menu bar,
i.e. **Settings** > **Preferences…**
- [x] Add tests for OS menu bar templates
- [x] Fix bug with **Window** menu on macOS when showing setup options
- [x] Use _Title Case_ for all OS menu bar menu items for consistency
commit dedf7c9af0de90980388559659df0d92a77b864c
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 16:53:42 2018 -0500
Use ‘Title Case’ to be consistent with OS menus
References:
- Apple:
- https://developer.apple.com/macos/human-interface-guidelines/menus/menu-anatomy/#menu-and-menu-item-titles
- https://developer.apple.com/library/content/documentation/FinalCutProX/Conceptual/FxPlugHIG/TextStyleGuidelines/TextStyleGuidelines.html#//apple_ref/doc/uid/TP40013782-CH6-SW1
- https://titlecaseconverter.com/
commit 3286da29b334bd4526c587b17707c2f230cec8f5
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 16:36:50 2018 -0500
Fix bug for macOS ‘Window’ menu with setup options
commit 236a23d1eafe2a16073394a27b9013298b682a25
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 16:27:46 2018 -0500
Test menus with included setup options
commit c5d5f5abb8d7f52d6a4aa182a86c92f7ddceade0
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 16:10:27 2018 -0500
Move settings (‘Preferences’) into OS-level menu
This reduces our reliance on custom UI until we have more design resources.
commit 027803f8f4983cffa443f0beff1854dcf541689b
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 16:02:56 2018 -0500
Prepare tests for menu with/without included setup
commit 9e2f006924b85eb249a8a1261c1c4dd1a706afa6
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 15:55:46 2018 -0500
Destructure `includeSetup`
commit 6b2a1eccdf724fd722e58415d2700da73942d9e8
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 15:55:14 2018 -0500
🔤 `createTemplate` `options`
commit c2fecba34b153fed106f414ed3347d46299f6fe5
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 12:49:55 2018 -0500
Test menu for Windows and Linux
commit 60281b1af9ad1f022cdbc40711ebd0b688a7355d
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 12:40:39 2018 -0500
Add `yarn run test-app` command
commit 1a0489919c0a97b03fe88196260fef894fb3d9e4
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 12:40:29 2018 -0500
Add test for `SignalMenu.createTemplate` on macOS
commit 9638b86c0f00f231e44562a5aa01626f0e5fdd8b
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 12:34:46 2018 -0500
Make `createTemplate` pure
Extracting `options.platform` makes it easier to test without having to
stub `process.platform`.
commit 9c26404892d7c9a7bd0199a9e8367a165a3b365c
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 11:47:39 2018 -0500
Extract `locale.load` `appLocale` & `logger` for testability
This allows us to run this code in a non-Electron environment, e.g. Node.js
Mocha test suite.
commit 710b22438df25c8d5e8431845a035c55ec8fc0b7
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 11:46:13 2018 -0500
🔤 npm scripts
commit 9ae22937fbce078f91443023b560b3c0468c1380
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 11:45:30 2018 -0500
Use 2-space indendation for `app` module tests
commit 22c26baf6159bd2e1f5a787c10e2260f09395329
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 11:22:55 2018 -0500
Prefer named exports
commit 9c9526195266ac77ac2ca04135a1e675f617dfd2
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 11:22:46 2018 -0500
🔤 Organize `require`s
commit 2f144d24d9e9a9ef72fe418996e3c911b304b00a
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Tue Feb 27 11:13:50 2018 -0500
Remove existing global hamburger menu
This will be replaced by a OS-level ‘Preferences’ menu.
commit f5adb374cb742e5f319ececda8ab6d8adee88d7e
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Mon Feb 26 18:40:54 2018 -0500
Remove ‘Restart Signal’ menu from settings
Apparently, this is a remnant from the Chrome web application.
commit d7a206bc8e67ef44022085e804ca040ed1b219f7
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Mon Feb 26 17:16:49 2018 -0500
Clarify label for starting a new conversation
When user a enters a number that is not a contact, we prompt them to start a new
conversation.
commit 715a4064367fb61d85c1a4f9d48261b2ce002435
Author: Daniel Gasienica <daniel@gasienica.ch>
Date: Mon Feb 26 16:46:26 2018 -0500
Use ‘Enter name or number’ as prompt’
This follows implementation of Android and recommendation from Alissa.
* Upgrade to Electron 1.8.2 / Node.js 8.2.1
* Update CI Node.js versions
* Make `engines` top-level property
This was accidentally included under `build` which is disallowed
by `electron-builder`.
* Refactor notification updates
Allows easier debugging through variable inspection.
* Use `appId` for Application User Model ID
Recommended in:
https://github.com/electron/electron/issues/10864#issuecomment-346229090
* Update `spectron` to 3.8.0
* Bump `electron-builder` based dependencies
* Use `config.extraMetadata` instead of `em`
Prevents `Unknown argument: em` error.
See: https://github.com/electron-userland/electron-builder/issues/2615
* Revert AUMID to be based on `packageJson.name`
In our build artifact `packageJson.build.appId` causes an NPE.
Note: This release is equivalent to v1.5.2
Fixed: If interrupted in the middle of an import, next registration
would leave that imported data in the database (#2072)
Fixed: In some cases on OSX, View menu would not have Debug Log option
(#2089)
Fixed: In import/registration flow, choosing View -> Debug Log would do
nothing (#2089)
Fixed: In some cases contact/group syncs would turn off disappearing
messages in all conversations (#2086)
Fixed: On initial setup, conversations with disappearing messages
enabled would be at the top of the conversation list (#2084)
Fixed: In some cases on OSX, View menu would not have Debug Log option (#2089)
Fixed: In import/registration flow, choosing View -> Debug Log would do nothing (#2089)
Fixed: In some cases contact/group syncs would turn off disappearing
messages in all conversations (#2086)
Fixed: On initial setup, conversations with disappearing messages
enabled would be at the top of the conversation list (#2084)
_Note: Includes fixes from 1.4.0-beta.1 (never released to production),
1.5.0-beta.1, and one additional pull request (#2072)_
Update electron to 1.7.12 (#2029)
New design for import and install flows (#2053)
Support for 'light' imports, which bring just messages, contacts and
groups (#2053, #2072)
Set conversation disappearing messages state and contact block state on
initial link (#1980)
'Restart' -> 'Restart Signal' button in update dialog, thanks @StevenXL
(#2024)
Fixed: If app started offline, conversations would not open (#2064)
Fixed: Attached images would sometimes show up rotated improperly (#2040)
Fixed: Uncaught Exception: TypeError; 'getSize' (#2061)
Fixed: File paths with special characters could be shown in misleading
way
Fixed: incoming messages sometimes didn't appear at all (#2050)
Fixed: 'Cannot find module ./app/locale' error popup when attempting to
start another instance of the app on Windows (#2017)
Fixed: Setting NODE_ENV environment variable to 'development' would
point it at staging servers (#2010)
Dev:
- Move ESLint environment configuration into `.eslintrc` (#2051)
- Sync Protocol Buffers with `libsignal-service-java` (#2046)
- Update to libsignal-protocol-javascript v1.3.0 (#2050)
- Make our binary comparisons constant time (#2047)
- Fix typo in issue template (#2020)
- Update to new signal branding (#2018)
New design for import and install flows (#2053)
Support for 'light' imports, which bring just messages, contacts and groups (#2053)
Fix: If app started offline, conversations would not open (#2064)
Fix: Attached images would sometimes show up rotated improperly (#2040)
Fix: Uncaught Exception: TypeError; 'getSize' (#2061)
Fix: File paths with special characters could be shown in misleading way
Dev:
- Move ESLint environment configuration into `.eslintrc` (#2051)
- Sync Protocol Buffers with `libsignal-service-java` (#2046)
Mikunj
sachaaaaa
Beaudan
Scott Nonnenberg
sachaaaaa
Daniel Gasienica
AJ Jordan
Scott Nonnenberg
Daniel Gasienica