Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								93d3abbf8d 
								
							
								 
							
						 
						
							
							
								
								Use contact name when updating last message for a conversation  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								3bf8a8966a 
								
							
								 
							
						 
						
							
							
								
								Notification improvements  
							
							 
							
							... 
							
							
							
							- Remove on read, on focus, and on exit.
- Show multi-message notifications like '5 new messages'. 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								8beeef4d10 
								
							
								 
							
						 
						
							
							
								
								Show contact name when you reply to message with a contact  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								3ea3e4e256 
								
							
								 
							
						 
						
							
							
								
								Contact sharing: protos and data pipeline  
							
							 
							
							... 
							
							
							
							As of this commit: 82b76ccf37 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								38f3ad6518 
								
							
								 
							
						 
						
							
							
								
								Use `SignalService` vs `textsecure` for protobuf  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								a0ddab669b 
								
							
								 
							
						 
						
							
							
								
								Organize `global`s  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								13f1ec2e51 
								
							
								 
							
						 
						
							
							
								
								Use structured logs  
							
							 
							
							... 
							
							
							
							Easier to search for static prefix and fields are named. 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								0ce56eed87 
								
							
								 
							
						 
						
							
							
								
								Use structured log  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								ae7d6aa900 
								
							
								 
							
						 
						
							
							
								
								Log `Conversation::updateLastMessage`  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								95321e5d3e 
								
							
								 
							
						 
						
							
							
								
								Remove Vim mode lines  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								822850433e 
								
							
								 
							
						 
						
							
							
								
								Apply manual fixes for ESLint errors  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								1dd87ad197 
								
							
								 
							
						 
						
							
							
								
								Format all source code using Prettier  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								36c609c2c3 
								
							
								 
							
						 
						
							
							
								
								Persist `has*Attachments` properties for incoming messages  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								3df8c22e44 
								
							
								 
							
						 
						
							
							
								
								Alphabetize `Message` properties  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								84c7a4c293 
								
							
								 
							
						 
						
							
							
								
								Move to some of our global utility methods  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								403fb1fd60 
								
							
								 
							
						 
						
							
							
								
								Make algorithm for finding thumbnails more efficient  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								27a30b3267 
								
							
								 
							
						 
						
							
							
								
								Respond to PR feedback  
							
							 
							
							... 
							
							
							
							- makeThumbnail -> makeImageThumbnail
- duplicate 'display: flex'
- remove no-longer-applicable comment 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								ac0b50d20f 
								
									
								
							
								 
							
						 
						
							
							
								
								Generate thumbnails for new video attachments, video quotes  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								bf3a547a76 
								
							
								 
							
						 
						
							
							
								
								Organize `global`s  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								b65370c8d7 
								
							
								 
							
						 
						
							
							
								
								Prefer `GoogleChrome.is*` over `MIME.is*`  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								9619e5b66d 
								
									
								
							
								 
							
						 
						
							
							
								
								Fix quote thumbnail flickering issue  
							
							 
							
							... 
							
							
							
							Turns out that we reload thumbnails for every message when any new
message is added to the conversation. This fix prevents that by actually
checking for the proper sentinel on the message model 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								c02860af5c 
								
									
								
							
								 
							
						 
						
							
							
								
								Responding to pull request review feedback  
							
							 
							
							... 
							
							
							
							- messages.getQuoteObjectUrl: early return
- backup.js: explaining variables for long if statement
- types/messages.js: Log if thumbnail has neither data nor path
- sendmessage.js:
  - remove extraneous logging
  - fix indentation
  - upload attachments and thumbnails in parallel
- preload: don't load fs for tests, just fse
- _conversation.scss: split two selectors into two lines, 0px -> 0
- backup_test.js: use fse.existsSync and comment twoSlashes regex
- network_tests_view_test.js: Comment duplicate assignment to window.getSocketStatus 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								26dd01c4fd 
								
									
								
							
								 
							
						 
						
							
							
								
								Make sent quote clickable - process after adding to conversation  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								73edabfb17 
								
									
								
							
								 
							
						 
						
							
							
								
								Full pipeline to send quotes, including thumbnail upload  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								13ce056830 
								
									
								
							
								 
							
						 
						
							
							
								
								Make thumbnails on quote load and on quote preview creation  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								b4ff223d18 
								
									
								
							
								 
							
						 
						
							
							
								
								Refactor: Push selector logic for quote props into Message model  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								a563dc8b37 
								
									
								
							
								 
							
						 
						
							
							
								
								Style Guide: Additional message examples, a few fixes to enable  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								000dc3a159 
								
									
								
							
								 
							
						 
						
							
							
								
								Handle attachment load failure for quoted message  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								04d186c05a 
								
									
								
							
								 
							
						 
						
							
							
								
								Conversation.loadQuoteThumbnail: Be resilient to no attachments  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								3bbb9f535a 
								
									
								
							
								 
							
						 
						
							
							
								
								Load thumbnail even if we have the full message in hand  
							
							 
							
							... 
							
							
							
							This is important for now, when we aren't generating our own thumbnails 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								fce9bb7342 
								
									
								
							
								 
							
						 
						
							
							
								
								Move to central MIME functions, remove some console.log  
							
							 
							
							... 
							
							
							
							And generally address PR feedback. 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								32925ed026 
								
									
								
							
								 
							
						 
						
							
							
								
								Load attachment data for quotedMessages, processMessage on add  
							
							 
							
							... 
							
							
							
							Not ideal that it loads it twice, but AttachmentView is so selfish with
its blob and objectUrl! 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								fc330ef854 
								
									
								
							
								 
							
						 
						
							
							
								
								Quote loading: Check for in-memory message until we get one  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								1cc0633786 
								
									
								
							
								 
							
						 
						
							
							
								
								Full support for quotations in Android theme  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								5602241a0c 
								
									
								
							
								 
							
						 
						
							
							
								
								Eliminate eslint-generated triple-parents  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								5c2936bdd6 
								
									
								
							
								 
							
						 
						
							
							
								
								Turns out that we call validateNumber() on group conversations!  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								e99192dca7 
								
									
								
							
								 
							
						 
						
							
							
								
								Unleash eslint on models/messages.js  
							
							 
							
							... 
							
							
							
							Fun fact: eslint was not running on this file, despite the eslint
directives previously in the file! 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								33ef967dd7 
								
									
								
							
								 
							
						 
						
							
							
								
								Unleash eslint on models/conversations.js  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
								
								
							
							
								
							
								054d3887a1 
								
									
								
							
								 
							
						 
						
							
							
								
								Quotes: The full pipeline into the database  
							
							 
							
							... 
							
							
							
							1. MessageReceiver always pulls down thumbnails included in quotes
2. Message.upgradeSchema has a new schema that puts all thumbnails on
   disk just like happens with full attachments.
3. handleDataMessage pipes quote from dataMessage into the final message
   destined for the database 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								5f8148d3da 
								
							
								 
							
						 
						
							
							
								
								Bind to `Conversation` lazily to prevent style guide errors  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								0902c94093 
								
							
								 
							
						 
						
							
							
								
								Reset last message after message has expired  
							
							 
							
							... 
							
							
							
							Fixes  #980 . 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								f253fef5c6 
								
							
								 
							
						 
						
							
							
								
								Explicitly make `onDestroy` have `void` return type  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								0c06fff47b 
								
							
								 
							
						 
						
							
							
								
								Wire up `Message` / `Attachment` migration functions on startup  
							
							 
							
							... 
							
							
							
							Makes `migrationContext` obsolete. 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								9d25aa4e43 
								
							
								 
							
						 
						
							
							
								
								Delete attachment files on disk upon message delete  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								833a203559 
								
							
								 
							
						 
						
							
							
								
								Remove Vim modeline  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								38e2468b2e 
								
							
								 
							
						 
						
							
							
								
								Set `schemaVersion` in `handleMessage`  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								e3dbeba963 
								
							
								 
							
						 
						
							
							
								
								Initialize schema version during `Message` construction  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								9a540d6d18 
								
							
								 
							
						 
						
							
							
								
								Load attachment data before sending message  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								e0428355be 
								
							
								 
							
						 
						
							
							
								
								Wire up `writeAttachment`  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Daniel Gasienica
							
						 
						
							 
							
							
							
								
							
								cd3aee962d 
								
							
								 
							
						 
						
							
							
								
								Upgrade message schema before sending  
							
							 
							
							
							
						 
						
							8 years ago