d14761087a
Add schema version 4: Attachment metadata
7 years ago
df2e6e7864
Port `MIME` module to TypeScript
7 years ago
6a63e427c8
Use `is` instead of Lodash `is*`
7 years ago
bf81c3db63
Document Message v4, remove data-free thumbnails
7 years ago
c02860af5c
Responding to pull request review feedback
...
- messages.getQuoteObjectUrl: early return
- backup.js: explaining variables for long if statement
- types/messages.js: Log if thumbnail has neither data nor path
- sendmessage.js:
- remove extraneous logging
- fix indentation
- upload attachments and thumbnails in parallel
- preload: don't load fs for tests, just fse
- _conversation.scss: split two selectors into two lines, 0px -> 0
- backup_test.js: use fse.existsSync and comment twoSlashes regex
- network_tests_view_test.js: Comment duplicate assignment to window.getSocketStatus
7 years ago
a7d44d3344
Backup and end-to-end test!
7 years ago
978ff0e2bb
Refactor: Use correct name for sanitized filename in backup.js
7 years ago
f1ff040842
Finish type definition for _mapQuotedAttachments
7 years ago
9ad55c803f
Fix handling attachment thumbnails using thumbnail key
7 years ago
054d3887a1
Quotes: The full pipeline into the database
...
1. MessageReceiver always pulls down thumbnails included in quotes
2. Message.upgradeSchema has a new schema that puts all thumbnails on
disk just like happens with full attachments.
3. handleDataMessage pipes quote from dataMessage into the final message
destined for the database
7 years ago
21bf02c94d
Fixed examples in Quote.md, rough Android visuals
7 years ago
d7b845326d
ESLint auto-fix `link_text`
7 years ago
9d41b86162
Remove escaping from `linkText`
...
We leverage jQuery’s HTML escaping in `$.html(…)`.
7 years ago
f04c65088b
Fork `link-text` module
7 years ago
24f4ad53bc
Use single quotes for identifiers
7 years ago
432a6ebd7f
Redact file paths with escaped slashes
7 years ago
a8a7525609
Redact stack traces with forward and backslashes
7 years ago
b0da7d965e
Redact URL encoded file paths in stack traces
7 years ago
f2c9ccae90
Prefer `is.*` over Lodash `is*` functions
7 years ago
2ee78ec556
Prefer `path` over `Path`
7 years ago
c6c3b65bbc
Introduce React, TypeScript, TSLint and React-StyleGuidist ( #2219 )
...
Quite a bit of change here.
First, the basics:
- New dependencies were added: react, typescript, tslint, and react-styleguidist
- A new npm script: transpile. It uses typescript to process .tsx files in js/react, putting .js files next to the original file. It's part of the watch functionality of grunt dev as well as the default task run with just grunt (used to build the app prior to release). A lighter-weight to get watch behavior when just working on React components is to run yarn transpile --watch.
- yarn run clean-transpile will remove generated .js files
Style guide via react-styleguidist. Example site: https://react-styleguidist.js.org/examples/basic/
- Start with yarn styleguide
- Component.md files right next to the .tsx file
- jsdoc-style comments are picked up and added to the generated part of the styleguide - the overall summary and a table listing methods and properties of the component
- It has hot-reloading!
- It uses webpack, which means that our app now pulls in webpack though we don't use it to generate anything for the production app.
- I did a bunch of work to enable the use of Backbone views in this context, which will allow us to move smoothly from the old world to the new. First, add all the permutations in the old way, and then slowly start to re-render those same views with React.
A bit of dependency cleanup to enable use in React components:
- moment was moved from our Bower dependencies to our npm dependencies, so it can be used in React components not running in a browser window.
- i18n was moved into the new commonjs format, so it can be used in React components even if window is not available.
Lastly, a bit of Gruntfile cleanup:
- Removal of Chrome App-era modifications of background.js
- Make jshint/jscs watch more targeted, since more and more we'll be using other tools
7 years ago
50d4dbaae7
Remove 'use strict' from i18n.js
7 years ago
76be13552f
js/i18n.js -> js/modules/i18n.js
7 years ago
195e9b777c
Rename `willHaveAttachmentsSavedOnFileSystemDuringUpgrade`
...
New name: `willAttachmentsGoToFileSystemOnUpgrade`
7 years ago
4c4443390a
Rename `createImporter` to `createAttachmentDataWriter`
7 years ago
5ea1a305a6
Clarify error origin
7 years ago
9dcb64b53c
Initialize schema version upon import
7 years ago
cfad983d08
Consistently use `ciphertext` instead of `encrypted`
7 years ago
a61c905146
Impliclity decrypt data if `key` is present
7 years ago
94c75762b5
Add `Message.createAttachmentLoader`
7 years ago
43ab320d31
Load attachments before writing them upon export
7 years ago
7eeabb5b1a
Add precondition for `writeAttachment`
7 years ago
0faaf52b71
Import and upgrade messages upon save
7 years ago
cf7355bd2f
Rename `backupToDirectory` to `exportToDirectory`
...
For symmetry reasons.
7 years ago
bf67254cc5
Add `Message.createImporter`
7 years ago
efd673083d
Rename `writeAttachmentData` to `writeNewAttachmentData`
7 years ago
ce8fe0d345
Add `Signal.Startup` module
7 years ago
8474f3cf7f
Use `create*` prefix to clarify curried functions
7 years ago
12cdeee7ec
Rename `count` to `numMessagesPerBatch`
7 years ago
38ac9972e8
Improve termination condition
7 years ago
5b1a0c45df
Replace `getAll` with cursor
...
This reduces the likelihood of IPC message size error.
7 years ago
ed77378293
Fix bug in termination condition
7 years ago
052fb841f6
Allow database name override in migrations
7 years ago
1e04083813
Support database upgrades in `Database.open`
7 years ago
f50ac1c99e
Reduce excessive logging about database status
7 years ago
77b1f3c505
Replace startup with attachment background migration
...
Iterates through `Message::id` index.
7 years ago
057762806e
Add support for attachment background migration without index
7 years ago
2e4893f4c1
Clarify implications of introducing new migrations
7 years ago
7413b787b6
Make `migrations` private
7 years ago
b07c66eaa7
Generate attachments from local files
...
This ensures our benchmarking is closer to real-world usage, e.g. images, video,
etc. that are not compressible.
7 years ago
064a40544c
Fix error message formatting
7 years ago
442f5d7295
Use `done` to match JavaScript iterators
...
See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Iterators_and_Generators
7 years ago
a4f0c5242f
Document why batch size is one
7 years ago
805031ade8
Conditionally run post-attachment migrations
...
Introduce placeholder migrations for Backbone models so they never implicitly
run migrations whenever they are `fetch`ed. We prefer to run our migrations
explicitly upon app startup and then let Backbone models be (slightly) dumb(er)
models, without inadvertently triggering migrations.
7 years ago
bfbeedab5c
Temporarily disable post-attachment migration migrations
7 years ago
d9be6a0f94
Destructure Lodash `require`s
7 years ago
b7b6195cfc
Extract IIFE into separate function
7 years ago
11f98474ba
Capture how many messages we have to process
7 years ago
0fdc1140dd
Add `Database.getCount` function
7 years ago
1f8556b049
Remove unused `createCollection`
7 years ago
c67c2a858a
Remove Backbone references for attachment migration
...
It has to run without any other migrations interfering.
7 years ago
0c40f35623
Document disadvantage of fetching messages without index
7 years ago
d3c9de4712
Add debug module
...
Lets us generate large conversations with large attachments.
7 years ago
30037e5308
Reduce attachment migration batch size to 1
...
This prevents ‘Maximum IPC message size exceeded’ due to IDB `getAll` operation.
- https://github.com/zincbase/zincdb/issues/17
- https://cs.chromium.org/chromium/src/content/browser/indexed_db/indexed_db_database.cc?q=%22Maximum+IPC+message+size+exceeded%22&sq=package:chromium&l=1160
7 years ago
21147a20a0
Add `sleep` module
7 years ago
08f73b8420
Remove last processed index after attachment migration
7 years ago
696a144ab7
Add `settings.deleteItem`
7 years ago
5910f84af4
Remove outdated documentation
7 years ago
efe3cd67fc
Allow attachment migration run on higher database version
7 years ago
921c3dba7c
Skip migrations that have already been applied
7 years ago
417511ffd2
Add `database.getVersion`
7 years ago
c5c94bc3ab
Extract `getMigrationVersions`
7 years ago
6aea36240d
Rename `closeDatabase` to `closeDatabaseConnection`
7 years ago
016432826b
Extract `database` and `settings` modules
7 years ago
5bea894abd
Close database connection via Backbone IDB adapter
7 years ago
f50e9ae364
Log closing connection of database
7 years ago
4ff8bc3357
Use `camelCase` for non-constructors
7 years ago
3720c3f3bb
Improve log message
7 years ago
ce5b450fdb
Log `targetSchemaVersion`
7 years ago
f7f24b5822
Log total number of processed messages
7 years ago
eca930770c
Remove hard-coded database connection settings
7 years ago
1df6dc8378
Abort processing if there are no more messages
7 years ago
d5d0eabdfd
Remove usage of `storage` module
7 years ago
8966e80284
Improve identifier names
7 years ago
3e2d575506
Document `MessageDataMigrator` module design
7 years ago
3c57dbfb56
Extract `NUM_MESSAGES_PER_BATCH`
7 years ago
85788d3c4a
Match `items` storage format to Backbone adapter
7 years ago
7de7fcf561
Avoid `no-param-reassign` violation
7 years ago
070235b59b
Implement `MessageDataMigrator.processAll`
...
Upgrades schema of all messags upon startup.
7 years ago
178a3cc262
Reduce work for verifying transaction completion
7 years ago
b6e978f74c
Implement `MessagesDataMigrator.processAll`
7 years ago
457bf7ab9d
Add `createCollection` function
7 years ago
8ea257ad4d
Use double quotes for identifiers in error messages
7 years ago
172616ca4f
Add log message for dummy migration 18
7 years ago
579b01283e
Replace `wrapDeferred` with `deferredToPromise`
7 years ago
40c40c800a
Prefer `exports`
7 years ago
da144edc56
Manually close database connection after migration
7 years ago
106ce21c49
Remove redundant log message
7 years ago
fcd30cd919
Close database after migration
...
This is not 100% reliable as database connections are closed in a separate
thread according to the documentation:
- https://developer.mozilla.org/en-US/docs/Web/API/IDBDatabase/close
- https://stackoverflow.com/a/18639298
- 80c7a06d5c/backbone-indexeddb.js (L558-L565)
7 years ago
c765422fa1
Extract `deferredToPromise`
7 years ago
Daniel Gasienica
Scott Nonnenberg