Notification Improvements (#2364)
- Fixed: The change for production didn't full make it into v1.11.0-beta.1 - this change restores the code which removes the old notification when we add a new one
- Fixed: Notifications could be orphaned in notification center if they were added/removed quickly
- Fixed: Notifications weren't removed properly when read on a linked device
Dev: Better logging when we receive a read sync from a linked device (#2364)
Feature: Receive contact (#2349, #2359)
Fixed: Sometimes clicks on quoted message wouldn't work (#2350)
Fixed: In dark theme, it was hard to see a message's triple-dot menu on hover - thanks @PunkChameleon (#2334)
Fixed: Unsupported image and video types were missing from media pane (#2351)
Fixed: On small screens, the media lightbox view would show media off-screen (#2351)
Notification improvements
- Remove all on remote read, on focus, on exit
- Show multi-message notifications like '5 new messages'
Media Gallery: A number of small visual fixes (#2351)
Emoji pane: Can now dismiss it by pressing escape key - thanks @tommypacker (#2354, #2357)
Update translations (#2328, #2352)
Dev:
- Windows 7: Use Electron-native notifications (#2338, #2330)
- Improve Logging For Disappearing Messages (#2332)
- Prettier: Continue expanding its coverage of app (#2339, #2324)
- Document Translations Setup + Remove Unused Strings (#2329)
- Make Protocol Buffers available to commonjs code (#2347)
This does not work with `ArrayBuffer` out of the box and will need to be
investigated and tested more before switching.
Some APIs also seemed to have changed:
- Before (OOP): `new textsecure.protobuf.WebSocketMessage(…).encode();`
- After (functional):
```
textsecure.protobuf.WebSocketMessage.encode(
new textsecure.protobuf.WebSocketMessage(…)
);
```
This reverts commit d758119d9de4f99742ea941e86180b1d600c2f22.
We missed a couple directories with previous attempts to turn this on
globally: app/ and libtextsecure/
Not to mention files in places we didn't expect: ts files that weren't
in the ts directory!
This turns prettier on for every file we care about (js, ts, tsx, md)
everywhere in the project but for a few key parts.
Linux: deb (dropped zip)
Mac: zip (dropped dmg)
Windows: exe (dropped zip)
We can always re-add if people are relying on these things. But our
download links all point to these assets, so we'll generate and upload
only these for now.
Media Gallery showing all attachments in a given conversation (#2291, previous: #2236)
Quotes:
- Show 'You' in Android theme instead of your own contact name (#2312)
- Show thumbnails for quotes of messages with video attachments (#2293)
Video attachments: show first frame preview in composition area (#2293)
Increase speed of migration to move attachments to disk from database (#2314)
Dev:
- Add comments clarifying our mechanisms for stripping EXIF info (#2313)
- Move to prettierjs to format our code (#2303)
- Fix break in styleguide; make filesize/Signal.Util.GoogleChrome available (#2302)
- Remove duplicate entry from .gitignore (#2271)
Send quoted replies via hover menu on message (#2284, #2292)
Fixed: Linking a new iOS device would not initially show iOS theme (#2284)
Fixed: In iOS theme, narrow images would result in a broken chat bubble (#2273, #2282)
Dev:
- Fix beta install instructions in readme for debian-based linux (#2262)
- Media Gallery: Phase 1 - currently disabled (#2236)
Receive quoted replies (#2244)
iOS theme: one bubble for both attachment and message contents (#2244)
Improve URL Auto-Linking In Messages (#2240)
Redact More Variants Of Paths In Stack Traces (#2229)
Fixed: Conversation message preview would sometimes continue to show after message disappeared (1206b3c448)
Dev: Introduce React, TypeScript, TSLint and React-StyleGuidist (#2219 and #2232)
Separate linting from testing as follows:
- `yarn jscs`: Run JSCS.
- `yarn jshint`: Run JSHint.
- `yarn lint`: Run all linters, i.e. ESLint, TSLint, JSHint, and JSHint.
- `yarn test-node`: Run Mocha tests in Node.js environment.
- `yarn test-electron`: Run tests in Electron environment via Grunt.
- `yarn test`: Run all tests.
CI
- Align Travis and AppVeyor scripts as much as possible.
- Run linting before tests to fail fast.
- Run Node.js (headless and fast) tests first.
- Run Electron tests last (Travis seems to require custom setup in `travis.sh`).
Scott Nonnenberg
Daniel Gasienica