* [x] Test notifications on Windows 7.
* [x] Switch to Electron native notifications on Window 7.
* [x] Disable **Play audio notification** setting on Windows 7 since they are
not natively supported.
* [x] Improve logging for notification status.
* [x] Investigate whether Electron notification support choosing custom sound
on Windows. Answer: no.
Source: 82329124ff/docs/api/notification.md (new-notificationoptions-experimental)
* [x] Remove `node-notifier`.
* [x] **Infrastructure:** Port `OS` and `types/Settings` to TypeScript.
* [x] Add support for specifying minimum Windows version with
`OS.isWindows(minVersion?: string)`.
* [x] OT: While testing on Windows 7, I confirmed spell checking worked
for me.
- [x] Remove documentation on how to add discouraged Bower dependencies.
**TODO:** Document how to pull in npm dependencies.
- [x] Document Transifex setup for pulling translations.
- [x] Remove unused translation strings.
We missed a couple directories with previous attempts to turn this on
globally: app/ and libtextsecure/
Not to mention files in places we didn't expect: ts files that weren't
in the ts directory!
This turns prettier on for every file we care about (js, ts, tsx, md)
everywhere in the project but for a few key parts.
Send quoted replies via hover menu on message (#2284, #2292)
Fixed: Linking a new iOS device would not initially show iOS theme (#2284)
Dev: Media Gallery: Phase 1 - currently disabled (#2236)
Send quoted replies via hover menu on message (#2284, #2292)
Fixed: Linking a new iOS device would not initially show iOS theme (#2284)
Fixed: In iOS theme, narrow images would result in a broken chat bubble (#2273, #2282)
Dev:
- Fix beta install instructions in readme for debian-based linux (#2262)
- Media Gallery: Phase 1 - currently disabled (#2236)
-----BEGIN PGP SIGNATURE-----
iQFFBAABCAAvFiEEasWqbW7b5YGqUH0mX4IoDDUTRmEFAlrg3wARHHNjb3R0QHNp
Z25hbC5vcmcACgkQX4IoDDUTRmHmfwf/cYG4hN6QoyCeV+qeG6vXckzUHsku/u2m
egcBd+s4+7on0sCAiSVNW8gR6s0cZLlKiiNdbNKP6EdCdCRJO1E5NW1ZMBSqH0V+
fiKyjG7MFW+2urd7HZ/xJ8WlhoR638a/hQcxuGYuu6z7Mr2qeEYDFsBFgXvOlm1H
0IhfKKMRagjd00xQ+x0fCBs1OuGXBgz69apM0vCvAODIrnfx3yY7xx4Qkd9Wwy2P
iek+Osu54rMJgavO8Lx2+X/KDYIdcaA20sMMiKDsm0+M/Bq31h68PMWhXEaFdcBL
zhN7wzGGyR4n5iCw2LfHOnJ/7NUK40FBV9jK7lJ3OKJUxYXfUSRVnw==
=982D
-----END PGP SIGNATURE-----
Merge tag 'v1.9.0-beta.1'
v1.9.0-beta.1
Send quoted replies via hover menu on message (#2284, #2292)
Fixed: Linking a new iOS device would not initially show iOS theme (#2284)
Fixed: In iOS theme, narrow images would result in a broken chat bubble (#2273, #2282)
Dev:
- Fix beta install instructions in readme for debian-based linux (#2262)
- Media Gallery: Phase 1 - currently disabled (#2236)
Linux: deb (dropped zip)
Mac: zip (dropped dmg)
Windows: exe (dropped zip)
We can always re-add if people are relying on these things. But our
download links all point to these assets, so we'll generate and upload
only these for now.
Media Gallery showing all attachments in a given conversation (#2291, previous: #2236)
Quotes:
- Show 'You' in Android theme instead of your own contact name (#2312)
- Show thumbnails for quotes of messages with video attachments (#2293)
Video attachments: show first frame preview in composition area (#2293)
Increase speed of migration to move attachments to disk from database (#2314)
Dev:
- Add comments clarifying our mechanisms for stripping EXIF info (#2313)
- Move to prettierjs to format our code (#2303)
- Fix break in styleguide; make filesize/Signal.Util.GoogleChrome available (#2302)
- Remove duplicate entry from .gitignore (#2271)
Adopt Prettier code formatting for our entire project to reduce overhead of
formatting code. I considered adding a pre-commit hook but to make the change
more gradual, I recommend installing an editor plugin that runs Prettier on
save, e.g. `JsPrettier` for *Sublime Text*, or manually run `yarn format`.
Also: This PR makes no other changes to linting. ESLint is still opt-in as it
requires more changes than just formatting an can be done on a as-needed basis
when touching particular files (as we have done in the past.) On the other hand,
the ESLint required changes will now be smaller as they won’t involve large
formatting changes.
## Sublime Text Plugin
- Install **JsPrettier**: https://github.com/jonlabelle/SublimeJsPrettier
- Settings:
```
{
"prettier_cli_path": "./node_modules/.bin/prettier",
"auto_format_on_save": true,
"auto_format_on_save_requires_prettier_config": true,
}
```
## Changes
- [x] Disable conflicting ESLint rules
- [x] Exclude generated files and `libtextsecure`
- [x] Autoformat all JS and TS code (excluding CSS and JSON)
- [x] Apply isolated manual one-time fixes:
80bc06486e
- [x] Goodbye Vim modelines!
7b6e77d566
- [x] Ensure automated tests pass
- [x] Ensure app still works (smoke test)
Daniel Gasienica
Scott Nonnenberg
Ayman Nedjmeddine