c6c3b65bbc
Introduce React, TypeScript, TSLint and React-StyleGuidist ( #2219 )
...
Quite a bit of change here.
First, the basics:
- New dependencies were added: react, typescript, tslint, and react-styleguidist
- A new npm script: transpile. It uses typescript to process .tsx files in js/react, putting .js files next to the original file. It's part of the watch functionality of grunt dev as well as the default task run with just grunt (used to build the app prior to release). A lighter-weight to get watch behavior when just working on React components is to run yarn transpile --watch.
- yarn run clean-transpile will remove generated .js files
Style guide via react-styleguidist. Example site: https://react-styleguidist.js.org/examples/basic/
- Start with yarn styleguide
- Component.md files right next to the .tsx file
- jsdoc-style comments are picked up and added to the generated part of the styleguide - the overall summary and a table listing methods and properties of the component
- It has hot-reloading!
- It uses webpack, which means that our app now pulls in webpack though we don't use it to generate anything for the production app.
- I did a bunch of work to enable the use of Backbone views in this context, which will allow us to move smoothly from the old world to the new. First, add all the permutations in the old way, and then slowly start to re-render those same views with React.
A bit of dependency cleanup to enable use in React components:
- moment was moved from our Bower dependencies to our npm dependencies, so it can be used in React components not running in a browser window.
- i18n was moved into the new commonjs format, so it can be used in React components even if window is not available.
Lastly, a bit of Gruntfile cleanup:
- Removal of Chrome App-era modifications of background.js
- Make jshint/jscs watch more targeted, since more and more we'll be using other tools
7 years ago
23537546fe
Big refactor: ts/ directory for all typescript, including react
...
Split out test-specific and general utility react components too.
And moved our test/legacy* files for the Style Guide into a styleguide/
subdirectory of test/.
I think we'll be able to live in this directory structure for a while.
7 years ago
50d4dbaae7
Remove 'use strict' from i18n.js
7 years ago
76be13552f
js/i18n.js -> js/modules/i18n.js
7 years ago
e5322e8261
Finish rename of MessageParents, re-add moment to page
...
(we were getting crashes in the initial setup of a backbone view)
7 years ago
cdd16c9780
Rename test-only MessageParents to ConversationContext
7 years ago
61a7846149
Fix typo in index.ts
7 years ago
2384092e9e
Use Array.isArray in i18n.js
7 years ago
23293a3c00
New tslint rule: Interfaces must not start with I
7 years ago
1052341d79
Fix tslint errors and add tslint to CI task in package.json
7 years ago
be91a89d68
Parse theme from querystring, put on util. Moment from require()
...
We also fully set up i18n and put it on util as well as making
it available on windows.i18n for Backbone views.
7 years ago
887abd75dd
Add missing shim, fix typo
7 years ago
ed12e1b076
Add mp3 to project, make binary files available in rsg on util
7 years ago
3899eb8d0b
Add 'use strict' to i18n.js
7 years ago
195e9b777c
Rename `willHaveAttachmentsSavedOnFileSystemDuringUpgrade`
...
New name: `willAttachmentsGoToFileSystemOnUpgrade`
7 years ago
4c4443390a
Rename `createImporter` to `createAttachmentDataWriter`
7 years ago
1326b26585
Full styleguide now available via `yarn styleguide`
...
Due to a number of hacks, the style guide can be used to show Backbone
views. This will allow a smooth path from the old way of doing things to
the new.
7 years ago
893fb1cb9e
Introduce React/TypeScript/TSLint into app for new UI components
...
npm run transpile
Works on files under js/react/
Outputs files right next to the .tsx file
This is part of our `grunt dev` task, as well as the default grunt task,
which does everything else necessary to get a raw git checkout ready to
run.
7 years ago
f86a6ef752
Update style of i18n, pull it in via preload instead of .html
7 years ago
5ea1a305a6
Clarify error origin
7 years ago
9dcb64b53c
Initialize schema version upon import
7 years ago
cfad983d08
Consistently use `ciphertext` instead of `encrypted`
7 years ago
a61c905146
Impliclity decrypt data if `key` is present
7 years ago
94c75762b5
Add `Message.createAttachmentLoader`
7 years ago
43ab320d31
Load attachments before writing them upon export
7 years ago
7eeabb5b1a
Add precondition for `writeAttachment`
7 years ago
0faaf52b71
Import and upgrade messages upon save
7 years ago
cf7355bd2f
Rename `backupToDirectory` to `exportToDirectory`
...
For symmetry reasons.
7 years ago
bf67254cc5
Add `Message.createImporter`
7 years ago
efd673083d
Rename `writeAttachmentData` to `writeNewAttachmentData`
7 years ago
bcbd526b99
Sync read receipt configuration upon relink
...
Fixes https://github.com/signalapp/Signal-Android/issues/7535 .
7 years ago
ce8fe0d345
Add `Signal.Startup` module
7 years ago
fe0306e6be
issue-2023: move opened event out of selected conversation check
...
Going through the git history the existing logic of "dont do this if
it's already selected" was just for audio or video QOL enhancements to
not stop playing when the same conversation is selected.
7 years ago
8474f3cf7f
Use `create*` prefix to clarify curried functions
7 years ago
12cdeee7ec
Rename `count` to `numMessagesPerBatch`
7 years ago
38ac9972e8
Improve termination condition
7 years ago
5b1a0c45df
Replace `getAll` with cursor
...
This reduces the likelihood of IPC message size error.
7 years ago
ed77378293
Fix bug in termination condition
7 years ago
052fb841f6
Allow database name override in migrations
7 years ago
1e04083813
Support database upgrades in `Database.open`
7 years ago
f50ac1c99e
Reduce excessive logging about database status
7 years ago
77b1f3c505
Replace startup with attachment background migration
...
Iterates through `Message::id` index.
7 years ago
c853d1bccd
Remove whole database migrations
...
We should enable this when we are willing to run attachment migration
on startup.
7 years ago
057762806e
Add support for attachment background migration without index
7 years ago
32ac99b439
Prefer ISO date formatting
...
Previously, this was formatted using locale specific settings. This will allow
easier debugging by matching key rotation timestamps against log timestamps.
7 years ago
2e4893f4c1
Clarify implications of introducing new migrations
7 years ago
7413b787b6
Make `migrations` private
7 years ago
b07c66eaa7
Generate attachments from local files
...
This ensures our benchmarking is closer to real-world usage, e.g. images, video,
etc. that are not compressible.
7 years ago
064a40544c
Fix error message formatting
7 years ago
442f5d7295
Use `done` to match JavaScript iterators
...
See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Iterators_and_Generators
7 years ago
a4f0c5242f
Document why batch size is one
7 years ago
d59fdddb43
Improve `storage.fetch` error message
7 years ago
805031ade8
Conditionally run post-attachment migrations
...
Introduce placeholder migrations for Backbone models so they never implicitly
run migrations whenever they are `fetch`ed. We prefer to run our migrations
explicitly upon app startup and then let Backbone models be (slightly) dumb(er)
models, without inadvertently triggering migrations.
7 years ago
bfbeedab5c
Temporarily disable post-attachment migration migrations
7 years ago
d9be6a0f94
Destructure Lodash `require`s
7 years ago
b7b6195cfc
Extract IIFE into separate function
7 years ago
11f98474ba
Capture how many messages we have to process
7 years ago
0fdc1140dd
Add `Database.getCount` function
7 years ago
1f8556b049
Remove unused `createCollection`
7 years ago
c67c2a858a
Remove Backbone references for attachment migration
...
It has to run without any other migrations interfering.
7 years ago
0c40f35623
Document disadvantage of fetching messages without index
7 years ago
a4ecf1a9d6
Define constant after creating idle detector
7 years ago
d3c9de4712
Add debug module
...
Lets us generate large conversations with large attachments.
7 years ago
30037e5308
Reduce attachment migration batch size to 1
...
This prevents ‘Maximum IPC message size exceeded’ due to IDB `getAll` operation.
- https://github.com/zincbase/zincdb/issues/17
- https://cs.chromium.org/chromium/src/content/browser/indexed_db/indexed_db_database.cc?q=%22Maximum+IPC+message+size+exceeded%22&sq=package:chromium&l=1160
7 years ago
21147a20a0
Add `sleep` module
7 years ago
08f73b8420
Remove last processed index after attachment migration
7 years ago
696a144ab7
Add `settings.deleteItem`
7 years ago
a18e462817
Move migrations to `Signal.Migrations`
7 years ago
5910f84af4
Remove outdated documentation
7 years ago
efe3cd67fc
Allow attachment migration run on higher database version
7 years ago
921c3dba7c
Skip migrations that have already been applied
7 years ago
417511ffd2
Add `database.getVersion`
7 years ago
c5c94bc3ab
Extract `getMigrationVersions`
7 years ago
6aea36240d
Rename `closeDatabase` to `closeDatabaseConnection`
7 years ago
016432826b
Extract `database` and `settings` modules
7 years ago
5bea894abd
Close database connection via Backbone IDB adapter
7 years ago
f50e9ae364
Log closing connection of database
7 years ago
4ff8bc3357
Use `camelCase` for non-constructors
7 years ago
3720c3f3bb
Improve log message
7 years ago
ce5b450fdb
Log `targetSchemaVersion`
7 years ago
f7f24b5822
Log total number of processed messages
7 years ago
eca930770c
Remove hard-coded database connection settings
7 years ago
1df6dc8378
Abort processing if there are no more messages
7 years ago
85490fbc98
Disable JSHint for `background.js`
...
It doesn’t recognize `async` and I couldn’t figure out how to ignore a top-level
`async` without cascading errors.
7 years ago
d5d0eabdfd
Remove usage of `storage` module
7 years ago
8966e80284
Improve identifier names
7 years ago
3e2d575506
Document `MessageDataMigrator` module design
7 years ago
3c57dbfb56
Extract `NUM_MESSAGES_PER_BATCH`
7 years ago
85788d3c4a
Match `items` storage format to Backbone adapter
7 years ago
7de7fcf561
Avoid `no-param-reassign` violation
7 years ago
070235b59b
Implement `MessageDataMigrator.processAll`
...
Upgrades schema of all messags upon startup.
7 years ago
b8a0bc3423
Run attachment to disk migration on startup
7 years ago
178a3cc262
Reduce work for verifying transaction completion
7 years ago
b6e978f74c
Implement `MessagesDataMigrator.processAll`
7 years ago
457bf7ab9d
Add `createCollection` function
7 years ago
8ea257ad4d
Use double quotes for identifiers in error messages
7 years ago
172616ca4f
Add log message for dummy migration 18
7 years ago
579b01283e
Replace `wrapDeferred` with `deferredToPromise`
7 years ago
40c40c800a
Prefer `exports`
7 years ago
da144edc56
Manually close database connection after migration
7 years ago
106ce21c49
Remove redundant log message
7 years ago
fcd30cd919
Close database after migration
...
This is not 100% reliable as database connections are closed in a separate
thread according to the documentation:
- https://developer.mozilla.org/en-US/docs/Web/API/IDBDatabase/close
- https://stackoverflow.com/a/18639298
- 80c7a06d5c/backbone-indexeddb.js (L558-L565)
7 years ago
c765422fa1
Extract `deferredToPromise`
7 years ago
e2f1339ab9
Explicitly run post-attachment migrations
7 years ago
d7c8d33edb
Extract `runMigrations`
7 years ago
d16178638e
Split database migrations into pre- and post-attachment migration
...
- Run light-weight migrations before attachment migration.
- Run regular migrations after attachments have been moved to disk.
7 years ago
b24dad23ea
Fix search view conversation reset bug
...
When searching for an existing conversation using a phone number, it’s possible
to click on ‘Start conversation…’ and have that new dummy entry overwrite the
existing conversation.
This change ensures we are always showing a dummy conversation model that is not
part of the conversation collection. Adding it is always idempotent as it goes
through `getOrCreateAndWait`.
7 years ago
08f6886f3e
Strengthen precondition of `ConversationController.getOrCreate`
7 years ago
83c979fb84
Rename `createTemporary` to `dangerouslyCreateAndAdd`
...
Class: `ConversationController`.
This function should not be used in application code as it creates potentially
invalid `Conversation` instances in our global conversation collection. We keep
making it available for testing purposes.
7 years ago
90de9d85a3
Remove type annotation
7 years ago
4c10fcfa17
Reduce threshold until optimization appears to 1s
7 years ago
dede0f1e25
Improve user messaging during initialization
...
- We first show a localized loading message.
- If initialization takes longer than a certain threshold, we show a different
‘optimization’ message.
- If initialization is below the threshold the message change is canceled right
before the regular loading screen.
7 years ago
add19aa732
Add initialization view
7 years ago
f253fef5c6
Explicitly make `onDestroy` have `void` return type
7 years ago
9b112489cd
Upgrade 2 messages every 30 seconds
...
This results in 4 messages per minute or 240 messages per hour.
7 years ago
7c2fde4433
Add `Signal.Workflow` namespace
7 years ago
4a7cc22de3
🎨 Use `window.requestIdleCallback`
7 years ago
5c9f18e1ae
Wire up background message migration
7 years ago
4651cbc2eb
Improve ``Message.upgradeSchema` preconditions
7 years ago
ca28f3030b
Add `MessageMigration` module
7 years ago
8e762797c0
Remove attachment validation
...
Turns out `fileName` is optional and maybe even `contentType`. We should revisit
this at a later point in time.
7 years ago
09ee2d4ea2
Switch to using `requestIdleCallback`
...
Example:
https://developer.mozilla.org/en-US/docs/Web/API/Background_Tasks_API#Example
7 years ago
d13668544d
Rename `IdleListener` to `IdleDetector`
7 years ago
92ace67846
Start idle listener on startup
7 years ago
3140e4d66d
Implement basic `IdleListener`
7 years ago
0c06fff47b
Wire up `Message` / `Attachment` migration functions on startup
...
Makes `migrationContext` obsolete.
7 years ago
867f73b80a
Use double quotes for identifiers in error messages
7 years ago
70cdd2b350
Add `stringToArrayBuffer` utility
...
This way we can avoid an extra dependency.
7 years ago
2ad0fd7db6
Use Lodash `omit` instead of `delete`
7 years ago
ef2be2cf5f
Make `MessageView::onUnload` synchronous
...
Our tests rely on that.
7 years ago
b3251a8de2
Prevent potential NPE
7 years ago
9d25aa4e43
Delete attachment files on disk upon message delete
7 years ago
279b3f81c7
Add `Attachment.deleteData`
7 years ago
833a203559
Remove Vim modeline
7 years ago
e1c1b1aa72
Load attachment data before rendering
...
Prevent double rendering of attachments by multiple entries into
`MessageView::render` using promises.
7 years ago
97e3b49a36
Whitelist `js/views/message_view.js` for ESLint
7 years ago
b5721c2594
Remove Vim modeline
7 years ago
38e2468b2e
Set `schemaVersion` in `handleMessage`
7 years ago
e3dbeba963
Initialize schema version during `Message` construction
7 years ago
9a540d6d18
Load attachment data before sending message
7 years ago
8218e308cd
Improve identifier names
7 years ago
6355c54114
Return relative path from `writeAttachmentData`
...
This will make our app more robust to changes in location on the file system.
7 years ago
2cd3d5ac16
Add `Message` schema version 3
7 years ago
e0428355be
Wire up `writeAttachment`
7 years ago
aa82a2a5fb
Add `context` to `Message.upgradeSchema`
...
Allows us to pass in Electron/Node.js specific functions. This allows better
unit testing in Mocha where we don’t have access to Electron APIs.
7 years ago
ebe2a769c9
Add `Attachment.migrateDataToFileSystem`
7 years ago
1a117e3f78
Fix #2125 Prevent multiple settings modals
7 years ago
cea42bde7d
Encryption support for backup and restore
...
Also moved to the _ prefix in backup.js for all private methods exported
for testing.
7 years ago
6d8f4b7b6e
Backup: zipped messages.json, flat attachments dir
...
Backup creates, in a target directory:
- An attachments folder, with all attachments, each named for their
parent message's id - a GUID. If there is more than one attachment
in a given message, each attachment beyond the first will end with
'-N', zero-indexed.
- A file named messages.zip. It contains exactly what went to disk in
the original export code, but zipped up.
Export is now only 'light,' and in this new messages.zip format.
Import supports both the new format and the old format. If the target
directory has a messages.zip file, we'll treat it as the new format.
Next up: Encrypting attachments and the messages.zip!
7 years ago
153a22f46b
Exclude unnecessary data in export: profiles, replayable errors
7 years ago
Scott Nonnenberg
Daniel Gasienica
colefranz
Navdeep Singh