* add first integration test Session
Checking window title
Checking window count
Can restore from seed
* FIXME torevert once found why this crash on app close
* [test] add join valid open group test
* [test] validate cannot join two times the same open group
* [test] move common things to common.js
* [test] move tests to separate files
* [test] clean
* [test] add send message to open group test
* [test] lint
* [test] rename hooks -> common
* [test] add 15s delay before considering test as slow
* upgrade electron 8.0.3 and spectron 10.0.0
* [test] signin from seed: validate pubkey
* Replace spellchecker in favor of typo-js
* [test] refactor common calls to common.js
* [test] add two different pubkey, mnemonic and displayname
* [test] FIXME unsafe eval needed for now
* [test] add: add friends test
* [test] working multi instance tests
* [test] FIXME disable snodeproxy
* [test] update yarn.lock
* [test] make tests more robust with restart from scratch each test
* [test] add link of two devices test and hard rm of apps before start (rm -r)
* remove unused file
* [test] lint
* [test] add registration from generated pubkey test
* [test] add beginning of network stub
* [test] stub "token" endpoint
* [test] add test of one message on pub group pull
* [test] add starting port randomize. looks to help for some bad start with multi instance
* [test] add stub for one to one chats (sessions)
* [test] clean code
* [test] finish add friend test and stub snode server
* [test] stub calls during link device test
* [test] add a flag to show some logs on stubbed snode
* [test] finish link of two device test. check both pubkey matches
* [test] add and use function to wrap erase+start+login+stub app
* [test] add method to login as friend and closed group test&messages
* Revert "[test] FIXME unsafe eval needed for now"
This reverts commit de5322fdae6cdab8e3b9bd9a52b7d172c9bc2d26.
* [test] apply review
* [test] fix lint
* [test] fix existing test with new spectron version
* [test] fix lint
* [test] refactor page objects
* [test] add delete account test
* [test] add unlink of two device test
* [test] make tiny waitForExists -> isExisting
* [test] add checks of link new device buttons
* upgrade fs-extra@9.0.0
* address pr review
* [test] fix spell_check test
Co-authored-by: Josh Perez <60019601+josh-signal@users.noreply.github.com>
This is the reason that seeds across desktop and mobile devices would never restore to the same keypair. This function was there from the initial messenger days and with further discussion with Maxim, we deemed calling this function an unnecessary step for generating a keypair. There are no security implications for this change as we generate keypairs the exact same way as Signal does.
The biggest downside to this change however is that if you try to restore a desktop device with a seed from before this change, that seed will generate a completely different key pair and thus a different session ID.
This will only affect users who plan to restore any device from the seed of a desktop device before this change.
First it will ask the user about downloading the new update.
Then it will download the update and ask the user to restart the application.
This was done so that if the company was forced to put out comprimised binaries, all our users won't be automatically updated to them.
Vince
Audric Ackermann
Mikunj
Mikunj Varsani
Konstantin Ullrich
Ryan Tharp