Commit Graph

2136 Commits (12d9d4154881875128cf144ce1f2a43cea3effe6)

Author SHA1 Message Date
Scott Nonnenberg 12d9d41548
Move to better database deletion call; clears in-memory caches 7 years ago
Scott Nonnenberg c81d3f5c0b
Allow ConversationController.load() to be called more than once 7 years ago
Scott Nonnenberg 383e02edc4
New section in settings screen, full-screen 'are you sure?' 7 years ago
Scott Nonnenberg 198f356792
Return number (not id) in getNumber, remove unnecessary comment 7 years ago
Scott Nonnenberg 9acb189650
Remove config after unlink, clear db when linked with new number 7 years ago
Daniel Gasienica 8a1bff0fad Remove unused `require` 7 years ago
Daniel Gasienica 43b47fd349 Avoid `ensure-error` for privacy reasons
Example:

```
> node
> const nonError = {foo: 'i-am-private'};
undefined

// before
> util.inspect(nonError);
'{ foo: \'i-am-private\' }'

// after
> nonError.toString()
'[object Object]'
>
```
7 years ago
Daniel Gasienica ea07915e6b Escape special characters in file path 7 years ago
Daniel Gasienica 44b81f68dd Remove privacy redaction from `Errors.toLogFormat` 7 years ago
Daniel Gasienica 49e0850fb2 Extract `Privacy` module
Centralizes how we redact sensitive information.
7 years ago
Daniel Gasienica 0c317c5498 Redact all private information from logs 7 years ago
Daniel Gasienica 0e2f8a8a06 Extract `Errors.redactSensitivePaths` 7 years ago
Daniel Gasienica 33bbb12626 Use `Errors.toLogFormat` in `backgrounds.js` 7 years ago
Daniel Gasienica 3dffdc3f0b Rename `Errors` to `GlobalErrors` for clarity 7 years ago
Daniel Gasienica 2575196617 Extract `Errors.addGlobalHandler` procedure 7 years ago
Daniel Gasienica be3e4d86c2 Add `Errors.toLogFormat`
Allows errors to be formatted and sanitized for logging. Removes sensitive paths
such as the app root directory.

Ideally, this module would be called singular `Error` but that is already a
global name. Using `Errors` plural is  similar to Java convention for utilities
such as `Arrays`, `Collections`, `Files`, etc. See:
https://stackoverflow.com/a/11673838
7 years ago
Daniel Gasienica b049412bfd Document workaround for `got` `FormData` bug
See: https://github.com/sindresorhus/got/pull/466
7 years ago
Daniel Gasienica 710701d0fc Document why `key` comes first 7 years ago
Daniel Gasienica 8b71155e7c Replace `superagent` with `got` for debug logs 7 years ago
Daniel Gasienica 52f7de6a10 Add `debuglogs` module 7 years ago
Daniel Gasienica e4b34a6287 Make `DebugLogView::submit` async 7 years ago
Daniel Gasienica 3ab3e93a28 Upload debug logs to debuglogs.org 7 years ago
Daniel Gasienica cb464c6301 Ensure `isFocused` always returns boolean 7 years ago
Daniel Gasienica 969127a72a Remove triple parens 7 years ago
Daniel Gasienica f6fd979ccb Remove explicit ESLint `browser` directives 7 years ago
Daniel Gasienica 168788600a Fix lint errors 7 years ago
Daniel Gasienica 325c0628cd Remove Vim modeline 7 years ago
Daniel Gasienica b3a3729261 Fix lint errors 7 years ago
Daniel Gasienica 6f7f55f783 Whitelist globals 7 years ago
Daniel Gasienica 090345523f Disable ESLint `strict` rule for module
`js/logging.js` acts as a module even though it lives in `js/*`.
7 years ago
Daniel Gasienica 7db44e35bd Allow `node` environment for `js/logging.js` 7 years ago
Daniel Gasienica d4c9422a99 Apply ESLint auto-fixes: `debug_log_view.js` 7 years ago
Daniel Gasienica 5d6cd0ea39 Apply ESLint auto-fixes: `js/logging.js` 7 years ago
Daniel Gasienica a61f2939fd Make `isEnabled` an instance variable 7 years ago
Daniel Gasienica d6ff5af843 🎨 `shouldUpdate` --> `needUpdate` 7 years ago
Daniel Gasienica 541e0bfb72 Reduce log noise / size 7 years ago
Daniel Gasienica a5a4ed7de7 Extract `isAudioNotificationEnabled` constant 7 years ago
Daniel Gasienica dc38d40f20 Revert to disabled notification sound on <= Windows 7
We haven’t had the chance to test this using `node-notifier` on Windows 7.
7 years ago
Daniel Gasienica 5a4773fee7 Only play audio notification on supported platforms 7 years ago
Daniel Gasienica 85b121aca4 Rename `shouldShowAudioNotificationSetting`
Use `isAudioNotificationSupported` to make it less presentation layer specific.
7 years ago
Daniel Gasienica dcf651fb51 Hide notifications audio setting on Linux 7 years ago
Daniel Gasienica 21339c6866 Add `Settings` type 7 years ago
Daniel Gasienica 91daedd619 Add `OS` module 7 years ago
Daniel Gasienica dbc242c37f Improve debug log for notifications 7 years ago
Daniel Gasienica b5e7882267 Use system notification sounds
Alternatively, there is per-platform support for specific sounds, but that would
require a larger investment:
- macOS: 9420a38fc3 (all-notification-options-with-their-defaults)
- Windows: https://docs.microsoft.com/en-us/previous-versions/windows/apps/hh761492(v=win.10)
7 years ago
Daniel Gasienica 59e59fb754 Remove new message audio notification
Bye, bye, dear Ka-Klunk!
7 years ago
Daniel Gasienica 8a8972f7ac NOTE: Improve i18n pluralization 7 years ago
Daniel Gasienica a76b1389e6 Extract `hasNotifications` 7 years ago
Daniel Gasienica 9516d667da Rename `enabled` --> `isEnabled` 7 years ago
Scott Nonnenberg 59bee6690d
Choose device name screen: Finish by pressing enter (#2085) 7 years ago