4d04638358 
								
							
								 
							
						 
						
							
							
								
								Document changes for MVP  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								c3e04ecf87 
								
							
								 
							
						 
						
							
							
								
								Remove use of `LoadingIndicator`  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								6d5d0df1c0 
								
							
								 
							
						 
						
							
							
								
								🎨  Fix TSLint errors  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								8b9516de72 
								
							
								 
							
						 
						
							
							
								
								Update test for attachment metadata  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								f240269d7b 
								
							
								 
							
						 
						
							
							
								
								MVP: Only show images in media gallery  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								b4e3749c88 
								
							
								 
							
						 
						
							
							
								
								MVP: Only show media tab  
							
							... 
							
							
							
							Until we support showing documents. 
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								60ed82b728 
								
							
								 
							
						 
						
							
							
								
								Show all lightbox controls in style guide  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								a7ed21a811 
								
							
								 
							
						 
						
							
							
								
								Add `shouldShowSaveAsButton` option  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								0d676a65b8 
								
							
								 
							
						 
						
							
							
								
								Open media gallery item in lightbox  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								a9f7f18721 
								
							
								 
							
						 
						
							
							
								
								Add `ItemClickEvent`  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								d634a414c3 
								
							
								 
							
						 
						
							
							
								
								Make visibility of previous/next buttons opt-in  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								142236640e 
								
							
								 
							
						 
						
							
							
								
								Click lightbox to close  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								ce825fbd66 
								
							
								 
							
						 
						
							
							
								
								Rename `save` to `onSave`  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								1b9e581e90 
								
							
								 
							
						 
						
							
							
								
								Show lightbox image as large as possible  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								2cb0b0aeb1 
								
							
								 
							
						 
						
							
							
								
								Add arrow controls  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								246e0ca87b 
								
							
								 
							
						 
						
							
							
								
								Add note about inline styles  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								d797ede791 
								
							
								 
							
						 
						
							
							
								
								Close lightbox on escape key press  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								86da80fd23 
								
							
								 
							
						 
						
							
							
								
								Wire up attachment saving  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								593976fe21 
								
							
								 
							
						 
						
							
							
								
								Extract Backbone Lightbox view module  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								2474b42198 
								
							
								 
							
						 
						
							
							
								
								Port lightbox icon buttons  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								4a5a2cb5c1 
								
							
								 
							
						 
						
							
							
								
								Replace Backbone with React lightbox  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								cb94d09ef9 
								
							
								 
							
						 
						
							
							
								
								Rename media gallery items  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								5d0469adef 
								
							
								 
							
						 
						
							
							
								
								Skip loading videos into memory for performance  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								c6904476f4 
								
							
								 
							
						 
						
							
							
								
								Improve `IndexableBoolean` type  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								809e34b0f4 
								
							
								 
							
						 
						
							
							
								
								Load 50 attachments for media gallery  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								0a4be2e0f4 
								
							
								 
							
						 
						
							
							
								
								Remove unused `i18n`  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								4ce0472b9f 
								
							
								 
							
						 
						
							
							
								
								Extract `Message.loadWithObjectURL`  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								45d89d1e44 
								
							
								 
							
						 
						
							
							
								
								Create `UserMessage` type  
							
							... 
							
							
							
							Describes user visible messages that can have attachments. 
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								27c4bf90e3 
								
							
								 
							
						 
						
							
							
								
								Add `Signal.Backbone`  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								825980fbd1 
								
							
								 
							
						 
						
							
							
								
								Add `Collection.fetchVisualMediaAttachments`  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								cad5e417f3 
								
							
								 
							
						 
						
							
							
								
								Add `arrayBufferToObjectURL` module  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								e5d90775d0 
								
							
								 
							
						 
						
							
							
								
								Add `MapAsync` type definition  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								648a7ab1bb 
								
							
								 
							
						 
						
							
							
								
								Autoformat using Prettier  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								e07458d886 
								
							
								 
							
						 
						
							
							
								
								Add basic Backbone type definitions  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								9d84b2f420 
								
							
								 
							
						 
						
							
							
								
								Index messages with attachments using a boolean  
							
							... 
							
							
							
							When indexing message attachment metadata using numeric indexes such as:
```javascript
{
  conversationId: '+12223334455',
  received_at: 123,
  attachments: […],
  numAttachments: 2,
},
{
  conversationId: '+12223334455',
  received_at: 456,
  attachments: [],
  numAttachments: 0,
}
{
  conversationId: '+12223334455',
  received_at: 789,
  attachments: [],
  numAttachments: 1,
}
```
It creates an index as follows:
```
[conversationId, received_at, numAttachments]
['+12223334455', 123, 2]
['+12223334455', 456, 0]
['+12223334455', 789, 1]
```
This means a query such as…
```
lowerBound: ['+12223334455', 0,                1               ]
upperBound: ['+12223334455', Number.MAX_VALUE, Number.MAX_VALUE]
```
…will return all three original entries because they span the `received_at`
from `0` through `Number.MAX_VALUE`. One workaround is to index booleans using
`1 | undefined` where `1` is included in the index and `undefined` is not, but
that way we lose the ability to query for the `false` value. Instead, we flip
adjust the index to `[conversationId, hasAttachments, received_at]` and can
then query messages with attachments using
```
[conversationId, 1 /* hasAttachments */, 0                /* received_at */]
[conversationId, 1 /* hasAttachments */, Number.MAX_VALUE /* received_at */]
``` 
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								c46e1a1519 
								
							
								 
							
						 
						
							
							
								
								Move top-level functions to `Signal.Util`  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								a609c31a57 
								
							
								 
							
						 
						
							
							
								
								Style attachment section headers  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								ae4c74dd5b 
								
							
								 
							
						 
						
							
							
								
								Skip metadata initialization for `verified-change` messages  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								b0fefdbb98 
								
							
								 
							
						 
						
							
							
								
								Implementing grouping messages by date  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								424965f876 
								
							
								 
							
						 
						
							
							
								
								🎨  Autoformat code  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								f367a9b059 
								
							
								 
							
						 
						
							
							
								
								Move `private` method below `public` ones  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								3d70e46aea 
								
							
								 
							
						 
						
							
							
								
								Calculate dates in UTC  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								d7b21ef5dc 
								
							
								 
							
						 
						
							
							
								
								Render attachments grouped by date  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								e34347f290 
								
							
								 
							
						 
						
							
							
								
								Add `groupMessagesByDate`  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								9053b6acfc 
								
							
								 
							
						 
						
							
							
								
								Remove unused style  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								66516fd36a 
								
							
								 
							
						 
						
							
							
								
								Use short format for dates  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								923d5ff088 
								
							
								 
							
						 
						
							
							
								
								Add `missingCaseError` function  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								fc1c3aabf5 
								
							
								 
							
						 
						
							
							
								
								Add scaffolding for media gallery  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								a8be4f2d8d 
								
							
								 
							
						 
						
							
							
								
								Expose Lodash in style guide  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								94ef3bab80 
								
							
								 
							
						 
						
							
							
								
								Move test file  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								32a3ef518b 
								
							
								 
							
						 
						
							
							
								
								Render media gallery placeholder panel  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								f9e4613395 
								
							
								 
							
						 
						
							
							
								
								Move TS test for message migration  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								867bece952 
								
							
								 
							
						 
						
							
							
								
								Add `Message.initializeAttachmentMetadata`  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								c5352cf26c 
								
							
								 
							
						 
						
							
							
								
								Separate required from optional `Message` keys  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								fc12353bb8 
								
							
								 
							
						 
						
							
							
								
								Add `Attachment.isVisualMedia`  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								47cc701e72 
								
							
								 
							
						 
						
							
							
								
								Add `GoogleChrome` module  
							
							... 
							
							
							
							Helps us determine which media we can natively display / play back in Electron. 
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								6ff82adf0a 
								
							
								 
							
						 
						
							
							
								
								Add `MIME.isImage` and `MIME.isVideo`  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								df2e6e7864 
								
							
								 
							
						 
						
							
							
								
								Port `MIME` module to TypeScript  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								ef1d568a80 
								
									
								
							
								 
							
						 
						
							
							
								
								Restore rendering of group update and end session messages  
							
							... 
							
							
							
							The previous work to refactor bubbles broke rendering for these message
types. :0/ 
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								fdc13d0af3 
								
									
								
							
								 
							
						 
						
							
							
								
								Fix some tslint errors  
							
							... 
							
							
							
							I really need to get it running in my editor! 
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								bd88407b78 
								
									
								
							
								 
							
						 
						
							
							
								
								iOS theme: Permanant background to attachment part of bubble  
							
							... 
							
							
							
							(this is to handle a quote making bubble wider, but a narrow image) 
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								21713cbce7 
								
									
								
							
								 
							
						 
						
							
							
								
								Update quotes to render emoji just like normal messages  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								37cac717cb 
								
									
								
							
								 
							
						 
						
							
							
								
								Use fit: cover for non-square thumbnails, better movie icon  
							
							... 
							
							
							
							Also: Match Android's X button in the quote composition area 
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								12257e1560 
								
									
								
							
								 
							
						 
						
							
							
								
								MessageView: Show menu w/ 'reply to message' on triple-dot click  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								f4d9ab8ba0 
								
									
								
							
								 
							
						 
						
							
							
								
								Put quote preview in text box for Android, above it in iOS  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								c71dcf0139 
								
									
								
							
								 
							
						 
						
							
							
								
								Show current quoted message above composition field  
							
							... 
							
							
							
							Note that substantial changes will be required for the updated Android
mockups, putting the quotation into the text box next to the attachment
preview. 
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								d29162f3b6 
								
									
								
							
								 
							
						 
						
							
							
								
								CSS Refactor: Pull quote CSS out from parent classes  
							
							... 
							
							
							
							This is to prepare for it to be shown in the message composition area. 
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								26e4e97592 
								
									
								
							
								 
							
						 
						
							
							
								
								Tighten up CSS  
							
							... 
							
							
							
							- Remove extra padding at top of Android bubbles, via sibling selector
- Don't include .attachments, .quote-wrapper, .content in bubble unless
  we actually need them. This allows for sibling selectors.
- This is a different technique for adding the ReactWrapperView for
  quotes - it is now appended to the DOM instead of attaching to
  something already in the DOM. This allows us to use .remove(), so it's
  a bit cleaner.
- Users of ReactWrapperView can now specify tagName and className 
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								a563dc8b37 
								
									
								
							
								 
							
						 
						
							
							
								
								Style Guide: Additional message examples, a few fixes to enable  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								5af5bbdb0f 
								
									
								
							
								 
							
						 
						
							
							
								
								Add style guide examples for portrait/landscape images  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								e3d15d80f6 
								
									
								
							
								 
							
						 
						
							
							
								
								Quote.md: Fix image example, add examples for attachment + reply  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								7bd747a796 
								
									
								
							
								 
							
						 
						
							
							
								
								ConversationContext: conversationType => type  
							
							... 
							
							
							
							And a group conversation example to messages.md 
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								3bbbf65a6b 
								
									
								
							
								 
							
						 
						
							
							
								
								Fix iOS: tail, blue partial border, extra attachment space  
							
							... 
							
							
							
							Turns out that display: inline on the img tag resulted in a mysterious
3px of space added below it. 
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								c283ba1a12 
								
									
								
							
								 
							
						 
						
							
							
								
								Remove pointer cursor when clicking on quote won't do anything  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								fce9bb7342 
								
									
								
							
								 
							
						 
						
							
							
								
								Move to central MIME functions, remove some console.log  
							
							... 
							
							
							
							And generally address PR feedback. 
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								d91f40177e 
								
									
								
							
								 
							
						 
						
							
							
								
								Quote.tsx: Fix tslint errors  
							
							... 
							
							
							
							I really need to get tslint editor integration in place. 
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								a0b1dea693 
								
									
								
							
								 
							
						 
						
							
							
								
								Introduce a bit of color to the message/attachment style guide  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								b458c7d449 
								
									
								
							
								 
							
						 
						
							
							
								
								android-dark: Constrain light play icon to with peer image  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								bdaebc24ae 
								
									
								
							
								 
							
						 
						
							
							
								
								A few tweaks for the android-dark theme  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								087dd0f758 
								
									
								
							
								 
							
						 
						
							
							
								
								Support for iOS theme  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								644bc9e6fb 
								
									
								
							
								 
							
						 
						
							
							
								
								Fix problem of squished quote icons and images  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								2243e348f1 
								
									
								
							
								 
							
						 
						
							
							
								
								Wire up fake window.Signal.HTML because it's captured on load  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								0f8dd7e2db 
								
									
								
							
								 
							
						 
						
							
							
								
								Fix a number of lint failures  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								1cc0633786 
								
									
								
							
								 
							
						 
						
							
							
								
								Full support for quotations in Android theme  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								21bf02c94d 
								
									
								
							
								 
							
						 
						
							
							
								
								Fixed examples in Quote.md, rough Android visuals  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								6653123671 
								
									
								
							
								 
							
						 
						
							
							
								
								Move quote-related examples from Message.md to Quote.md  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								b4ce79cac0 
								
									
								
							
								 
							
						 
						
							
							
								
								Reply -> Quote  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								09c3fbc5e2 
								
									
								
							
								 
							
						 
						
							
							
								
								Style guide: All permutations of text reply to diff. quote types  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								ae043bf239 
								
									
								
							
								 
							
						 
						
							
							
								
								In iOS theme, join attachment bubble with caption bubble  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								3a76c3c86e 
								
									
								
							
								 
							
						 
						
							
							
								
								Styleguide: Incoming/outgoing attachments of all types  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								44debd123d 
								
							
								 
							
						 
						
							
							
								
								Add basic implementation of `Conversation.updateFromLastMessage`  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								cca5db3237 
								
							
								 
							
						 
						
							
							
								
								Remove unused import  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								1659354f51 
								
							
								 
							
						 
						
							
							
								
								Expand `Message` type definitions  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								b50c55172d 
								
							
								 
							
						 
						
							
							
								
								Add `MIME` type  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								65bf34d1b8 
								
							
								 
							
						 
						
							
							
								
								Add basic `Attachment` type definition  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								f25a579f32 
								
							
								 
							
						 
						
							
							
								
								Add basic `Message` type definition  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								bcd3e26377 
								
							
								 
							
						 
						
							
							
								
								Fix TS warning about `appendChild`  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								55fc21505e 
								
							
								 
							
						 
						
							
							
								
								Rename `ts/test` to `ts/styleguide`  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								9d41b86162 
								
							
								 
							
						 
						
							
							
								
								Remove escaping from `linkText`  
							
							... 
							
							
							
							We leverage jQuery’s HTML escaping in `$.html(…)`. 
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								f04c65088b 
								
							
								 
							
						 
						
							
							
								
								Fork `link-text` module  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								144cb58a47 
								
							
								 
							
						 
						
							
							
								
								Add `HTML` module for rendering messages  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								f38370f40e 
								
							
								 
							
						 
						
							
							
								
								Add custom type definition for `link-text`  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								96bd90a4e0 
								
									
								
							
								 
							
						 
						
							
							
								
								Simplify assignment; add warning to preload.js about Style Guide  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								05303233fb 
								
									
								
							
								 
							
						 
						
							
							
								
								window.Signal.React -> window.Signal.Components  
							
							
							
						 
						
							8 years ago  
				
					
						
							
							
								 
						
							
							
								23537546fe 
								
									
								
							
								 
							
						 
						
							
							
								
								Big refactor: ts/ directory for all typescript, including react  
							
							... 
							
							
							
							Split out test-specific and general utility react components too.
And moved our test/legacy* files for the Style Guide into a styleguide/
subdirectory of test/.
I think we'll be able to live in this directory structure for a while. 
							
						 
						
							8 years ago